Merge pull request #27876 from b4s36t4/fix/transition-on-request-page

fix transition of profiles on request confirmation page
Expensify · Sep 22, 2023 · 136c364 · 136c364
2 parents 0851888 + 0e2e9ef
commit 136c364
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/pages/ProfilePage.js b/src/pages/ProfilePage.js
@@ -99,13 +99,6 @@ const getPhoneNumber = (details) => {
 function ProfilePage(props) {
     const accountID = Number(lodashGet(props.route.params, 'accountID', 0));
 
-    // eslint-disable-next-line rulesdir/prefer-early-return
-    useEffect(() => {
-        if (ValidationUtils.isValidAccountRoute(accountID)) {
-            PersonalDetails.openPublicProfilePage(accountID);
-        }
-    }, [accountID]);
-
     const details = lodashGet(props.personalDetails, accountID, ValidationUtils.isValidAccountRoute(accountID) ? {} : {isloading: false});
 
     const displayName = details.displayName ? details.displayName : props.translate('common.hidden');
@@ -143,6 +136,13 @@ function ProfilePage(props) {
 
     const chatReportWithCurrentUser = !isCurrentUser && !Session.isAnonymousUser() ? ReportUtils.getChatByParticipants([accountID]) : 0;
 
+    // eslint-disable-next-line rulesdir/prefer-early-return
+    useEffect(() => {
+        if (ValidationUtils.isValidAccountRoute(accountID) && !hasMinimumDetails) {
+            PersonalDetails.openPublicProfilePage(accountID);
+        }
+    }, [accountID, hasMinimumDetails]);
+
     return (
         <ScreenWrapper testID="ProfilePage">
             <HeaderWithBackButton