Merge pull request #53886 from s77rt/no-RBR-for-expense-reports

do not show RBR for expense reports
Expensify · Dec 12, 2024 · b372ca2 · b372ca2
2 parents 72f36b9 + c0eb009
commit b372ca2
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/components/LHNOptionsList/OptionRowLHNData.tsx b/src/components/LHNOptionsList/OptionRowLHNData.tsx
@@ -40,8 +40,6 @@ function OptionRowLHNData({
     const shouldDisplayViolations = ReportUtils.shouldDisplayViolationsRBRInLHN(fullReport, transactionViolations);
     const isSettled = ReportUtils.isSettled(fullReport);
     const shouldDisplayReportViolations = !isSettled && ReportUtils.isReportOwner(fullReport) && ReportUtils.hasReportViolations(reportID);
-    // We only want to show RBR for expense reports with transaction violations not for transaction threads reports.
-    const doesExpenseReportHasViolations = ReportUtils.isExpenseReport(fullReport) && !isSettled && ReportUtils.hasViolations(reportID, transactionViolations, true);
 
     const optionItem = useMemo(() => {
         // Note: ideally we'd have this as a dependent selector in onyx!
@@ -52,7 +50,7 @@ function OptionRowLHNData({
             preferredLocale: preferredLocale ?? CONST.LOCALES.DEFAULT,
             policy,
             parentReportAction,
-            hasViolations: !!shouldDisplayViolations || shouldDisplayReportViolations || doesExpenseReportHasViolations,
+            hasViolations: !!shouldDisplayViolations || shouldDisplayReportViolations,
             lastMessageTextFromReport,
             transactionViolations,
             invoiceReceiverPolicy,