fix: improve perf of isActionOfType by limiting calls to the includes

Expensify · Jul 30, 2024 · f1d2200 · f1d2200
1 parent 3418820
commit f1d2200
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts
@@ -189,7 +189,14 @@ function isActionOfType<T extends ReportActionName[]>(
 ): action is {
     [K in keyof T]: ReportAction<T[K]>;
 }[number] {
-    return actionNames.includes(action?.actionName as T[number]);
+    const actionName = action?.actionName as T[number];
+
+    // This is purely a performance optimization to limit the 'includes()' calls on Hermes
+    if (actionNames.length === 1) {
+        return actionNames[0] === actionName;
+    }
+
+    return actionNames.includes(actionName);
 }
 
 function getOriginalMessage<T extends ReportActionName>(reportAction: OnyxInputOrEntry<ReportAction<T>>): OriginalMessage<T> | undefined {