Move modal hide and key-listener cleanup to new fn

Expensify · Mar 15, 2021 · f5e7b9f · f5e7b9f
1 parent 7743763
commit f5e7b9f
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/src/components/Modal/BaseModal.js b/src/components/Modal/BaseModal.js
@@ -14,13 +14,22 @@ class BaseModal extends PureComponent {
     constructor(props) {
         super(props);
 
+        this.hideModalAndRemoveEventListeners = this.hideModalAndRemoveEventListeners.bind(this);
         this.subscribeToKeyEvents = this.subscribeToKeyEvents.bind(this);
         this.unsubscribeFromKeyEvents = this.unsubscribeFromKeyEvents.bind(this);
     }
 
     componentWillUnmount() {
+        this.hideModalAndRemoveEventListeners();
+    }
+
+    /**
+     * Hides modal and unsubscribes from key event listeners
+     */
+    hideModalAndRemoveEventListeners() {
         this.unsubscribeFromKeyEvents();
         setModalVisibility(false);
+        this.props.onModalHide();
     }
 
     /**
@@ -66,11 +75,7 @@ class BaseModal extends PureComponent {
                     this.subscribeToKeyEvents();
                     setModalVisibility(true);
                 }}
-                onModalHide={() => {
-                    this.unsubscribeFromKeyEvents();
-                    setModalVisibility(false);
-                    this.props.onModalHide();
-                }}
+                onModalHide={this.hideModalAndRemoveEventListeners}
                 onSwipeComplete={this.props.onClose}
                 swipeDirection={swipeDirection}
                 isVisible={this.props.isVisible}