Skip to content

Commit

Permalink
Merge pull request #23156 from esh-g/menuItem-lineHeight
Browse files Browse the repository at this point in the history
Remove lhNormal from MenuItem
  • Loading branch information
pecanoro authored Jul 19, 2023
2 parents ea827c2 + 65daa5b commit fa473e9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion src/components/MenuItem.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ function MenuItem(props) {
const descriptionTextStyle = StyleUtils.combineStyles([
styles.textLabelSupporting,
props.icon && !_.isArray(props.icon) ? styles.ml3 : undefined,
styles.lhNormal,
props.title ? descriptionVerticalMargin : StyleUtils.getFontSizeStyle(variables.fontSizeNormal),
props.descriptionTextStyle,
isDeleted ? styles.offlineFeedback.deleted : undefined,
Expand Down
2 changes: 1 addition & 1 deletion src/components/ReportActionItem/MoneyReportView.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function MoneyReportView(props) {
<View style={[styles.flexRow, styles.menuItemTextContainer, styles.pointerEventsNone, styles.containerWithSpaceBetween, styles.ph5, styles.pv2]}>
<View style={[styles.flex1, styles.justifyContentCenter]}>
<Text
style={[styles.textLabelSupporting, styles.lhNormal, StyleUtils.getFontSizeStyle(variables.fontSizeNormal)]}
style={[styles.textLabelSupporting, StyleUtils.getFontSizeStyle(variables.fontSizeNormal)]}
numberOfLines={1}
>
{translate('common.total')}
Expand Down
4 changes: 0 additions & 4 deletions src/styles/styles.js
Original file line number Diff line number Diff line change
Expand Up @@ -1073,10 +1073,6 @@ const styles = {
lineHeight: '140%',
},

lhNormal: {
lineHeight: variables.lineHeightNormal,
},

formHelp: {
color: themeColors.textSupporting,
fontSize: variables.fontSizeLabel,
Expand Down

0 comments on commit fa473e9

Please sign in to comment.