[Bug] IOS/Android - Unable to open links via App. #10431

kbecciv · 2022-08-17T14:42:20Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #10144

Action Performed:

Open the app.
Send a message with the following links:
https://staging.new.expensify.com/r/99123880
https://new.expensify.com/
https://expensify.com/
https://new.expensify.com/inbox
https://expensify.com/inbox
google.com
Click on a link to open it.

Expected Result:

Old Expensify links open in a new tab but you are directly logged into the old Expensify app if the URL is valid.
Public links open in a new tab.

Actual Result:

Unable to open a link. Nothing happens when tapping on a link.

Workaround:

Unknown

Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.88.14

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+092021fish@applause.expensifail.com/Qwerty123
rybkina@gmail.com/Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5692300_RPReplay_Final1660743767.mp4

Bug5692300_RPReplay_Final1660745681.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

OSBotify · 2022-08-17T14:45:07Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2022-08-17T14:45:10Z

Triggered auto assignment to @PauloGasparSv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Julesssss · 2022-08-17T15:09:47Z

Wow, so I was unable to reproduce on Android v1.1.88-3, but after updating to v1.1.88.14 I can't open any links...

PauloGasparSv · 2022-08-17T15:21:18Z

Also replicated on iOS on the same version and the latest on main. Could not replicate this on Web, @kbecciv can you confirm again if the issue also happens on web?

kbecciv · 2022-08-17T15:32:23Z

@PauloGasparSv Checking with team, will update you shortly

kbecciv · 2022-08-17T15:43:28Z

Works on Web

Recording.984.mp4

PauloGasparSv · 2022-08-17T18:00:33Z

Spent some time but couldn't find which versions introduced the bug.
Assigning @marcaaron here to help so I can focus on some refactor work I'm in!

parasharrajat · 2022-08-17T18:23:49Z

Is this is same as on of #9739 (comment)?

marcaaron · 2022-08-17T19:18:38Z

This issue was introduced in #10144

I reproduced on main by:

Creating a new chat and adding a link to expensify.com
Attempt to tap the link 💥
Revert PR
Attempt to tap the link ✅

marcaaron · 2022-08-17T19:19:21Z

Internal app links like new.expensify.com/settings work Ok. External links like expensify.com do not work.

marcaaron · 2022-08-17T19:23:42Z

Created a revert PR to undo the changes. Seems like we are having some issues with GitHub actions at the moment so unsure if unblocking the deploy is our most urgent priority.

AndrewGable · 2022-08-23T14:52:59Z

I can no longer reproduce on staging so closing. Confirmed with @sketchydroide too.

melvin-bot · 2022-08-23T18:50:57Z

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

marcaaron · 2022-08-23T19:19:58Z

What did you all test @sketchydroide @AndrewGable? External links are very broken for me still on the latest TF.

parasharrajat · 2022-08-23T19:25:14Z

Yeah they are still broken. I have created the fixing PR.

AndrewGable · 2022-08-23T21:21:33Z

Tested via web staging

marcaaron · 2022-08-24T11:25:31Z

haha ok, and we are aware that the issue is not affecting web? Sorry for the questions it's just that this issue is very much present on staging iOS. No external links are tappable at all.

#10431 (comment)

sketchydroide · 2022-08-24T13:01:01Z

Yes, I've just checked iOS, and the app failled to direct the links, and one of them crashed the app, this are the links @AndrewGable sent me:

https://staging.new.expensify.com/r/99123880 
https://new.expensify.com/ 
https://expensify.com/ 
https://new.expensify.com/inbox 
https://expensify.com/inbox 
https://google.com/

https://new.expensify.com/inbox crashes
https://staging.new.expensify.com/r/99123880 redirects me to the list of users (I don't have that report/chat)

all the other ones fail to do anything

parasharrajat · 2022-08-24T13:06:47Z

all the other ones fail to do anything
Yeah, I know why this is happening, here is the PR for the fix #10503.

the Crashes issue is a different one than this and not caused by that PR. The reason is that https://new.expensify.com/inbox is an unknown route in our app and our internal link handlers don't have fallback rules for such links. Reported here #9739 (comment).

parasharrajat · 2022-08-24T13:07:37Z

We should reopen this issue.

marcaaron · 2022-08-24T14:08:11Z

Since we deployed and this is a regression I'm removing the DeployBlockerCash label and assigning @parasharrajat to fix.

parasharrajat · 2022-08-24T14:59:21Z

Adding screenshots to the PR and it will be ready in 15 mins.

melvin-bot · 2022-08-30T17:10:53Z

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot · 2022-09-06T06:55:12Z

@parasharrajat, @marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

parasharrajat · 2022-09-06T07:11:08Z

PR is in review.

melvin-bot · 2022-09-14T06:30:26Z

@parasharrajat, @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

parasharrajat · 2022-09-14T06:34:37Z

PR was merged.

melvin-bot · 2022-09-23T06:43:21Z

@parasharrajat, @marcaaron Eep! 4 days overdue now. Issues have feelings too...

melvin-bot · 2022-09-28T06:14:30Z

@parasharrajat, @marcaaron 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

parasharrajat · 2022-09-28T08:53:12Z

This has been fixed. Good to close.

sketchydroide · 2022-09-28T09:06:10Z

closing

kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Aug 17, 2022

OSBotify mentioned this issue Aug 17, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

github-actions bot added Engineering Hourly KSv2 labels Aug 17, 2022

melvin-bot bot assigned PauloGasparSv Aug 17, 2022

Julesssss self-assigned this Aug 17, 2022

PauloGasparSv assigned marcaaron and unassigned PauloGasparSv Aug 17, 2022

melvin-bot bot mentioned this issue Aug 17, 2022

[HOLD for payment 2022-09-26] [$1000] When you send old :expensify: link and hover you will not see any tooltip and the link is without underline - reported by @Puneet-here #9739

Closed

marcaaron mentioned this issue Aug 17, 2022

[HOLD] Revert "Fix anchor renderer for links in report messages & clean up" #10433

Closed

Julesssss removed their assignment Aug 18, 2022

arosiclair mentioned this issue Aug 18, 2022

Exclude concierge links from OldDot link handling #10310

Merged

93 tasks

AndrewGable closed this as completed Aug 23, 2022

parasharrajat mentioned this issue Aug 23, 2022

Fix the native link renderer #10503

Merged

93 tasks

AndrewGable reopened this Aug 24, 2022

marcaaron added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Aug 24, 2022

marcaaron assigned parasharrajat Aug 24, 2022

melvin-bot bot added the Overdue label Aug 29, 2022

marcaaron added the Reviewing Has a PR in review label Aug 29, 2022

melvin-bot bot removed the Overdue label Aug 29, 2022

JmillsExpensify changed the title ~~IOS/Android - Unable to open linsk via App.~~ IOS/Android - Unable to open links via App. Sep 14, 2022

JmillsExpensify changed the title ~~IOS/Android - Unable to open links via App.~~ [Bug] IOS/Android - Unable to open links via App. Sep 22, 2022

sketchydroide closed this as completed Sep 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug] IOS/Android - Unable to open links via App. #10431

[Bug] IOS/Android - Unable to open links via App. #10431

kbecciv commented Aug 17, 2022

OSBotify commented Aug 17, 2022

melvin-bot bot commented Aug 17, 2022

Julesssss commented Aug 17, 2022 •

edited

Loading

PauloGasparSv commented Aug 17, 2022

kbecciv commented Aug 17, 2022

kbecciv commented Aug 17, 2022

PauloGasparSv commented Aug 17, 2022

parasharrajat commented Aug 17, 2022

marcaaron commented Aug 17, 2022

marcaaron commented Aug 17, 2022

marcaaron commented Aug 17, 2022

AndrewGable commented Aug 23, 2022

melvin-bot bot commented Aug 23, 2022

marcaaron commented Aug 23, 2022

parasharrajat commented Aug 23, 2022

AndrewGable commented Aug 23, 2022

marcaaron commented Aug 24, 2022 •

edited

Loading

sketchydroide commented Aug 24, 2022

parasharrajat commented Aug 24, 2022 •

edited

Loading

parasharrajat commented Aug 24, 2022

marcaaron commented Aug 24, 2022 •

edited

Loading

parasharrajat commented Aug 24, 2022

melvin-bot bot commented Aug 30, 2022

melvin-bot bot commented Sep 6, 2022

parasharrajat commented Sep 6, 2022

melvin-bot bot commented Sep 14, 2022

parasharrajat commented Sep 14, 2022

melvin-bot bot commented Sep 23, 2022

melvin-bot bot commented Sep 28, 2022

parasharrajat commented Sep 28, 2022

sketchydroide commented Sep 28, 2022

[Bug] IOS/Android - Unable to open links via App. #10431

[Bug] IOS/Android - Unable to open links via App. #10431

Comments

kbecciv commented Aug 17, 2022

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

OSBotify commented Aug 17, 2022

melvin-bot bot commented Aug 17, 2022

Julesssss commented Aug 17, 2022 • edited Loading

PauloGasparSv commented Aug 17, 2022

kbecciv commented Aug 17, 2022

kbecciv commented Aug 17, 2022

PauloGasparSv commented Aug 17, 2022

parasharrajat commented Aug 17, 2022

marcaaron commented Aug 17, 2022

marcaaron commented Aug 17, 2022

marcaaron commented Aug 17, 2022

AndrewGable commented Aug 23, 2022

melvin-bot bot commented Aug 23, 2022

marcaaron commented Aug 23, 2022

parasharrajat commented Aug 23, 2022

AndrewGable commented Aug 23, 2022

marcaaron commented Aug 24, 2022 • edited Loading

sketchydroide commented Aug 24, 2022

parasharrajat commented Aug 24, 2022 • edited Loading

parasharrajat commented Aug 24, 2022

marcaaron commented Aug 24, 2022 • edited Loading

parasharrajat commented Aug 24, 2022

melvin-bot bot commented Aug 30, 2022

melvin-bot bot commented Sep 6, 2022

parasharrajat commented Sep 6, 2022

melvin-bot bot commented Sep 14, 2022

parasharrajat commented Sep 14, 2022

melvin-bot bot commented Sep 23, 2022

melvin-bot bot commented Sep 28, 2022

parasharrajat commented Sep 28, 2022

sketchydroide commented Sep 28, 2022

Julesssss commented Aug 17, 2022 •

edited

Loading

marcaaron commented Aug 24, 2022 •

edited

Loading

parasharrajat commented Aug 24, 2022 •

edited

Loading

marcaaron commented Aug 24, 2022 •

edited

Loading