Deploy Checklist: New Expensify 2022-10-19

[OSBotify]

Release Version: 1.2.18-10
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Desktop - Chat - New marker disappears after App minimize/restore #11150
• fix "Composer goes to the top on pressing expand" #11608
• Deprecate reimbursementAccountDraftValues #11640
• Display message to user when account is closed #11665
• Always listen for Network Connection for Offline Indictor #11672
• Fix - disabled cursor on pending-deletion workspace #11699
• Fix for: After Creating group, email address of only one user is used in alternate Text  #11765
• Fix: Payment methods have wrong height #11838
• Decode on copied text from Clipboard #11905
• [No QA] Remove pip install for wheel #11939
• [No QA] Upgrade Fastlane #11942
• [No QA] Upgrade markPullRequestsAsDeployed to node16 #11943
• Upgrade react-navigation/drawer to use our fork #11944
• [No QA] Upgrade Onyx to 1.0.24 #11945
• Fix growl error on paste text #11956
• [No QA] Group test and QA steps together #11958
• Show Default Rooms when there is a team.expensify.com account on the report #12013
• [CP Staging] Fix hasExpensifyGuidesEmails call #12038
• [No QA] Update to macos-12 and XCode 14 in GitHub Actions #12068
• [No QA] Upgrade actions/checkout, actions/setup-node, ruby/setup-ruby to latest #12072
• [No QA] Specify developer team to sign generated projects #12084
• [No QA] Disable signing for generated projects #12092
• Onyx package revert #12099

Deploy Blockers:

• Web- Workspace - When tapping "back", user is taken to VBA flow again #10585
• Web - LHN - Conversation that doesn't have a message doesn't disappear from LHN #11633
• [$250] Android - Chat - Blank page is displayed when navigate to any chats #11983
• IOS/Android - IOU - Error page is displayed after tap the iOU badge #11995
• Web-Workspace -After renamed the workspace, you need to refresh the page to see the new name #12000
• IOS - New Chat - Chat - Nothing happens when tapping on user from the searching list. #12009
• Workspace - Reimburse expenses- Rate equals 0 is displayed after offline changes on Reimbursement page #12012
• Web - OldDot transition - App crashed when creating policy in OldDot #12035
• Web - App crashes when login  #12037
• [HOLD App#11910] Chat - Two admis and two announce rooms have been created after click Create a Free Policy in OldDot #12061
• BUG: All contacts disappear from LHN on adding a user to workspace reported by @thesahindia #12067

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[sketchydroide]

#10585 checked, to old to be blocker over a month and a half, weird.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.18-1 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-2 has been deployed to staging 🎉

[mvtglobally]

Team is still working on the regression.

Summary so far
Blockers
#11983
#11995
#12000

PRs
PR #11640 is blocked on IOS and Android due to #11796
PR #11699 is failing due to #12000
PR #11956 is failing #11867. Checking off

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-3 has been deployed to staging 🎉

[mvtglobally]

@sketchydroide
Regression is completed

Blockers
#11633
#11983
#11995
#12000
#12009
#12012

PRs
PR #11640 is blocked on IOS and Android due to #11796
PR #11699 is failing due to #12000

We are checking new CP #12013

[sketchydroide]

checking #11633, it's already in prod so not a blocker.

[sketchydroide]

checking #11983, hard to reproduce, maybe connection issue. not a blocker

[sketchydroide]

checking #12000, was reproduced in Prod by @ctkochan22.
@mvtglobally how is this blocking #11699? Let me know if that is still a problem

[sketchydroide]

@thienlnam removed the blocker for #12012 so checking that one as well

[mvtglobally]

@sketchydroide
#11699 Is not blocked. I just mentioned the blocker issue we found while executing that PR. Team wasn't able to repro in PROD. But if you can repro. I will check it off.

[mvtglobally]

Also, The NEW CP #12035 seem to break #12035

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-4 🚀

[sketchydroide]

Also, The NEW CP #12035 seem to break #12035

Did you get those right @mvtglobally, they are both the same, and seems to be about a Web change

[mvtglobally]

My bad, not enough ☕ ☕ ☕ I meant to say CP #12013 broke #12035
This issue wasnt repro in earlier build

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-4 has been deployed to staging 🎉

[mountiny]

Checking #12035 and #12037 off as @trjExpensify confirmed that the fixed worked.

[PauloGasparSv]

Should #11796 be tagged as deployBlocker and added to the deployBlockerList since we mentioned it is blocking this #11640?

I'm just confused because #11640 says to connect with "Chase" via Plaid and not "Fidelity".

cc @mvtglobally

[mvtglobally]

@PauloGasparSv the PR was created a long time ago when we used Chase to test. Now Chase is blocked for a while, so we use Fidelity.
I am not sure this should be a Deploy blocker, since it was there for few releases already.. The main issues is, that we can't verify PR #11640 on IOS/and Android due to this #11796

[sketchydroide]

#11995 was closed, we can't replicate it anymore, maybe it was a backend issue.

[sketchydroide]

#12009 was also closed, we can't replicate it anymore. checking it off

[sketchydroide]

@mvtglobally
What is missing from the last 3 items that need checking in the list?

[mvtglobally]

@sketchydroide

We cant validate #11640 on Android and IOS due to this #11796. Are we ok to check it off?

PR #12013 was failing. Re-testing right now

[sketchydroide]

We cant validate #11640 on Android and IOS due to this #11796. Are we ok to check it off?

yeah lets

[roryabraham]

@Expensify/applauseleads we decided to CP #11944 because it fixes some critical bugs and we wanted to get it out over the weekend. Let's make sure we complete QA for that before proceeding to deploy production

[mvtglobally]

We are on it

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-5 has been deployed to staging 🎉

[mvtglobally]

@roryabraham @sketchydroide Seeing few issues with new PR. Team is checking if any blockers and logging in a bit

[mountiny]

@roryabraham @sketchydroide I think iOS build failed there so the fix is not in testflight for iOS yet (I cannot test on android unfortunately)

[roryabraham]

Retrying the iOS deploy now

[mvtglobally]

@sketchydroide @roryabraham
While we are waiting for IOS

#12013 is only failing with #12061. Since thats not a blocker, I guess we can check it off.

PR. #11944 is failing with #11867. Its an older KI.

@mountiny Android Build is updated

[mountiny]

#12013 is only failing with #12061. Since thats not a blocker, I guess we can check it off.

Correct

PR. #11944 is failing with #11867. Its an older KI.

@mvtglobally this is also ok, the issue mentioned should not be solved by this change. We thought it might and but it has a different root cause, updated the PR body there.

[mvtglobally]

Still no IOS build

[roryabraham]

Working on it, just put up #12068 to try and fix it

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-6 🚀

[roryabraham]

Still working on iOS deploys, another PR here

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-6 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-7 🚀

[roryabraham]

Yet another deploy running here, hopefully this one works 🤞🏼

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-7 has been deployed to staging 🎉

[mvtglobally]

Unfortunately, still no IOS

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-9 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-9 has been deployed to staging 🎉

[mvtglobally]

@roryabraham @chiragsalian
We got a new Build

PR #11944 is pass on IOS. #11867 & #10290 Not blockers, so checking off.

Asked team to double check this #12067. Only 1 out of 5 testers was able to repro originally.

[chiragsalian]

okay thank you

[mvtglobally]

@chiragsalian
We are only able to repro on Realme 6 / Android 11 #12067

Record_2022-10-24-21-37-54_4f9154176b47c00da84e32064abf1c48.mp4

[chiragsalian]

Strange, yeah i was just able to reproduce the issue using sahil's credentials posted here. And i can reproduce only on staging and not on production. Investigating.

[chiragsalian]

We think we found the fix (or rather revert) to address the deploy blocker. We're waiting for it to hit staging and deploy to devices before re-testing.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.18-10 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.18-10 has been deployed to staging 🎉

[chiragsalian]