-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD #12259][Image] Android app & mWeb/Safari - Profile - The default avatar changes after removing the avatar image #12007
Comments
Triggered auto assignment to @youssef-lr ( |
I was able to reproduce this. Investigating. |
@youssef-lr accidentally unassigned you while assigning me. Also put on hold pending @Beamanator 's work on If you have a solution in the works, drop in a comment to see if Beaman is 👍 to implement |
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Oh hold |
Issue not reproducible during KI retests. (First week) |
ooooh, not reproducible!!? I like that . Either way... it's on hold |
@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
On hold |
Okay, great. Thanks for confirming. I've added these two recordings to the OP and updated it. |
@Beamanator to confirm, this is still an issue that should be on hold right? |
Huh good question, if I remember correctly, this "default avatar" business is going to be fixed by @roryabraham... Rory weren't you looking into implementing a default avatar SVG that's a file, not a URL? And I thinkkkk that was going to be in another issue? |
Friendly bump on the question above, @roryabraham? |
It's not this issue is it? #12658 |
Okay, so mystery solved here then @Beamanator, it's #9703 that @cristipaval is going to be working on? |
Yes indeedy! Thanks for updating - we can hold this on that one, hopefully it'll resolve itself 🙏 |
@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
After revisiting this issue, it seems a bit superfluous to me:
This issue has been created specific to the |
#9703 has been encapsulated into #12259, so the hold in the title needs an update. Regardless, I still question the purpose of keeping this issue open @Beamanator. |
Good call @trjExpensify - I think this should just be added as a testing step in @grgia 's PR to implement hard-coded default avatars, yeah? |
Yeah, exactly.. we're basically jus QA'ing that the hard-coded default avatars are there after you remove a custom one, which should be accounted for in the testing steps of the PR that introduces them. |
So I think we can just close this one, do we need to add a comment to #12259, explaining what we just discussed? |
Yep, donezo! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The default avatar shouldn't change
Actual Result:
The default avatar changes
Workaround:
Uknown
Platform:
Where is this issue occurring?
Version Number: 1.2.18.2
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5783895_Record_2022-10-19-20-40-43.mp4
Android app
Record_2022-11-15-16-42-14_4f9154176b47c00da84e32064abf1c48.2.mp4
mWeb/safari
video_2022-11-15_16-46-35.2.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: