[HOLD #12259][Image] Android app & mWeb/Safari - Profile - The default avatar changes after removing the avatar image

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings->Profile
4. Remove the avatar image

Expected Result:

The default avatar shouldn't change

Actual Result:

The default avatar changes

Workaround:

Uknown

Platform:

Where is this issue occurring?

• Android app
• Mobile Web Safari (iOS)

Version Number: 1.2.18.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5783895_Record_2022-10-19-20-40-43.mp4

Android app

Record_2022-11-15-16-42-14_4f9154176b47c00da84e32064abf1c48.2.mp4

mWeb/safari

video_2022-11-15_16-46-35.2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @youssef-lr (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[youssef-lr]

I was able to reproduce this. Investigating.

[mallenexpensify]

@youssef-lr accidentally unassigned you while assigning me. Also put on hold pending @Beamanator 's work on

• [Tracking][Image][Polish] Image-related feature request and improvements #10894

If you have a solution in the works, drop in a comment to see if Beaman is 👍 to implement

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Oh hold

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mallenexpensify]

ooooh, not reproducible!!? I like that . Either way... it's on hold

[melvin-bot]

@mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

On hold

[trjExpensify]

Okay, great. Thanks for confirming. I've added these two recordings to the OP and updated it.

[trjExpensify]

@Beamanator to confirm, this is still an issue that should be on hold right?

[Beamanator]

Huh good question, if I remember correctly, this "default avatar" business is going to be fixed by @roryabraham... Rory weren't you looking into implementing a default avatar SVG that's a file, not a URL? And I thinkkkk that was going to be in another issue?

[trjExpensify]

Friendly bump on the question above, @roryabraham?

[trjExpensify]

if I remember correctly, this "default avatar" business is going to be fixed by @roryabraham... Rory weren't you looking into implementing a default avatar SVG that's a file, not a URL?

It's not this issue is it? #12658

[trjExpensify]

Okay, so mystery solved here then @Beamanator, it's #9703 that @cristipaval is going to be working on?

[Beamanator]

Yes indeedy! Thanks for updating - we can hold this on that one, hopefully it'll resolve itself 🙏

[melvin-bot]

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

After revisiting this issue, it seems a bit superfluous to me:

• we have an image caching issue for mobile
• we have an image caching issue for web/desktop
• we have an issue to bundle default avatars as SVG for a fall back when avatar images aren't loaded/cached

This issue has been created specific to the profile page on Android and mWeb/Safari, but I'm struggling to understand why during the implementation of the initiatives above this case won't be tested in the relevant PRs to ensure the solution works as intended.

[trjExpensify]

#9703 has been encapsulated into #12259, so the hold in the title needs an update. Regardless, I still question the purpose of keeping this issue open @Beamanator.

[Beamanator]

Good call @trjExpensify - I think this should just be added as a testing step in @grgia 's PR to implement hard-coded default avatars, yeah?

[trjExpensify]

Yeah, exactly.. we're basically jus QA'ing that the hard-coded default avatars are there after you remove a custom one, which should be accounted for in the testing steps of the PR that introduces them.

[Beamanator]

So I think we can just close this one, do we need to add a comment to #12259, explaining what we just discussed?

[trjExpensify]

Yep, donezo!