Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking][Image][Polish] Image-related feature request and improvements #10894

Closed
36 of 39 tasks
roryabraham opened this issue Sep 8, 2022 · 145 comments
Closed
36 of 39 tasks
Assignees
Labels
Engineering Planning Changes still in the thought process Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Sep 8, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

We have seen a number of issues come up related to images. Uploading them, editing them, making them available offline, copying them to clipboard, etc...

Onyx does have support for images, but AFAIK nobody has utilized that functionality to build any app features that follow our offline-first paradigm for images.

Overall, I think there's a lot of confusion around this topic (speaking for myself here, so feel free to comment if you disagree), and that leads to potentially disparate approaches or complex code surrounding images.

Solution

As these come up, we see the need for a common, unified approach to handling images, presumably using Onyx. This issue is meant to serve as a tracking issue for all image-related feature requests and bug fixes. We should look for commonality between these features, try to come up with a generalized, future-proof solution that's easy to work with, and implement it via the WN/Design Doc process.

Linked issues

Setting up Caching Issue(s)

Bugs based off caching [Holding on ^]

"Flashing" / Image rerendering [Holding on ^]

New Features

Bugs (in progress - not on hold)

Resolved issues

Follow-up discussions:

@parasharrajat
Copy link
Member

Thanks for putting this up, much needed discussion.

@melvin-bot

This comment was marked as off-topic.

@parasharrajat
Copy link
Member

Should we create a Project for this one? For me, it's a big feature/migration.

@roryabraham
Copy link
Contributor Author

roryabraham commented Sep 21, 2022

A project would be fine – historically we've usually just used issues but a project board could be useful. More importantly, we need someone to take this on as a project manager.

One interesting idea could be to engage @thomas-coldwell from Margelo in this project, since @mrousavy told me that Thomas typically works on Video/Audio/Image/Graphics stuff. Thoughts @mrousavy? Right now this is a pretty open-ended issue.

@mrousavy
Copy link
Contributor

@roryabraham yes, this would probably pretty interesting! 😄

I'll talk to Thomas about availability then get back to you here or on Slack :)

@JmillsExpensify JmillsExpensify changed the title [Tracking] Image-related feature request and improvements [Tracking] [Bug] Image-related feature request and improvements Sep 27, 2022
@melvin-bot

This comment was marked as off-topic.

@melvin-bot melvin-bot bot added the Overdue label Sep 29, 2022
@melvin-bot

This comment was marked as off-topic.

@roryabraham
Copy link
Contributor Author

Added #9703 to this list.

@roryabraham
Copy link
Contributor Author

roryabraham commented Oct 3, 2022

There was some useful discussion in slack regarding this issue here

@JmillsExpensify JmillsExpensify changed the title [Tracking] [Bug] Image-related feature request and improvements [Tracking] [Polish] Image-related feature request and improvements Oct 4, 2022
@melvin-bot

This comment was marked as off-topic.

@Beamanator
Copy link
Contributor

Beamanator commented Oct 6, 2022

A few updates for today:

@melvin-bot

This comment was marked as off-topic.

@Beamanator Beamanator added the Planning Changes still in the thought process label Oct 6, 2022
@melvin-bot melvin-bot bot removed the Overdue label Jan 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Jan 29, 2024
@trjExpensify
Copy link
Contributor

#34505 is in review still!

@melvin-bot melvin-bot bot removed the Overdue label Jan 29, 2024
@trjExpensify trjExpensify changed the title [HOLD #277714] [Tracking][Image][Polish] Image-related feature request and improvements [HOLD #12603] [Tracking][Image][Polish] Image-related feature request and improvements Feb 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 7, 2024
@trjExpensify
Copy link
Contributor

The image caching PR was reverted again, so we're back to figuring that out in #12603.

@melvin-bot melvin-bot bot removed the Overdue label Feb 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 16, 2024
@trjExpensify
Copy link
Contributor

New PR for #12603 is up.

@melvin-bot melvin-bot bot removed the Overdue label Feb 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2024
@trjExpensify
Copy link
Contributor

Plan being worked on!

@melvin-bot melvin-bot bot removed the Overdue label Mar 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@trjExpensify
Copy link
Contributor

#36560 in the works!

@melvin-bot melvin-bot bot removed the Overdue label Mar 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 19, 2024
@trjExpensify
Copy link
Contributor

trjExpensify commented Mar 20, 2024

We merged it very recently. Looking good so far, no revert. So hopefully we can turn to #9402 soon.

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2024
@mallenexpensify mallenexpensify changed the title [HOLD #12603] [Tracking][Image][Polish] Image-related feature request and improvements [Tracking][Image][Polish] Image-related feature request and improvements Mar 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 28, 2024
@mallenexpensify
Copy link
Contributor

Updated title to remove the hold cuz the issue it was held on hit production
#12603
(I have another issue that's held on this one)

@trjExpensify
Copy link
Contributor

What issue is it, @mallenexpensify?

@melvin-bot melvin-bot bot removed the Overdue label Apr 2, 2024
@mallenexpensify
Copy link
Contributor

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2024
@trjExpensify
Copy link
Contributor

Interesting! I don't think that needs to hold on this issue, it looks like it's being addressed here: #35502

I'm going to go ahead and close this out now. We aren't adding anything new to it or require it for CAP or anything. The two remaining items we have are here and here, so follow along there if anyone is still interested!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Planning Changes still in the thought process Weekly KSv2
Projects
None yet
Development

No branches or pull requests