[HOLD #12603] [Image] Seeing blank modal for avatar, when offline reported by @thesahindia

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed (1):

1. Disconnect the internet connection
2. Navigate to a chat
3. Click on chat header
4. Click on avatar

Expected Result:

You should see loading indicator

Actual Result:

There's no loading indicator

Action Performed (2):

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go offline
4. Upload a new Avatar to your profile
5. Go online
6. Open any chat and open your own details.
7. Tap on the avatar

Expected Result:

The photo loads after uploading a new avatar and clicking on details

Actual Result:

The photo does not load after uploading a new avatar and clicking on details

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App
• Mobile Web

Version Number: 1.2.27-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-11-14.at.1.28.38.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668369779537849

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Beamanator]

Placing on hold & adding to tracker: #10894

Ideally this will get fixed once image caching works, but we'll keep this open to investigate

[trjExpensify]

Makes sense. I'll switch Conor out for myself as the BZ.

[trjExpensify]

Caching on native is done, still held on Web/Desktop (#12603) before we can retest this one.

[trjExpensify]

Still on hold.

[trjExpensify]

Still on hold. Looking to explore the route of getting the web/desktop caching PR unblocked by fixing it in our RNW fork while we wait on the upstream.

[trjExpensify]

No change since the last update.

[Beamanator]

Note: Possible fix for me later:

1. Remove isAuthTokenRequired from DetailsPage -> AttachmentModal
2. In AttachmentView, render ImageView also if props.sourceURL starts with blob:

[Beamanator]

Note: Added another set of reproduction steps to the OP (from here: #14130) so we can close out the other issue

[trjExpensify]

Samesies!

[trjExpensify]

Same Melv!

[trjExpensify]

Same Melv!

[trjExpensify]

Still held on web caching, Melv.

[trjExpensify]

Still held on web image caching, but we're making progress there with the CORS issue dependency blocking that.

[trjExpensify]

Still held, but the web image caching PR is in review.

[trjExpensify]

Image caching PR was deployed and reverted. Awaiting this now before re-implementing: #32703

[trjExpensify]

Damn, we so unlucky Melv! The image caching PR got reverted again, so this is still held.

[trjExpensify]

No change.

[trjExpensify]

All good here. Closing!

DOqyu3mfK6.mp4

[trjExpensify]

Payment summary:

• $250 to @thesahindia for reporting the bug. Eligible as prior to the program change in Aug 2023. 👍

[JmillsExpensify]

$250 approved for @thesahindia