Remove all growls on NewDot

[conorpendergrast]

On hold for WAQ focus

As identified in this issue and discussed in this thread, we have some remaining growls that are now out of style. This is not a bug, but still needs to be fixed. @luacmartins found the following that still have growls:

1. Interacting with the checkbox in Workspace > Manage member page
2. Adding/Deleting PaypalMe address
3. Failure updating the User avatar
4. Failure to create, update or delete a Workspace
5. Error downloading a wallet statement

And we should remove them all.

[trjExpensify]

Opening external links when offline

I believe these growls were intentionally left during the Offline API refactors project. The notion being to :do-nothing: as the redirects will go away as we bring those features into NewDot as we progress with reunification. CC: @robertjchen

[conorpendergrast]

Ok, removed from the list!

[kadiealexander]

Assigning this to myself, as part of my mentorship this year is to be working towards fixing E/app issues. If this becomes an urgent priority please let me know.

[JmillsExpensify]

Nice, I'm glad we have a project for this. For what it's worth, I would also remove this one from the list. It's ridiculously far out and something we fix post-reunification.

Error downloading a wallet statement

[kadiealexander]

Not overdue, have been OOO from a family emergency. Going to dig into this over the next week.

[JmillsExpensify]

Nice, this is a pretty good polish project that's worth picking up now. Happy to help with any questions.

[kadiealexander]

Thanks Jason! I have a draft PR up with the first growl removed, going to plug away at the rest this week! Should I still hold off on "Error downloading a wallet statement"?

[JmillsExpensify]

Oh cool! That's awesome, I don't personally think removing that is an issue since the wallet statement is still a beta, though @joekaufmanexpensify can jump in and confirm one way or another.

[joekaufmanexpensify]

Just for my own understanding, would we be replacing the growl with a different style of error message? Or just removing the growl and leave it failing silently for now?

I think either way is fine for now (since no one is really using the statement right now). Although if we aren't adding a new error now, I'll add this to the existing statements cleanup issue we have (which is on hold right now).

[yuwenmemon]

Removing the HOLD from this!

[JmillsExpensify]

@joekaufmanexpensify Yeah we'd replace the growl with a different message style.

[joekaufmanexpensify]

Sounds good! Yeah if we're replacing the growl with a different error message style, that sounds great.

[joekaufmanexpensify]

Just for my own understanding, have we decided what will be added in their place?

[luacmartins]

IMO we should use the existing DotIndicatorMessage and Form error pattern when possible:

For example, here's a case where the modal was replaced with the DotIndicatorMessage component:

And here's how we show it in Form:

[JmillsExpensify]

Agree with @luacmartins

[joekaufmanexpensify]

Makes sense, ty!

[kadiealexander]

Is adding in the new indicator messages something I should do as a part of this issue, or will it be covered later? Just clarifying because the scope of the OP was very limited to removing growls.

[JmillsExpensify]

Sorry what's the new indicator messages?

[luacmartins]

I think @kadiealexander is talking about the new error messages we'd put in place instead of the growl?

[JmillsExpensify]

Gotcha, hmm yeah I think we need the error messages to appear somewhere, if we are deprecating the growls where they appear today, right? Apologies if I'm missing something obvious.

[luacmartins]

Yea, I agree

[kadiealexander]

Okay! The OP is very limited to removing the current growls, thanks for the added context. I'm going to pause on actioning this while I figure out the new messaging for these. A few aren't errors, so I'm not sure if any sort of "success" message should be put in place instead.

Not an error, need to determine what message to show (if any):

• Interacting with the checkbox in Workspace > Manage member page
• Adding/Deleting PaypalMe address (not an error)

Growl errors to be replaced with DotIndicatorMessage:

• Failure updating the User avatar
• Failure to create, update or delete a Workspace
• Error downloading a wallet statement

[conorpendergrast]

Looks like this is ongoing still @kadiealexander, is that right? No rush at all on my end

[JmillsExpensify]

Agree that there is no rush, though is would still be good to do this in the intermediate term. I think we don't have many growls as it is.

[melvin-bot]

@conorpendergrast, @kadiealexander, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[kadiealexander]

I've discussed this with my mentor @puneetlath and we agreed that the addition of different indicators blew this out of my realm of expertise. I'm unassigning so that this is not blocked on me.

[conorpendergrast]

@puneetlath @kadiealexander This still needs to be internal, correct?

[kadiealexander]

Wrong Puneet! From everything I saw this could be external, but I could be wrong.

[conorpendergrast]

Oh that's embarrassing, silly me

[puneetlath]

Agreed, seems like it can definitely be external. If it's a little more involved, it could be a good one for an expert agency.

[conorpendergrast]

@puneetlath Do you think you could update this with everything it needs to be external?

[melvin-bot]

@conorpendergrast, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.