[$1000] Growl shows up on adding/deleting paypal account

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings > Payments
2. Click add payment method > PayPal.me
3. Enter a user name
4. Press save

Expected Result:

The growl shouldn't show up

Actual Result:

The growl is still available

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.34-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-11-30.at.5.11.41.AM.mov

Recording.1028.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669765941027919

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128a643266df63294
• Upwork Job ID: 1598092514284437504

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Puneet-here]

Proposal

Remove the lines below

App/src/pages/settings/Payments/AddPayPalMePage.js

Line 43 in 435c4b9

Growl.show(this.props.translate('addPayPalMePage.growlMessageOnSave'), CONST.GROWL.SUCCESS, 3000);

App/src/libs/actions/User.js

Line 299 in 435c4b9

Growl.show(Localize.translateLocal('paymentsPage.deletePayPalSuccess'), CONST.GROWL.SUCCESS, 3000);

We also need to remove the message copy from en and es.js and we can also remove the copies of previous growls that we have removed

App/src/languages/en.js

Line 407 in 435c4b9

growlMessageOnSave: 'Your PayPal username was successfully added',

[conorpendergrast]

Checking if this is a bug in Slack, and then will triage accordingly.

[conorpendergrast]

This is not a bug, but should still be done 👍

[melvin-bot]

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128a643266df63294

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Triggered auto assignment to @joelbettner (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[conorpendergrast]

From this SO: https://stackoverflow.com/c/expensify/questions/14418

• The "bug" is actually a bug: It's... not actually a bug. We should still do it!
• [] The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead): Nope
• The bug is reproducible, following the reproduction steps: Yep!
• If you’re unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.: N/A
• The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?): yep, looks good
• The GH was created by an Expensify employee or a QA tester: Yep!
• If there's a link to Slack, check the discussion to see if we decided not to fix it: Yep!
• Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label: Done, external!

[conorpendergrast]

Over to @aimane-chnaif to review the proposal

[conorpendergrast]

Actually, rather than doing this piecemeal, we're going to remove them all via this internal issue. Closing for now!