[HOLD for regression test steps] Checkbox is unchecked when selected

[Julesssss]

Problem

The following bug was reported today:

Steps:

• Open any page that has checkbox (Manage member, Profile Page...)
• Try to tab on check box
• Notice that checkbox get checked and unchecked at the same time

Reported by: @hungvu193

Solution

Revert this PR

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c0577e0c4012d00b
• Upwork Job ID: 1606451156754501632
• Last Price Increase: 2022-12-24

[Julesssss]

PR: #13271

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[hungvu193]

@Julesssss May I have the reporting bonus for this one?

[Julesssss]

This will be resolved with this PR, BUT the issue wasn't actually deployed to staging so it should not have been a blocker. My bad!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert PR 13187 to resolve checkbox bug #13271

If no regressions arise, payment will be issued on 2022-12-15. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Julesssss Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c0577e0c4012d00b

[melvin-bot]

Current assignee @sobitneupane is eligible for the Internal assigner, not assigning anyone new.

[mallenexpensify]

@sobitneupane can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01c0577e0c4012d00b

[sobitneupane]

@mallenexpensify I didn't review the PR. So, No payment.

[hungvu193]

I'm the reporter can you invite me? @mallenexpensify

[mallenexpensify]

Thanks @sobitneupane , I think I saw your name in the upper right corner of the PR but now realizing there's not a ✔️ next to it for the review.

Thanks @hungvu193 , doubled check the OP and still somehow missed. I've hired you, can you please accept the job and reply here once you have?

[hungvu193]

@mallenexpensify I've accepted the offer

[mallenexpensify]

@hungvu193 paid for reporting, thanks.
@Julesssss , I think this needs a regression test steps update, right? I'm not seeing the auto-checklist GH post, I can copy/paste and complete if we think we need (should be quick)

[melvin-bot]

This issue has not been updated in over 15 days. @Julesssss, @mallenexpensify, @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mallenexpensify]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/257451

[mallenexpensify]

Coming from the PR

Tests

1. Sign in to any account
2. Open any page that has checkbox (Manage member, Profile Page...)
3. Try to tap on the check box
4. The checkbox should be checked and unchecked without any obvious bugs

Add here in TestRail
Workspace Settings - Manage Members - Invite
Add a new step 11 and 12 -
11. Uncheck then re-add the check in the checkbox
12. Verify the check is removed then re-added without any bugs.

Posted https://expensify.slack.com/archives/C01SKUP7QR0/p1674175379411399

[mallenexpensify]

@Julesssss can you check off the top three boxes here #13269 (comment)
We can close this once that's done, I created the TestRail issue here https://github.com/Expensify/Expensify/issues/257451

[Julesssss]

Checked off and added the links. Discussion took place outside of slack in this case.