Deploy Checklist: New Expensify 2022-12-02

[OSBotify]

Release Version: 1.2.36-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add a switch on dev and staging to force offline mode #12135
• New timezone pages #12201
• Display banner to enable 2FA when setting up VBBA #12424
• Allow multiple avatar image types #12549
• Update concierge icon for help site #12564
• Sort reportActions by created instead of sequenceNumber #12626
• Add New Fonts #12656
• Remove use of getPaymentMethods() in EnableStep #12909
• reset the state for the delay context action if it is not the delete action #12917
• Message html to text and last message (LHN) fixes #12968
• [No QA] Remove unused code in deprecated API #13053
• Hide send/request options for default chats / user created rooms #13113
• feat: fix for 11317 #13126
• Fix wrong Provisioning Profile and add directories to desktop upload #13129
• Do not style word 'split' for IOU splits #13130
• Update site preview image #13171
• Fixed: You can't search a room with names like "x.y" #13186
• Keep input cursor in place when toggling password checkbox  #13187
• Fix Desktop local builds on Apple Silicon MacBooks #13199
• Fix issue with tooltip after long-pressing on username #13204
• Use dark theme for ios DatePicker #13210
• Don't show my own name as prefix at room #13212
• Fix/13086: Light background colour is shown when navigating between right docked modal pages #13242
• Attachment button size change #13243
• Fix console error on right click comment to open context menu #13248
• [No QA]Rename file to action.yml to enable testing #13254
• Revert PR 13187 to resolve checkbox bug #13271
• Update Onfido to latest to resolve deploy issues #13284
• [CP Staging] Changed border style #13298
• Revert "Display banner to enable 2FA when setting up VBBA" #13407
• Refactor the function for filtering the currency list #13412

Deploy Blockers:

• Run e2e performance regression tests on merge into main via AWS Device farm #12320
• [HOLD for payment 2022-12-20] [HOLD for payment 2022-12-15] Request money - The list of currency is empty until you enter any letter in search field #13286
• Step 4 of VBA flow has border radius issue.  #13287
• Chat - Emojis are switching from big size to small #13292
• Desktop - new messages are not displayed in chats #13327

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.36-0 🚀

[mvtglobally]

PR #12564 , #13171 PROD QA

[luacmartins]

For the next deployer #13271 (comment)

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.36-1 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.36-1 has been deployed to staging 🎉

[mvtglobally]

@luacmartins @flodnv Regression is completed

PR #12201 is failing #13313. Not a bug checking off
PR #12564 , #13171 PROD QA
PR #12626 is failing #13310 (repro in PROD) & #13314 (We are unable to validate PROD) can you pls double check this is new expected or a blocker
PR #12909 is blocked by #12123. and we also have no way to run it on Native aps as logins direct to PROD
PR #13187 is failing #12018 repro in PROD
PR #13204 is failing #13307
PR #13284 is internal, are we ok to check off?

[francoisl]

PR #13284 is internal, are we ok to check off?

Yes, I'm checking this one

PR #12909 is blocked by #12123.

Nathalie left you a question in #12123 (comment) to help with testing that issue, can you please take a look there?

PR #12564 , #13171 PROD QA

Yes correct, I'm checking those off. We set reminders to test them ourselves in prod.

Thanks! We're still looking into the other deploy blockers.

[roryabraham]

Do we have an issue for the borked fonts on web?

[roryabraham]

Fix for the fonts issue here

[PauloGasparSv]

PR #12909 is blocked by #12123.

@mvtglobally can you send a screenshot or video of this blocker? I want to know what is blocking you in specific, that Chase connection issue has been really hard to understand and replicate.

Also, the QA steps for the blocked P.R. mentions to connect with Wells Fargo or Bank of America but the blocker issue was about Chase in specific, is the VBA not working at all with any of the banks?

and we also have no way to run it on Native aps as logins direct to PROD

Do we have an issue for that?

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.36-2 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.36-2 has been deployed to staging 🎉

[mvtglobally]

@PauloGasparSv this is KI #11796 We are blocked to add VBA on Fidelity, we are also not able to use Chase, BoA or Wells Fargo. Can you please try to add a bank account on Native app IOS or Android (Actual device) and tell us the steps to do it. Maybe we are missing smth.

[marcaaron]

Checking off #13292
Seems that we were waiting for some code to hit the API and the issue is now resolved.

[francoisl]

Quick update:

The following still need to be tested:

• [CP Staging] Changed border style #13298. (This should fix the blocker Step 4 of VBA flow has border radius issue.  #13287)
• Display banner to enable 2FA when setting up VBBA #12424 - the issue you encountered while testing might have been due to site issues we were having earlier today - can you try again please?

---

• Sort reportActions by created instead of sequenceNumber #12626

Looks like we're leaning towards checking this off based on previous internal conversations, but I'd like to confirm with @roryabraham first (we can discuss in this Slack thread if needed)

---

• Remove use of getPaymentMethods() in EnableStep #12909

I was able to reproduce the same issue #12123 that was stopping you from running QA on staging mWeb, on an Android device. I'll try to reproduce on dev as well to see if I can get to the bottom of this.

cc @kavimuru

[mvtglobally]

Checking off #13298

[francoisl]

Great, thanks. Did you also get a chance to retest #12424?

[francoisl]

@mvtglobally we updated the QA steps for #12909 to simplify them - connecting the bank account is out
of scope for this PR. We prepared an account that already has a bank account connected, details are in #12909 (comment)

[mvtglobally]

Checking @francoisl

[mvtglobally]

@francoisl for #12424 we are facing issue with 2FA on IOS. It is working on PROD app, but not staging for some reason. Anything we are missing?

12424_iOS.mp4

[francoisl]

So the issue is that the "Secure your account" button is not doing anything on iOS Safari, is that correct? I'll try now.

Also at the end of the video, you're trying to open www.staging.expensify.com, which is not valid - it should be staging.expensify.com (without www.).

[francoisl]

@mvtglobally I can reproduce the same issue with mWeb iOS, can you open a deploy blocker please?

[francoisl]

Ok nvm - it's a setting in iOS and not a blocker 🥵 You have to:

1. Open the iOS settings app
2. Scroll down, select Safari
3. Uncheck "Block Pop-ups"

[francoisl]

Ok we're getting close, let's try to push this to the finish line 💪. Here's the recap:

• Display banner to enable 2FA when setting up VBBA #12424
  We realized the OldDot wasn't opening on iOS mWeb because Safari blocks pop-ups by default. Unblock them from the settings app and it should be good to go

• Remove use of getPaymentMethods() in EnableStep #12909
  You can sign in the test account ctkochan22+openvbba@gmail.com/Password1, which is pre-configured with a VBBA. The QA steps in the PR were also clarified.

• Sort reportActions by created instead of sequenceNumber #12626
  #13310 was put on hold and is reproducible in production, and #13314 seems like an edge case for a rare flow, so let's keep both issues open and work on them without blocking this deploy ✔️

• [HOLD for payment 2022-12-20] [HOLD for payment 2022-12-15] Request money - The list of currency is empty until you enter any letter in search field #13286 is the last blocker, I left a comment in the fix PR to get a sense of whether it will be merged today

[mvtglobally]

@francoisl Checking off #12909 its pass.

Regarding #12424 Can you pls help us out internally on mWeb and Native IOS/Android? Few testers got stuck with this PR and I am having hard time completing it now.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.36-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.36-3 has been deployed to staging 🎉

[francoisl]

• We reverted Display banner to enable 2FA when setting up VBBA #12424 so I'm checking it off. We'll need to QA Revert "Display banner to enable 2FA when setting up VBBA" #13407 to make sure there's no regression with the revert.

• There's going to be one last CP coming for the last deploy blocker. It will have its own test steps.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.36-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.36-4 has been deployed to staging 🎉

[mvtglobally]

Checking off #13407

[mvtglobally]

@francoisl Checking off #13412

[francoisl]

Nice! We're all set here.

[francoisl]