Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 4 of VBA flow has border radius issue. #13287

Closed
Luke9389 opened this issue Dec 2, 2022 · 7 comments
Closed

Step 4 of VBA flow has border radius issue. #13287

Luke9389 opened this issue Dec 2, 2022 · 7 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@Luke9389
Copy link
Contributor

Luke9389 commented Dec 2, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Break down in numbered steps

Go through the VBA flow until you hit step 4 and verify that you see this:
Screen Shot 2022-12-02 at 12 11 12 PM

Expected Result:

Describe what you think should've happened

Looks reasonable ha

Actual Result:

Describe what actually happened

Looks like screenshot above.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@Luke9389 Luke9389 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 2, 2022
@Luke9389 Luke9389 self-assigned this Dec 2, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 2, 2022

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Pujan92
Copy link
Contributor

Pujan92 commented Dec 2, 2022

Proposal

If the border isn't required we can take that class out from the view

<View key={index} style={[styles.p5, styles.border, styles.mb2]}>

<View key={index} style={[styles.p5, styles.mb2]}>

Or if the border is required we can apply
borderRadius: variables.componentBorderRadius

borderRadius: variables.buttonBorderRadius,

@Luke9389 Luke9389 added the Internal Requires API changes or must be handled by Expensify staff label Dec 2, 2022
@Luke9389
Copy link
Contributor Author

Luke9389 commented Dec 2, 2022

Hey y'all I've already spun up a fix for this. Sorry, I should have marked this internal.

@Luke9389 Luke9389 added the DeployBlockerCash This issue or pull request should block deployment label Dec 2, 2022
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 2, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Dec 2, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Dec 2, 2022

Current assignee @Luke9389 is eligible for the Engineering assigner, not assigning anyone new.

@Christinadobrzyn Christinadobrzyn removed the Internal Requires API changes or must be handled by Expensify staff label Dec 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@Christinadobrzyn Christinadobrzyn added Internal Requires API changes or must be handled by Expensify staff and removed Overdue labels Dec 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@Christinadobrzyn
Copy link
Contributor

Shouldn't there be a C+ assigned with this internal label? Removed and added it and nothing changed.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@francoisl
Copy link
Contributor

Applause finished QAing #13298, closing this blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants