[PAY] Image infinite loading when offline

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Turn on the Airplane mode, open the app
2. Open any report that has image, click on image.
3. Notice that the image is infinite loading.

Expected Result:

Image should show error or placeholder error.

Actual Result:

The image is infinite loading.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• iOS / native

Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1671850663.MP4

CYVJ9736.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671962332211369

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[mallenexpensify]

Unable to reproduce on iOS v1.2.42-2.

• Opened app
• Uploaded photo with internet - worked fine
• Went to airplane mode
• Uploaded photo - showed "Uploading attachment" in main chat
• Once connected back to internet, photo loaded once I went back into the chat.

Tried to test on Android via Browserstack but was getting an endless spinner when trying to sign in.

Anything I might be missing? @kavimuru can you please test again? Thanks

[MonilBhavsar]

I'm able to reproduce.

@mallenexpensify the internet needs to be turned off and then tap on image attachment

[MonilBhavsar]

On web also, there is no loader. But yeah we should stop showing infinite loader as the request already failed and display some message/icon

[mallenexpensify]

Thanks @MonilBhavsar . I was able to reproduce today (maybe I wasn't on the latest version ¯_(ツ)_/¯ )
I'm unsure if this can be external so adding in an engineer....

[neil-marcellini]

We decided to hold this until the Onyx image caching is working as described in the tracking issue here #10894.

[mallenexpensify]

Looks like #10894 is still open

[neil-marcellini]

Still on hold, but the latest update here is that the caching PR is very close.

[mallenexpensify]

• [Tracking][Image][Polish] Image-related feature request and improvements #10894 (comment)

Quick little update: the React native web fix has been merged! I'm trying to publish our update (following this SO)

Update: published here! https://www.npmjs.com/package/@expensify/react-native-web/v/0.18.11

Should be able to take off hold soon

[neil-marcellini]

I believe we are still waiting on the App PR for image caching based on the latest update #10894 (comment).

[neil-marcellini]

Still waiting.

[mvtglobally]

Issue is reproducible during KI retests.

No infinite loading, but also no error, just blank.

1711963917259.TQZS4534.mp4

1711899843140.RPReplay_Final1711899737.mp4

[hungvu193]

It's being fixed here:

#35502

[mallenexpensify]

PR for issue we're held on is actively being worked on. Bumping this to weekly
#35502

[mallenexpensify]

PR this is held on is very, very close to merging
#39290 (comment)

[mallenexpensify]

PR hit production two days ago 🎉

• Fix - Attachment page keeps on loading infinitely. #39290 (comment)

Unable to reproduce now, on Staging iOS. @neil-marcellini , should we not close this for some reason?

2024-05-24_14-27-06.mp4

[hungvu193]

I think I'm eligible for reporting bonus for this one 😂. One of the first issue I reported here

[mallenexpensify]

Wow... looks like you might be. Help me track @hungvu193 to make sure I have this right

• You reported the 'infinite spinner' bug forever ago on Dec 26th of 2022
• [$500] Chat - Attachment page keeps on loading infinitely. #35502 was reported later and is very similar
• Fix - Attachment page keeps on loading infinitely. #39290 (comment) was the PR to fix [$500] Chat - Attachment page keeps on loading infinitely. #35502 and it also fixed this bug
• You're due compensation since you reported the bug first, even though it was another PR that fixed it (and the associated bug/issue for that was reported after).

Sound right?

[hungvu193]

@mallenexpensify Yes. That's correct

[mallenexpensify]

Ok... Since the report was from 2022, I'm going to assume it was $250.

@hungvu193 can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01c9e76cecfe58dcad

[hungvu193]

Sure. I've accepted. Thank you 😊

[mallenexpensify]

Bug Reporter: @hungvu193 paid $250 via Upwork.