-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAY] Image infinite loading when offline #13826
Comments
Unable to reproduce on iOS v1.2.42-2.
Tried to test on Android via Browserstack but was getting an endless spinner when trying to sign in. Anything I might be missing? @kavimuru can you please test again? Thanks |
I'm able to reproduce. @mallenexpensify the internet needs to be turned off and then tap on image attachment |
On web also, there is no loader. But yeah we should stop showing infinite loader as the request already failed and display some message/icon |
Thanks @MonilBhavsar . I was able to reproduce today (maybe I wasn't on the latest version ¯_(ツ)_/¯ ) |
Looks like #10894 is still open |
Still on hold, but the latest update here is that the caching PR is very close. |
Should be able to take off hold soon |
I believe we are still waiting on the App PR for image caching based on the latest update #10894 (comment). |
Still waiting. |
Issue is reproducible during KI retests. No infinite loading, but also no error, just blank. 1711963917259.TQZS4534.mp41711899843140.RPReplay_Final1711899737.mp4 |
It's being fixed here: |
PR for issue we're held on is actively being worked on. Bumping this to weekly |
PR this is held on is very, very close to merging |
PR hit production two days ago 🎉 Unable to reproduce now, on Staging iOS. @neil-marcellini , should we not close this for some reason? 2024-05-24_14-27-06.mp4 |
I think I'm eligible for reporting bonus for this one 😂. One of the first issue I reported here |
Wow... looks like you might be. Help me track @hungvu193 to make sure I have this right
Sound right? |
@mallenexpensify Yes. That's correct |
Ok... Since the report was from 2022, I'm going to assume it was $250. @hungvu193 can you please accept the job and reply here once you have? |
Sure. I've accepted. Thank you 😊 |
Bug Reporter: @hungvu193 paid $250 via Upwork. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Image should show error or placeholder error.
Actual Result:
The image is infinite loading.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
RPReplay_Final1671850663.MP4
CYVJ9736.1.MP4
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671962332211369
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @mallenexpensifyThe text was updated successfully, but these errors were encountered: