-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-02-23] [$1000] Allow avatar image uploads: bmp
on iOS
#15035
Comments
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new. |
Bug0 Triage Checklist (Main S/O)
|
bmp
on iOSbmp
on iOS
Job added to Upwork: https://www.upwork.com/jobs/~01d9fdd76b47328f10 |
Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Current assignee @Beamanator is eligible for the External assigner, not assigning anyone new. |
@Santhosh-Sellavel there's already some proposals in this issue: #14751 I created this one to track the iOS fix, while the old issue used to track both but will now only track the Android fix |
ProposalPlease re-state the problem that we are trying to solve in this issue.Uploading What is the root cause of that problem?This is a bug in What changes do you think we should make in order to solve the problem?Update What alternative solutions did you explore? (Optional)None |
@s77rt Proposal sound's good to me, let's wait and hear from the maintainer cc: @Beamanator |
Bumped the maintainer, and they responded hopefully we would get reviewed this weekend, else let's follow up next week! |
Awaiting a review of the PR upstream. Let's reach back out in a couple of days. |
The upstream PR has been merged 🎉 |
📣 @s77rt You have been assigned to this job by @Beamanator! |
Wow that's great the maintainers are quick & have already merged the fix!! 🚀 |
bmp
on iOSbmp
on iOS
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-02-23. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Regression Test Proposal
|
Okay, we're ready for payment here. Sent the following offers:
|
Any thoughts on these @Santhosh-Sellavel @Beamanator? This was a bug upstream, right? |
As for the regression test.. I'm not convinced we need to test BMP on iOS specifically really on every regression run. It's primarily a windows based format, isn't it? Given that, I'm voting we don't proceed with adding it to the test suite. Let me know what you think! |
Yeah, it was an upstream bug. we can check the first 3 off as N/A. Let me know your thoughts @Beamanator |
Dope. Settled up with everyone! |
@Beamanator if you happen to disagree that a regression test for BMP on iOS is not needed, feel free to reopen. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
.bmp
image as avatar on iOSExpected Result:
The image should upload no problem, and is converted to
jpg
file typeActual Result:
iOS throws errors when uploading BMP
Note: Some investigation was done #12549 (comment), indicating this may be a problem with a library we use,
RNImageManipulator
Workaround:
Yes, just can't upload this file type on iOS devices
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: Latest
Reproducible in staging?: Y
Reproducible in production?: Y
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: