-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-05-03] [$2000] Sliding using fingers on android from pdf to image gets stuck and doesn't work the way how sliding from image to pdf works #15988
Comments
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Catching up from being OOO and urgent bank GHs, I'll try to get to this one by EOW. |
Ops GHs have been a higher priority, I haven't had time to test yet. |
Focused on another urgent task, I'll try to get to this one tomorrow. |
Just adding to the OP, swiping doesn't work at all when viewing PDF attachments -- it doesn't matter what the next attachment type is. |
@luacmartins - looks like we see this as a problem. Do you think I should mark it as external? Thanks! |
@alexpensify yes, it is a problem indeed and we can mark it external. |
I'll assign myself as well to manage the engineering side since I was involved in the PR that implemented the carousel feature. |
Job added to Upwork: https://www.upwork.com/jobs/~0181fbb67dfdeb58e8 |
Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav ( |
Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.The carousel swipe navigation doesn't work when viewing a PDF. What is the root cause of that problem?This is caused by the What changes do you think we should make in order to solve the problem?Given that the carousel navigation only requires right/left swipes, and the |
Looks like something related to As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our Feel free to drop a note in #expensify-open-source with any questions. |
@Ollyws's proposal looks good to me. What do you think @0xmiroslav ? |
@luacmartins thanks for reviewing proposal in advance but sorry I am yet to accept that solution.
This is actually wrong. PDFView requires horizontal swipes when zoomed in. bug.mp4 |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.5-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-05-03. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Alright, let's get this issue kicked off. Looking at the linked PR, it appears that this PR does qualify for the 50% bonus based on this PR being merged three business days later. @0xmiroslav @luacmartins can you confirm? If that's the case, then we have the following payouts:
|
Then as for Upwork, the previous link has expired. @avi-shek-jha and @alexxxwork can both of you please apply ahead of the regression period ending? |
Finally, @0xmiroslav let's get the BugZero checklist kick off above. Thanks all! |
@JmillsExpensify I tried applying but it says 'This job is no longer available'. Would you mind sending me an invitation on Upwork or a new link instead? Thanks |
Ah yeah for sure. I neglected to post the new link: https://www.upwork.com/jobs/~01534ddafa2e696d30 |
Seems like I can't access the slack link that you mentioned above (May be the link is just for the internal members). Here's my upwork profile link It would be great if you could send me an invitation since I wasn't able to access both the upwork link and the slack link. Sorry for the inconvenience. |
Done! Sorry for the trouble. |
@JmillsExpensify I assigned @alexxxwork to the PR on Apr 18 and we merged it on Apr 24, so I don't think this qualifies for the bonus based on our guidelines. |
@JmillsExpensify, Received and submitted the work. Thanks |
@avi-shek-jha Great! We'll circle back on payments when the regression period passes. @luacmartins Great catch! I updated my comment above with the payouts. |
@JmillsExpensify Applied, thank you! |
Tomorrow we'll close this one out. |
Ah though @0xmiroslav before we do, please don't forget about the BugZero checklist, thank you! |
@JmillsExpensify @0xmiroslav raised a good point that issue took 6 days from assignment to PR being merged because another PR completely changed the structure of the component the original proposal was based on. In light of that, I think that this issue qualifies for the bonus! Sorry about the back and forth! |
No PR caused regression which means that "worked before but after PR, the issue started to happen". Regression Test Proposal
|
That was DM chat so sharing that convo here: |
All good! I updated the original comment above with the correct amounts. I'm also issuing payments now. |
Payments issued to reporter and C+. Sent offer to contributor via Upwork! I'll pay the bonus when the contract is accepted and a final payment is made. |
@alexxxwork When you have a moment, please accept the Upwork offer/contract and we can make sure you are paid. Thank you! |
@JmillsExpensify Accepted, thank you! |
Thank you! Everyone is paid out and the regression test is linked above. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Sliding using fingers from pdf to image gets stuck and sometimes doesn't swipe too and doesn't work the way how sliding from image to pdf works
Actual Result:
Sliding using fingers from pdf to image gets stuck and doesn't work
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.85-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
slide.mp4
az_recorder_20230314_120243.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @avi-shek-jha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1678863680773659?thread_ts=1678796475.385589&cid=C049HHMV9SM
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: