[HOLD for payment 2023-12-29] [$250] Migrate SearchPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/SearchPage.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015fa113b288776a75
• Upwork Job ID: 1681356452396900352
• Last Price Increase: 2023-07-18

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[Piotrfj]

Hi I'm Piotr from Callstack - expert contributor group - will start investigation in this area

[melvin-bot]

📣 @Piotrfj! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[disha-np]

Can I work on this?

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[mejed-alkoutaini]

I'm able to work on this if needed!

[to-ai]

I am able to work on this task.

[ghost]

Dibs

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015fa113b288776a75

[melvin-bot]

Triggered auto assignment to @trjExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[allroundexperts]

Yep. On my list for tomorrow!

[ghost]

Can I work on it?

[isabelastisser]

@allroundexperts @marcaaron what's next here?

[allroundexperts]

@isabelastisser The update is that @koko57 has taken over the PR and has resolved my pending comments. I'll take a look at it again tomorrow.

[isabelastisser]

Hey @allroundexperts, please provide an update. Thanks!

[allroundexperts]

I've approved the PR. @marcaaron requested some changes which were recently fixed by @koko57. The PR is ready for marc's review again.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate SearchPage.js to function component  #27924

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @Piotrfj does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

@allroundexperts, @isabelastisser, @marcaaron, @Piotrfj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@allroundexperts, @isabelastisser, @marcaaron, @Piotrfj Eep! 4 days overdue now. Issues have feelings too...

[isabelastisser]

@allroundexperts please complete this task before I can close the issue. Thanks!

[@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

[isabelastisser]

Payment summary:

$250 to @allroundexperts for C+ review.

requires payment through NewDot Manual Requests

[isabelastisser]

Bump @allroundexperts to complete the checklist above.

[allroundexperts]

@isabelastisser I don't think that we have checklists for component migrations.

[JmillsExpensify]

$250 payment to @allroundexperts based on this comment.