-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create an Update button in the app's top-bar menu #1664
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yeah, Correct. A mock-up would be good to submit a complete proposal. I was following it closing #1318 here. @nbhargava did a great job. As starting the Main concept would be as follows: Proposal
Which will start the Update process as it does for closing or submitting the Question:Are you looking for the Web platform update as well? it's not clear from the Issue description. |
Nope, sorry for the confusion. This is desktop-only.
That actually won't work because that Onyx key is only set when the update notification is pressed here, but the whole point of adding the button in the settings menu is that it's possible to disable notifications entirely for the desktop client, and if you did that you would then have no way of updating it. |
Ah sorry, Didn't see this part. So if this is the case. Then We can do is set the key on Onyx if the user has not given the notification permission. Something Like.
updating the push method according. or if throwing the error is not an option. I see listening on the |
In order to solve this problem it will be necessary to put in place the update button of the application and define its appearance on two conditions to know according to the platform and the availability of update. So once the update is available it will be displayed. |
cc @nbhargava — ready to go! |
If you haven’t already, check out our contributing guidelines for onboarding!
Platform - version:
Web/Desktop - v1.0.1-454
Action Performed (reproducible steps):
Expected Result:
Update
button in app's top-bar menu — I.e. here:https://www.upwork.com/jobs/~016781e062ce860b84
The text was updated successfully, but these errors were encountered: