Create an Update button in the app's top-bar menu

[bfitzexpensify]

If you haven’t already, check out our contributing guidelines for onboarding!

---

Platform - version:
Web/Desktop - v1.0.1-454

Action Performed (reproducible steps):

• In Add auto-update on hide workflow for Electron on Mac #1318 we updated the desktop update paradigm. When an update is available, a notification appears (as before). Except now, clicking on the notification opens the UpdateAppModal, which updates and restarts the app.
• However, if the user has notifications disabled, they will never see the update notification and have no way to update the app

Expected Result:

• We need users to be able to update, even if they have notifications disabled. On desktop, when an update is available, we need to create an Update button in app's top-bar menu — I.e. here:

https://www.upwork.com/jobs/~016781e062ce860b84

[parasharrajat]

Yeah, Correct. A mock-up would be good to submit a complete proposal. I was following it closing #1318 here. @nbhargava did a great job. As starting the Main concept would be as follows:

Proposal

1. Create the button on the Settings page as per the mockups.
   To show the button when the update is available, we will listen to the following Onyx Key.

export default withOnyx({
    version: {
        key: ONYXKEYS.UPDATE_VERSION,
        initWithStoredValues: false,
    },
});

2. On Press of the Button we have to send a message to the main Process using the

ipcRenderer.sendSync('start-update', props.version);

Which will start the Update process as it does for closing or submitting the UpdateAppModal.

Question:

Are you looking for the Web platform update as well? it's not clear from the Issue description.

[roryabraham]

Are you looking for the Web platform update as well?

Nope, sorry for the confusion. This is desktop-only.

To show the button when the update is available, we will listen to the following Onyx Key

That actually won't work because that Onyx key is only set when the update notification is pressed here, but the whole point of adding the button in the settings menu is that it's possible to disable notifications entirely for the desktop client, and if you did that you would then have no way of updating it.

[parasharrajat]

Ah sorry, Didn't see this part. So if this is the case. Then We can do is set the key on Onyx if the user has not given the notification permission. Something Like.

  pushUpdateAvailableNotification({version}) {
        push({
            title: 'Update available',
            body: 'A new version of Expensify.cash is available!',
            delay: 0,
            onClick: () => {
                Onyx.merge(ONYXKEYS.UPDATE_VERSION, version);
            },
        }).then(((notification) => {
        if(!notification){
        
        Onyx.merge(ONYXKEYS.UPDATE_VERSION, version);
        }
        });
    },

updating the push method according. or if throwing the error is not an option.

I see listening on the ipcRenderer.on('update-downloaded') ; would be a repetitive step. As we again need to check the user notification permission and then Set the Onyx Key.
Also, checking the user notification permission is important as the old Update procedure shows the UI based on Notification unless we want to touch that part.

[Shadows97]

In order to solve this problem it will be necessary to put in place the update button of the application and define its appearance on two conditions to know according to the platform and the availability of update. So once the update is available it will be displayed.

[bfitzexpensify]

cc @nbhargava — ready to go!