Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app menu item for updating #1766

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Add app menu item for updating #1766

merged 1 commit into from
Mar 17, 2021

Conversation

nbhargava
Copy link
Contributor

Details

Implements an app menu item for updating the app when an update has been fully downloaded.

Fixed Issues

Fixes #1664.

Tests

  1. Open app, see that Update option is grayed out.
  2. Download app and without hitting the notification, notice that Update option is now available.
  3. Even after continuing to interact with the app, the Update option stays available in the menu.
  4. When hitting the update app, it correctly goes through the auto-update flow.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

N/A

Mobile Web

N/A

Desktop

Here's a video of the new experience: https://www.dropbox.com/s/iuyhnwjck4ofejo/Screen%20Recording%202021-03-13%20at%2010.46.05%20AM.mov?dl=0

iOS

N/A

Android

N/A

@nbhargava nbhargava requested a review from a team as a code owner March 13, 2021 15:51
@botify botify requested review from Luke9389 and removed request for a team March 13, 2021 15:51
@nbhargava
Copy link
Contributor Author

@roryabraham -- this should match the experience recommended in the original ticket.

@nbhargava
Copy link
Contributor Author

@roryabraham -- friendly ping!

@roryabraham
Copy link
Contributor

Sorry for the delay @nbhargava, looking this over now!

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always @nbhargava!

@roryabraham roryabraham merged commit 490d565 into Expensify:master Mar 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an Update button in the app's top-bar menu
2 participants