[HOLD for payment 2023-04-20] [$1000] Inconsistency hint text for zipcode on home address page vs the connect bank account page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging dot on web chrome
2. Go to settings
3. Go to Personal Information and search for any location
4. Notice that below the zipcode field, it displays the text as 'Format'
5. Now go to any workspace. Go to connect bank account page
6. Fill in the details and in the step 2 , notice that below the zipcode field, it mentions as 'e.g'. Thus, for the same field in two different areas on the application, different texts are displayed.

Expected Result:

To maintain consistency between the same zipcode field in home address vs the connect bank account page, it should either display 'format' or it should display 'e.g' in both pages.

Actual Result:

In the home address page, the text has been displayed as format, whereas in the connect bank account page, the text has been displayed as 'e.g' for the same zipcode field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.94-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

format-2023-04-04_10.24.11.mp4

Recording.130.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680583640960019

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018fb5c289df121167
• Upwork Job ID: 1643295291269828608
• Last Price Increase: 2023-04-04

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

Let's use the e.g. format in both places. Ideally we can just use the same constant for the subtext in both places.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~018fb5c289df121167

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[getusha]

Proposal

Please re-state the problem that we are trying to solve in this issue.

the zip / postal code hint text is inconsistent across Home and Bank account page

What is the root cause of that problem?

The hint is being applied by adding Format: instead of e.g.

What changes do you think we should make in order to solve the problem?

We should replace Format: here to e.g. which makes the hint consistent across the required pages.

App/src/languages/en.js

Line 131 in aa1e2ed

format: ({zipSampleFormat}) => (zipSampleFormat ? `Format: ${zipSampleFormat}` : ''),

What alternative solutions did you explore? (Optional)

[Milos213]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Zipcode hint is different between Home address pae and Connect bank account page

What is the root cause of that problem?

localization keys are different between those pages
Home address page uses common.format, while Connect bank account page uses common.zipCodeExample

What changes do you think we should make in order to solve the problem?

Whether to use Format: or e.g. depends on team's decision.
The main fix here should be to unify 2 separate localization and validations.

We can deprecate common.zipCodeExample which is used specifically for U.S. And use common.format instead which is used generally for all countries. So specify US like this:
translate('common.format', {zipSampleFormat: CONST.COUNTRY_ZIP_REGEX_DATA.US.samples}

occurrences: AddressForm, AddDebitCardPage

(Optional) We can also deprecate CONST.REGEX.ZIP_CODE and use CONST.COUNTRY_ZIP_REGEX_DATA.US.regex instead

[Mabroorkhan]

Proposal

Please re-state the problem that we are trying to solve in this issue.
Zipcode hint is different between Home address page and Connect bank account page

What is the root cause of that problem?
localization keys are different between those pages
In Home address page common.format is used, but in Connect bank account page common.zipCodeExample is used

What changes do you think we should make in order to solve the problem?
Both the pages should use a generic component this will eject the bug as well as code duplication could be avoided, here we can loop on number of fields and get a return of desired field from same generic component
The format should not be coming from outside the component but should be decided by the component itself

[MelvinBot]

📣 @Mabroorkhan! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Mabroorkhan]

Contributor details
Your Expensify account email: mabroorkhan123@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~012398acc7fb2db5f8

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[UzairHKhan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Zipcode hint is different between Home address page and Connect bank account page

What is the root cause of that problem?

Seems like in both the components they are using hard-coded hint text.

What changes do you think we should make in order to solve the problem?

We can solve this problem by making a JSON for every hint text used in the forms and then we can use these hint text in every form. this will help in the future when changing any text it will impact all of them and the issue will be solved.

[MelvinBot]

📣 @UzairHKhan! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[UzairHKhan]

Contributor details
Your Expensify account email: uzairhasan2@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01dbef95d709ef2d85

[MelvinBot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[rushatgabhane]

on it

[rushatgabhane]

We definitely wanna keep the custom zip formatter because it has different examples for all the countries -

App/src/CONST.js

Lines 1364 to 1367 in 3c52ad1

	COUNTRY_ZIP_REGEX_DATA: {
	AC: {
	regex: /^ASCN 1ZZ$/,
	samples: 'ASCN 1ZZ',

@puneetlath I like @getusha's proposal.
@getusha we should also deprecate common.zipcode in the PR

C+ reviewed 🎀 👀 🎀

[MelvinBot]

📣 @getusha You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Milos213]

Thanks for clarification. I am fine with that approach.
But there's no strict rule that there should be only 1 contributor assigned. I saw some similar issues which split compensation between contributors and this is good for teamwork.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix hint inconsistent zipcode format #17144

If no regressions arise, payment will be issued on 2023-04-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter @priya-zha
• Contributor that fixed the issue @getusha
• Contributor+ that helped on the issue and/or PR @rushatgabhane

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @puneetlath] The PR that introduced the bug has been identified. Link to the PR: Refactor requestor step form #12766
• [@rushatgabhane / @puneetlath] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/12766/files#r1185929210
• [@rushatgabhane / @puneetlath] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1683282690130979
• [@puneetlath] Determine if we should create a regression test for this bug. n/a
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. n/a
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: n/a

[puneetlath]

@rushatgabhane I've invited you to the Upwork job. Can you help out with the checklist as well?

@priya-zha @getusha can you also please apply to the upwork job: https://www.upwork.com/jobs/~018fb5c289df121167

[priya-zha]

@puneetlath Submitted the proposal on Upwork. Thanks

[rushatgabhane]

didn't get time yet. hopefully will complete today 🤞

edit: ETA 20 Apr

[puneetlath]

@priya-zha and @getusha have been paid.

@rushatgabhane just waiting on the checklist for you.

[MelvinBot]

@puneetlath, @rushatgabhane, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

@rushatgabhane bump on the checklist!

[puneetlath]

@rushatgabhane bump again on the checklist. Would love to get this paid and closed out. Thanks!

[puneetlath]

@rushatgabhane bump!

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: Refactor requestor step form #12766

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/12766/files#r1185929210

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1683282690130979

4. Determine if we should create a regression test for this bug - Not required.

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. - Not required.

[rushatgabhane]

Hi @puneetlath im so sorry, for the delay!
I've updated the checklist

[puneetlath]

Thanks @rushatgabhane. All paid! Closing out.