-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-04-20] [$1000] Inconsistency hint text for zipcode on home address page vs the connect bank account page #16912
Comments
Triggered auto assignment to @puneetlath ( |
Bug0 Triage Checklist (Main S/O)
|
Let's use the |
Job added to Upwork: https://www.upwork.com/jobs/~018fb5c289df121167 |
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.the zip / postal code hint text is inconsistent across Home and Bank account page What is the root cause of that problem?The hint is being applied by adding What changes do you think we should make in order to solve the problem?We should replace Line 131 in aa1e2ed
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Zipcode hint is different between Home address pae and Connect bank account page What is the root cause of that problem?localization keys are different between those pages What changes do you think we should make in order to solve the problem?Whether to use We can deprecate occurrences: AddressForm, AddDebitCardPage (Optional) We can also deprecate |
ProposalPlease re-state the problem that we are trying to solve in this issue. What is the root cause of that problem? What changes do you think we should make in order to solve the problem? |
📣 @Mabroorkhan! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Format:
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
ProposalPlease re-state the problem that we are trying to solve in this issue.Zipcode hint is different between Home address page and Connect bank account page What is the root cause of that problem?Seems like in both the components they are using hard-coded hint text. What changes do you think we should make in order to solve the problem?We can solve this problem by making a JSON for every hint text used in the forms and then we can use these hint text in every form. this will help in the future when changing any text it will impact all of them and the issue will be solved. |
📣 @UzairHKhan! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Format:
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
on it |
We definitely wanna keep the custom zip formatter because it has different examples for all the countries - Lines 1364 to 1367 in 3c52ad1
@puneetlath I like @getusha's proposal. C+ reviewed 🎀 👀 🎀 |
📣 @getusha You have been assigned to this job by @puneetlath! |
Thanks for clarification. I am fine with that approach. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.99-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-04-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@rushatgabhane I've invited you to the Upwork job. Can you help out with the checklist as well? @priya-zha @getusha can you also please apply to the upwork job: https://www.upwork.com/jobs/~018fb5c289df121167 |
@puneetlath Submitted the proposal on Upwork. Thanks |
didn't get time yet. hopefully will complete today 🤞 edit: ETA 20 Apr |
@priya-zha and @getusha have been paid. @rushatgabhane just waiting on the checklist for you. |
@puneetlath, @rushatgabhane, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@rushatgabhane bump on the checklist! |
@rushatgabhane bump again on the checklist. Would love to get this paid and closed out. Thanks! |
@rushatgabhane bump! |
|
Hi @puneetlath im so sorry, for the delay! |
Thanks @rushatgabhane. All paid! Closing out. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
To maintain consistency between the same zipcode field in home address vs the connect bank account page, it should either display 'format' or it should display 'e.g' in both pages.
Actual Result:
In the home address page, the text has been displayed as format, whereas in the connect bank account page, the text has been displayed as 'e.g' for the same zipcode field.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.94-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
format-2023-04-04_10.24.11.mp4
Recording.130.mp4
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680583640960019
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: