-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-20] [$1000] Showing the report action menu for two messages at the same time #16923
Comments
Triggered auto assignment to @dylanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Reproduced, but updated OP to be a bit clearer of repro steps |
Job added to Upwork: https://www.upwork.com/jobs/~0169a9bfc76777e15d |
Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
Triggered auto assignment to @thienlnam ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The mini report action context menu is sometimes displaying multiple times when we only want to display it once. What is the root cause of that problem?When we initiate the edit, if we move our mouse inside the What changes do you think we should make in order to solve the problem?The most straight forward way to solve this is to trigger a blur event on the App/src/pages/home/report/ReportActionItemMessageEdit.js Lines 232 to 244 in 2831da1
The same happens if you press context-menu-issue-2023-04-05_21.08.43.mp4What alternative solutions did you explore? (Optional)Another way to implement the same solution above is to call App/src/components/Hoverable/index.js Lines 107 to 111 in 6f6cf65
Then we can call it in the same place(s) as the main solution above. |
@Pujan92 The linked issue is slightly different than this one. The linked PR seems unrelated too. |
Sorry, my bad. Based on the title I just mapped it to an earlier issue. but yes this issue is slightly different. |
Cool, there is no rush, In the future please check twice before you mention PR that caused a regression or include any specifics about the changes that were made which caused a regression, thanks! |
Heads Up! We are looking to remove onBlur logic from Hoverable #16052. I am yet to confirm this but chances are evolving. |
@parasharrajat Should we keep this on hold? |
bump @parasharrajat |
I will update you soon on this. Thanks. |
Based on my calculations It took 5 hours, and 14 minutes, If there is no regression, I believe it should be eligible for an urgency bonus |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.68-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-20. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@arosiclair mind chiming in here - was the urgency not hit due to internal freeze? It looks that way, but confirming |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test StepsRemove all reactions for Web/Desktop
task thread for Web/Desktop
Do you agree 👍 or 👎 ? |
Yeah that's correct. I approved the PR about a day after they were hired but held on the merge freeze. |
ping @dylanexpensify |
@dylanexpensify, @arosiclair, seems there is no regression here. can we process the UpWork contract? |
Sorry - on it! |
Payment summary:
Upwork Job! Please apply! |
@jayeshmangwani please accept the offer sent to you! 🙇♂️ |
@wildan-m paid! |
@dylanexpensify Offer accepted |
done! |
This comment was marked as outdated.
This comment was marked as outdated.
I forgot to mention earlier, that this issue was reopened and reporting bonus was already paid out to @jayeshmangwani #16923 (comment). we reopened this issue after #18555 so @dhanashree-sawant should be eligible for reporting bonus here. I can see that we didn't pay that reporting bonus on #18555 to her. |
It might be better to pay that reporting bonus on #18555 to keep the state clean and skip the reporting bonus for this issue. @dylanexpensify |
@dylanexpensify Sorry for the confusion here, @parasharrajat is right and I was already paid a few months back for this issue but I somehow forgot about that, Rajat thanks for clearing things |
Hello! Thanks for bringing to my attention! @jayeshmangwani we'll leave you with the bonus we paid out - this is on us! @dhanashree-sawant let me get you paid out for the reporting amount in the other issue (confirmed here)! |
Payment requested as per #16923 (comment) |
$1,500 payment approved for @parasharrajat based on BZ summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The action menu should be displayed on the last focused message, not on the two messages at the same time
Actual Result:
The action menu is showing for two messages at the same time
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.94-0
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Two-actionmenu-bug.mov
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680592894095989
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: