Chat - Some photos show up in an empty frame when user is offline

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Log in with a HIGH traffic account.
3. Disable the internet connection in the device
4. Navigate to a chat that has a very long history - Verify the chat opens and the loading animation is shown

Expected Result:

Offline photos must be displayed in full, as well as all chat information

Actual Result:

Some photos show up in an empty frame when I'm offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.95.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

photo.prame.ios.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@sonialiap Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@sonialiap Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@sonialiap 10 days overdue. Is anyone even seeing these? Hello?

[MelvinBot]

@sonialiap this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@sonialiap 12 days overdue. Walking. Toward. The. Light...

[sonialiap]

Looks like I somehow missed this issue before going OOO, my apologies!

[sonialiap]

I'm unable to reproduce. When I scroll up through past messages in chats of various age/length I eventually reach a point where history stops loading. But through the visible history all images are loading correctly

[sonialiap]

@kbecciv could you add a bit more info on how to reproduce this behavior? Are you able to reproduce it with any other chat or just with 123 mWeb?

[kbecciv]

@sonialiap I was able to reproduce with High Traffic Account

[sonialiap]

@kbecciv that did not answer my question. Are you reproducing this behavior only on the chat with 123 mWeb, or with other chats as well?

[kbecciv]

@sonialiap QA team can reproduce this issue with any chat using HT account.

[sonialiap]

If others can reproduce then sounds good to me, passing on to engineering

[MelvinBot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

@sonialiap @roryabraham this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[roryabraham]

So this is really easy to reproduce. You just have to:

1. Open chat A
2. Upload an image
3. Open chat B
4. Go offline
5. Open chat A

Then 100% of the time the image won't display. The reason is simple, we just don't support offline images yet.

So this is definitely a feature request and not a bug. It's also probably a duplicate from something sitting in this issue.

cc @Beamanator Surely this must already be documented somewhere, but I couldn't find it anywhere. So I'm going to make this a monthly, put it on HOLD, and include it under Feature Requests in the image improvements tracking issue. Feel free to close this if it's a dupe.

[sonialiap]

on hold

[roryabraham]

Making this a monthly while it's on HOLD. I haven't seen any progress on offline image support in a long while. For now, that project is on HOLD for us to migrate E/App from S3 to our servers, and that's an active project.

[sonialiap]

Looks like this one is still on hold

[roryabraham]

Still on HOLD

[roryabraham]

Still on HOLD

[sonialiap]

This has been open since April, we should ask applause to let us know if they're still running into this. I'm not sure what's the best way to reach them though. @roryabraham do you know?

[sonialiap]

@kbecciv are you guys still able to reproduce this?

[kbecciv]

Issue is no longer reproducible!

0-02-01-ce346280419249f7c10176c052b185fe706e41cdc9666aff96f1ff9f2c639df0_e546f2136b226251.mp4

[roryabraham]

Awesome! Before we close this, I'd like to make sure that we have a regression test in place covering it.

[roryabraham]

Requested confirmation of the regression test here

[roryabraham]

regression test added, closing this out