-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-04-26] [$1000] Storybook - Errors appear in the JS console for Forms and PopoverMenu #17092
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Reproduced. |
Thanks @situchan ! We'll just finishing triaging this, but I imagine we'll end up taking you up on your offer there. |
Triggered auto assignment to @cristipaval ( |
@cristipaval LMK if you agree with having @situchan fix this! |
@cristipaval, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
1 similar comment
@cristipaval, @joekaufmanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@joekaufmanexpensify yes I do agree, but I think we still need a proposal and a C+ to review the proposal and the PR. |
Sounds good! @situchan could you please share your proposal? |
Job added to Upwork: https://www.upwork.com/jobs/~0191bc581b220c1229 |
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav ( |
Current assignee @cristipaval is eligible for the External assigner, not assigning anyone new. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Storybook - Errors appear in the JS console for Forms and PopoverMenu What is the root cause of that problem?Formmissed PopoverMenu
What changes do you think we should make in order to solve the problem?Formin file PopoverMenuin file import getPlatform from '../src/libs/getPlatform';
import {SafeAreaProvider} from 'react-native-safe-area-context';
const decorators = [
(Story) => {
React.useEffect(() => {
const isWeb = _.contains([CONST.PLATFORM.WEB, CONST.PLATFORM.DESKTOP], getPlatform());
if (isWeb && !document.querySelector('meta[name=theme-color]')) {
const meta = document.createElement('meta');
meta.setAttribute('name', 'theme-color');
meta.setAttribute('content', '');
document.getElementsByTagName('head')[0].appendChild(meta);
}
}, []);
return (
<ComposeProviders
components={[
OnyxProvider,
SafeAreaProvider,
LocaleContextProvider,
HTMLEngineProvider,
]}
>
<Story />
</ComposeProviders>
);
},
]; What alternative solutions did you explore? (Optional) |
@ahmedGaber93 We also have |
ProposalPlease re-state the problem that we are trying to solve in this issue.Error appears in Storybook Form and PopoverMenu / Add payment Methods What is the root cause of that problem?
What changes do you think we should make in order to solve the problem? |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-04-26. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Okay, getting ready for issuing payment in a few days. @situchan was assigned to this issue on 2023-04-13. The PR was merged on 2023-04-17. The 15th, and 16th were weekend days though, so this PR only took 2 business days to merge and qualifies for a speed bonus. With that in mind, we need to pay:
|
@situchan offer sent for $1,000! |
@mananjadhav offer sent for $1,000! |
@fedirjh offer sent for $250! |
@mananjadhav @cristipaval I feel like no regression test is needed here because this isn't a user facing error. Curious if y'all agree? |
yes I do agree, this can't be tested by Applause team so it doesn't make sense to add a regression test. |
Awesome. Just checked off those steps. |
@mananjadhav , mind taking care of the remaining BZ steps? That's all we need to do before we issue payment here. |
@joekaufmanexpensify @cristipaval the offending PR is linked in the earlier chats #13580 and I don't think this needs a regression test. Could you let me know which other steps are pending? |
I think we can close this issue if the payments are done |
Payments are pending for this one. |
Is there not anything we need to discuss to catch this type of bug sooner? That's cool, if not. But in general it's good idea to note on the GH issue so we can make sure we're completing all of the Bug Zero checklist options, or at least acknowledging that we think one of the steps is not necessary, and why. |
There is an item in the checklist related to Storybook. With the linked PR, the issue was we had too many test cases to test as the change had an impact across the App. |
Got it, makes sense. Added that explanation to the above section of the BZ checklist! |
Thanks for the follow up @joekaufmanexpensify . Will you be able to now process the payout? |
Yep, we're all set, going to do it now! |
@situchan $1,500 sent and contract ended! |
@mananjadhav $1,500 sent and contract ended! |
@fedirjh $250 sent and contract ended! |
Upwork job closed. |
Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. TY everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Verify that no errors appear in the JS console and components (Form/PopoverMenu) renders without a problem.
Actual Result:
Errors appear in the JS console and components (Form/PopoverMenu) does not render due to an error.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @fedirjh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680745076761309
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: