[HOLD for payment 2023-06-29] [$1000] mWeb - Attachment - Modify the carousel component to improve swiping navigation between attachments

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go https://staging.new.expensify.com/
   and login
2. Open any chat that has many attachments
3. Click any attachment
4. Swipe left and right to ensure images/PDFs are displayed correctly

Expected Result:

Upon swiping next image or PDF should be displayed

Actual Result:

Same image is displayed, or carousel swipes many images forward or different direction.
Not repro with arrows.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.2.3

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6025509_video_27.mp4

Expensify/Expensify Issue URL:

Issue reported by: @Natnael-Guchima/ Applause - Internal Team

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681936903222229

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018952644874411358
• Upwork Job ID: 1650695107965104128
• Last Price Increase: 2023-04-25

[MelvinBot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Still happening after #17647, seems like something we should fix.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~018952644874411358

[MelvinBot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[MelvinBot]

Triggered auto assignment to @techievivek (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[burczu]

Hi I'm Bartek from Callstack - expert contributor group - I would like to work on this issue.

[techievivek]

Assigning @burczu(Callstack member) to the issue after internal discussions.

[MelvinBot]

📣 @burczu You have been assigned to this job by @techievivek!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Swiping between attachments in preview mode fix. #20245

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[aimane-chnaif]

This is very buggy and still reproducible on latest main:

mchrome1.mov

mchrome2.mov

mchrome-bug3.mov

[sakluger]

I just tested this myself in Browserstack using Android Chrome, and @aimane-chnaif is right - this isn't fixed at all. Swiping left or right still scrolls through many attachments instead of just one.

[sakluger]

@burczu @eVoloshchak @techievivek could someone please take a look to see why this is still broken after merging and deploying the PR here?

[eVoloshchak]

Yeah, I've left a comment about flickering here when reviewing the PR
It isn't fixed, but we still decided to merge since it's still better than it was before (essentially unusable)
This is a temporary solution, there are plans to migrate to a custom FlatList component, so this should be open till then

Yeah this bug does present a significant usability issue IMO, I think we should implement a temporary solution. Especially considering that the new list component seems to be a ways away

[sakluger]

@stephanieelliott welcome back! I missed the discussion around how we were only partially fixing this issue. I'll leave it to you to decide whether we should pay out now, or leave open until the new list component is ready (which it sounds like may be a ways out).

[sakluger]

@stephanieelliott friendly bump, what should we do for this one?

[stephanieelliott]

This comment has a good summary of where we decided on a partial fix:

While the actual solution relies on an enhanced version of the FlatList component, why don't we consider implementing the temporary solution proposed by @burczu, which appears to modify only the Carousel component? This way, when the FlashList becomes available, we can discard the temporary solution and find a more permanent fix.

Though they address the same issue, the temporary solution (modify the carousel component) and permanent fix (migrate to a custom FlatList component) will use completely different proposals and solutions. So I think the cleanest way to do this will be to:

• Update the scope of this issue to: Modify the carousel component to improve swiping navigation between attachments, consider it "resolved" seeing as the agreed-on proposal has been implemented, and pay it out as normal
• Open a new issue for Fix swiping navigation between attachments and put that on HOLD for the custom FlatList component

Anyone disagree?

[techievivek]

@stephanieelliott

Open a new issue for Fix swiping navigation between attachments and put that on HOLD for the custom FlatList component

Works for me because it would take some time before the WishList gets integrated into our codebase.

[stephanieelliott]

Created a new issue on hold for custom FlatList component: #22602

Extended offers to @eVoloshchak and @Natnael-Guchima in Upwork -- please accept when you get a chance and I will pay you out ASAP!

[Natnael-Guchima]

@stephanieelliott I have accepted the offer. Thanks.

[eVoloshchak]

@stephanieelliott, I've requested the payment for this via NewDot instead
I already have an active job for this on Upwork, could you just end it without the payment please?

[stephanieelliott]

Yep, sure can!

@Natnael-Guchima you've been paid
@eVoloshchak job was ended on Upwork, and you will be paid through NewDot