Not Found view briefly appears on workspace members and invite pages

[amyevans]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

This is a follow up issue from #17349 (comment)

Action Performed:

Open workspace members or invite page from deep link

Expected Result:

No flash of "Not Found" view

Actual Result:

Flash of "Not Found" view

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

invite.mov

members.mov

Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ab8e5ee8dfc45ea
• Upwork Job ID: 1669436508157517824
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[amyevans]

@jczekalski please comment on the issue so I can assign you

[dukenv0307]

This issue is fixed by this PR: #18967

[aimane-chnaif]

This issue is fixed by this PR: #18967

That doesn't fix the issue completely. We should show skeleton instead of full screen loading

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Open workspace members or invite page from deep link and have flash of "Not Found" view

What is the root cause of that problem?

In here

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Line 151 in b7391bc

shouldShow={_.isEmpty(this.props.policy)}

We're showing Not Found page if the this.props.policy is empty. When we navigate to the Workspace Settings page by link and login, the policy wasn't loaded yet (using the OpenApp API), so it shows Not Found briefly until the policy is loaded.

What changes do you think we should make in order to solve the problem?

Base on @aimane-chnaif's comment, we need to build WorkspaceInvitePageSkeletonView and WorkspaceMembersPageSkeletonView and check if the policy is empty and the report is loading, if yes that means the policy is not initially loaded yet, so we show a WorkspaceInvitePageSkeletonView or WorkspaceMembersPageSkeletonView

if (this.props.isLoadingReportData && _.isEmpty(this.props.policy)) {
    return <WorkspaceMembersPageSkeletonView />;
}

if (this.props.isLoadingReportData && _.isEmpty(this.props.policy)) {
    return <WorkspaceInvitePageSkeletonView />;
}

What alternative solutions did you explore? (Optional)

NA

[jczekalski]

I'm an expert contributor from Software Mansion and I'd like to investigate this issue (@amyevans).

[melvin-bot]

@amyevans, @mallenexpensify, @jczekalski, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

@jczekalski can you provide an update? Do you plan to post a proposal soon?

[jczekalski]

@mallenexpensify Sorry for the delay, we decided to reassign this task to a new developer who just joined the team. They just started working on it today.

[kowczarz]

Hey, I'm from Software Mansion, I'd like to work on this job.

[amyevans]

@kowczarz Just a heads up I added you to our Upwork whitelist, so in a few days (once it deploys), Melvin should stop asking you for your Upwork details whenever you comment on a GH 😄

[amyevans]

FYI: I'll be OOO tomorrow and Monday.

[kowczarz]

Currently the app displays loading indicator instead of not found view and then shows skeleton placeholder. Should we keep current behaviour, or should we modify it so the app will instantly show the skeleton placeholder?

Screen.Recording.2023-05-26.at.16.59.35_H.265.mp4

[aimane-chnaif]

@kowczarz to be consistent with other pages, should show skeleton before loading data

[kowczarz]

Proposal

Please re-state the problem that we are trying to solve in this issue.

To be consistent with other pages, we should show skeleton instead of full page activity indicator.

What is the root cause of that problem?

We have two different UI states during the loading of the workspace invite screen - first full page activity indicator, then skeleton flashes for a moment

What changes do you think we should make in order to solve the problem?

In withPolicyAndFullscreenLoading we can add a flag that will optionally disable the fullscreen activity indicator. Then we can add onyx state with information if the report data is loaded. If the data is being loaded we can prevent displaying FullPageNotFoundView so it won't flash ad the user will see the skeleton.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif 12 days overdue now... This issue's end is nigh!

[amyevans]

@aimane-chnaif can you prioritize another review of the PR please? It'd be nice to get this over the line

[melvin-bot]

@amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif eroding to Weekly issue.

[aimane-chnaif]

PR was deployed to production on Aug 24

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

Removed Reviewing so this will now go overdue.
@aimane-chnaif @amyevans who's due compensation here? I think it's $1k each to @aimane-chnaif and @kowczarz but wanna make sure.

@sakluger I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx

[aimane-chnaif]

@mallenexpensify I got already paid in #25587 for this GH review.
But am I eligible for more compensation fixing another issue as well? - #21567
They had different root causes but PR fixed both issues

[amyevans]

I think @aimane-chnaif is due reporter bonus here still, $250. @kowczarz is an agency contributor so not compensated via Upwork.

But am I eligible for more compensation fixing another issue as well? - #21567

Hmm I don't think so unless it dramatically increased the scope. There was no proposal review process or 2nd PR to review/test. We'd just compensate for the separate bug report there, which looks like that already happened on the GH.

[sakluger]

I agree with @amyevans, if the two bugs had the same root cause and were fixed with one PR, then we would only pay for that fix once.

@amyevans since I'm just coming into this issue now, what payments are due here? Just the reporting bonus?

[aimane-chnaif]

$250 (reporting) is due for me

[amyevans]

@sakluger yep, reporting bonus

[melvin-bot]

@sakluger, @amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too...

[mallenexpensify]

@aimane-chnaif can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01ab002e55737f23b6

[sakluger]

All paid and done, thanks everyone!