-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not Found view briefly appears on workspace members and invite pages #19236
Comments
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
@jczekalski please comment on the issue so I can assign you |
This issue is fixed by this PR: #18967 |
That doesn't fix the issue completely. We should show skeleton instead of full screen loading |
ProposalPlease re-state the problem that we are trying to solve in this issue.Open workspace members or invite page from deep link and have flash of "Not Found" view What is the root cause of that problem?In here
We're showing Not Found page if the this.props.policy is empty. When we navigate to the Workspace Settings page by link and login, the policy wasn't loaded yet (using the OpenApp API), so it shows Not Found briefly until the policy is loaded.
What changes do you think we should make in order to solve the problem?Base on @aimane-chnaif's comment, we need to build
What alternative solutions did you explore? (Optional)NA |
I'm an expert contributor from Software Mansion and I'd like to investigate this issue (@amyevans). |
@amyevans, @mallenexpensify, @jczekalski, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@jczekalski can you provide an update? Do you plan to post a proposal soon? |
@mallenexpensify Sorry for the delay, we decided to reassign this task to a new developer who just joined the team. They just started working on it today. |
Hey, I'm from Software Mansion, I'd like to work on this job. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@kowczarz Just a heads up I added you to our Upwork whitelist, so in a few days (once it deploys), Melvin should stop asking you for your Upwork details whenever you comment on a GH 😄 |
FYI: I'll be OOO tomorrow and Monday. |
Currently the app displays loading indicator instead of not found view and then shows skeleton placeholder. Should we keep current behaviour, or should we modify it so the app will instantly show the skeleton placeholder? Screen.Recording.2023-05-26.at.16.59.35_H.265.mp4 |
@kowczarz to be consistent with other pages, should show skeleton before loading data |
ProposalPlease re-state the problem that we are trying to solve in this issue.To be consistent with other pages, we should show skeleton instead of full page activity indicator. What is the root cause of that problem?We have two different UI states during the loading of the workspace invite screen - first full page activity indicator, then skeleton flashes for a moment What changes do you think we should make in order to solve the problem?In What alternative solutions did you explore? (Optional)NA |
@amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif 12 days overdue now... This issue's end is nigh! |
@aimane-chnaif can you prioritize another review of the PR please? It'd be nice to get this over the line |
@amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif 12 days overdue. Walking. Toward. The. Light... |
This issue has not been updated in over 14 days. @amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif eroding to Weekly issue. |
PR was deployed to production on Aug 24 |
Triggered auto assignment to @sakluger ( |
Bug0 Triage Checklist (Main S/O)
|
Removed @sakluger I'm off this week, can you please keep 👀 on this then I'll snag it back on Monday? Thx |
@mallenexpensify I got already paid in #25587 for this GH review. |
I think @aimane-chnaif is due reporter bonus here still, $250. @kowczarz is an agency contributor so not compensated via Upwork.
Hmm I don't think so unless it dramatically increased the scope. There was no proposal review process or 2nd PR to review/test. We'd just compensate for the separate bug report there, which looks like that already happened on the GH. |
$250 (reporting) is due for me |
@sakluger yep, reporting bonus |
@sakluger, @amyevans, @mallenexpensify, @kowczarz, @aimane-chnaif Eep! 4 days overdue now. Issues have feelings too... |
@aimane-chnaif can you please accept the job and reply here once you have? |
All paid and done, thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
This is a follow up issue from #17349 (comment)
Action Performed:
Open workspace members or invite page from deep link
Expected Result:
No flash of "Not Found" view
Actual Result:
Flash of "Not Found" view
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
invite.mov
members.mov
Expensify/Expensify Issue URL:
Issue reported by: @aimane-chnaif
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: