-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Not Found view briefly appears on workspace members and invite pages #21387
Fix Not Found view briefly appears on workspace members and invite pages #21387
Conversation
6e37201
to
dabe418
Compare
@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
dabe418
to
1d3e389
Compare
@kowczarz is this ready for review? |
@aimane-chnaif yes |
1d3e389
to
7eedc57
Compare
@aimane-chnaif Can you help out with this review? |
yes |
@aimane-chnaif any update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workspace invite page looks good.
As GH title says, let's fix workspace members page as well.
One more thing to consider: What content will show if |
7eedc57
to
406c600
Compare
@aimane-chnaif I applied requested changes. |
members.mov@kowczarz let's add skeleton in Members page. These conditions are to check if members list is not loaded yet
|
I have concern about skeleton design on Workspace members page, as it's a bit different from other option list item. |
Hmm. My initial reaction is that the existing skeleton is close enough, but I definitely defer to @shawnborton's opinion if he disagrees 😄 |
Yeah I also agree that the existing skeleton is close enough. |
72c6764
to
2228f79
Compare
@aimane-chnaif done. |
@kowczarz please add workspace members page to QA Steps and videos |
@kowczarz Please address @aimane-chnaif's comment here. Let's get this merged asap since it looks like it keeps conflicting! |
2228f79
to
6a57369
Compare
99928b0
to
f6348b8
Compare
@aimane-chnaif fixed, I had overwritten my git config and I didn't spot it. |
Offline behavior on members page before loading members list I am not sure which one is expected to show:
@amyevans any suggestion? |
Hmm I could see a case made for either, but I think the skeleton is fine, I'd consider it a slightly more accurate representation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @amyevans all yours
🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #25587. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.56-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀
|
Details
Fixed Issues
$ #19236
PROPOSAL: #19236(COMMENT)
Tests
http
withnew-expensify
)Offline tests
Same as above
QA Steps
http
withnew-expensify
)PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-06-23.at.11.56.53.mov
web.members.mov
Mobile Web - Chrome
android.web.members.mov
Mobile Web - Safari
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-23.at.14.38.43.mp4
ios.web.members.mp4
Desktop
Screen.Recording.2023-06-23.at.14.36.24.mov
desktop.members_H.265.mp4
iOS
Untitled.mp4
Android
Screen.Recording.2023-06-27.at.14.59.18.mov
android.members.mov