Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awaiting C+ payment confo] [HOLD for payment 2023-10-12] [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. #19342

Closed
6 tasks done
kavimuru opened this issue May 20, 2023 · 68 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@kavimuru
Copy link

kavimuru commented May 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Requested money from a user, which created a new report for that request.
  2. Clicked on the avatar in the header of the Money Request/Owes chat.
  3. Observed that clicking on the avatar does not open it, despite the expected behavior of avatars opening on click in other chats.

Expected Result:

When the avatar positioned in the header is clicked, it should open.

Actual Result:

The avatar positioned in the header cannot be opened when clicked.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.16.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

20230517_232040.mp4
Recording.680.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684347603337849

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0156545f23df45ccab
  • Upwork Job ID: 1660793182204600320
  • Last Price Increase: 2023-05-29
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 20, 2023

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@PrashantMangukiya
Copy link
Contributor

Proposal

Posting proposal early as per new guidelines

Please re-state the problem that we are trying to solve in this issue.

The avatar located in the header of the Money Request/Owes chat is not opening on click.

What is the root cause of that problem?

1) Money request payer header is rendering via <HeaderWithCloseButton> component at line 91 as shown below.

<HeaderWithCloseButton
shouldShowAvatarWithDisplay

Eventually src/components/HeaderWithCloseButton.js is rendering <AvatarWithDisplayName> via code below:

<AvatarWithDisplayName
report={this.props.report}
policies={this.props.policies}
personalDetails={this.props.personalDetails}
/>

We can see there is no pressable used with AvatarWithDisplayName. So it will not open details page when clicked.

2) Money request payee header render via line 120 as shown code below:

<Text
style={[styles.headerText, styles.pre]}
numberOfLines={1}
>
{payeeName}
</Text>

This is also not using pressable, so it will not open details page when clicked.

So this is the root cause the problem that both payer and payee header not clickable.

What changes do you think we should make in order to solve the problem?

To solve this we have to wrap Payer and Payee header text with Pressable.

1) How to make Payer header clickable:
From App/src/components/MoneyRequestHeader.js we have to pass new prop as onAvatarWithDisplayPress to HeaderWithCloseButton component as shown code below.

<HeaderWithCloseButton
   shouldShowAvatarWithDisplay 
    onAvatarWithDisplayPress={() => {
        Navigation.navigate(ROUTES.getDetailsRoute(moneyRequestReport.ownerEmail))
    }}
    ...
/>

Thereafter within src/components/HeaderWithCloseButton.js wrap <AvatarWithDisplayName> at line 170 with Pressable and set onPress to this.props.onAvatarWithDisplayPress as shown code below:

{this.props.shouldShowAvatarWithDisplay && (
    <Pressable onPress={this.props.onAvatarWithDisplayPress}>
        <AvatarWithDisplayName
            ...
        />
    </Pressable>
)}

2) How to make Payee header clickable:
Within src/components/MoneyRequestHeader.js at line 120 wrap Text component with pressable as shown below:

<Pressable
    onPress={() => {
        Navigation.navigate(ROUTES.getDetailsRoute(moneyRequestReport.managerEmail))
    }}
>
    <Text
        ...
    >
        {payeeName}
    </Text>
</Pressable>

So this will make both Payer and Payee clickable as shown in result video.

What alternative solutions did you explore? (Optional)

None

Result
Web.mov

@melvin-bot
Copy link

melvin-bot bot commented May 20, 2023

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@adelekennedy adelekennedy removed the Bug Something is broken. Auto assigns a BugZero manager. label May 22, 2023
@adelekennedy adelekennedy removed their assignment May 22, 2023
@adelekennedy adelekennedy added the Bug Something is broken. Auto assigns a BugZero manager. label May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@strepanier03 strepanier03 added the External Added to denote the issue can be worked on by a contributor label May 22, 2023
@melvin-bot melvin-bot bot changed the title The avatar located in the header of the Money Request/Owes chat is not opening on click. [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0156545f23df45ccab

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

Triggered auto assignment to @grgia (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@huzaifa-99
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the avatar and email/name of the user to open details when clicked in a money request report

What is the root cause of that problem?

Currently we don't have logic in place to handle this interaction.

What changes do you think we should make in order to solve the problem?

  1. We have to wrap this block with a Pressable and on press we will navigate to the report owner email.
<Pressable
    onPress={() => Navigation.navigate(ROUTES.getDetailsRoute(props.report.ownerEmail))}

>
// ... the block will be wrapped here
</Pressable>
  1. Similar to before, we have to wrap this block with a Pressable and on press we will navigate to the report manager email.
<Pressable
    onPress={() => Navigation.navigate(ROUTES.getDetailsRoute(moneyRequestReport.managerEmail))}

>
// ... the block will be wrapped here
</Pressable>

In both of the Pressable above we have to apply some styles style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]} similar to how we do in 1-1 reports here

style={[styles.flexRow, styles.alignItemsCenter, styles.flex1]}

What alternative solutions did you explore? (Optional)

N/A

@fedirjh
Copy link
Contributor

fedirjh commented May 24, 2023

Reviewing today

@aimane-chnaif
Copy link
Contributor

Coming from #19332, I think this is expected for now.
Tagging money request design experts: @shawnborton @trjExpensify @mountiny @Julesssss

@mountiny
Copy link
Contributor

I am not sure honestly, I think we should allow this as its bringing confusing inconsistency to the user if they can click on this in other places in the app. Also it should not be any problem from the coding perspective I believe.

@Julesssss
Copy link
Contributor

I think both of these statements are true:

  • Because the profile image is not clickable, this is not a bug
  • A valid feature request is to make the avatar clickable

@mountiny
Copy link
Contributor

I would say it was just an oversight from our initial implementation but we can call it a feature request 😂

@strepanier03
Copy link
Contributor

@mountiny @Julesssss - I'm good with that approach. I can't find much documentation about how the BZ should handle feature requests in E/App, so in this case can we let proposals roll in and choose the one that works or does this need to be handled internally?

@Julesssss
Copy link
Contributor

Julesssss commented May 25, 2023

Hey @strepanier03, yeah the process is pretty much identical from here on.

@fedirjh please go ahead with proposal review when you're ready.

Just realised I'm not the assignee, my bad.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. @shawnborton, @trjExpensify, @fedirjh, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@trjExpensify
Copy link
Contributor

PR is in review melvin, chiiill. Should be unheld now after the merge freeze.

@trjExpensify trjExpensify added Weekly KSv2 and removed Monthly KSv2 labels Sep 11, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. [HOLD for payment 2023-10-12] [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 11, 2023
@trjExpensify
Copy link
Contributor

trjExpensify commented Oct 13, 2023

Okay, so by my calculations:

Everyone agree? Let me know and I'll start settling up! :)

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@fedirjh
Copy link
Contributor

fedirjh commented Oct 13, 2023

Everyone agree? Let me know and I'll start settling up! :)

I think it's :

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@trjExpensify
Copy link
Contributor

Ah yes, this PR for ref. Cool, amended.

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@trjExpensify
Copy link
Contributor

@fedirjh paid!

@usmantariq96
Copy link

@trjExpensify offer accepted
Thanks

@trjExpensify
Copy link
Contributor

@usmantariq96 paid! 👍

Once @allroundexperts confirms he's requested, I'll close.

@trjExpensify trjExpensify changed the title [HOLD for payment 2023-10-12] [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. [Awaiting C+ payment confo] [HOLD for payment 2023-10-12] [$1000] The avatar located in the header of the Money Request/Owes chat is not opening on click. Oct 17, 2023
@allroundexperts
Copy link
Contributor

Requested. This can be closed now @trjExpensify!

@trjExpensify
Copy link
Contributor

Perfect!

@JmillsExpensify
Copy link

$1,000 payment approved for @allroundexperts based on this summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests