[HOLD for payment - C+ only] [$1000] Workspace - Remove button is displayed active upon selecting admin to be deleted from workspace

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1, Login to NewDot
2. Go to Workspace -> Members -> Invite
3. Select admin account

Expected Result:

Remove button should not look active

Actual Result:

Remove button is displayed active upon selecting admin to be deleted from workspace

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6091696_video_58.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b6a900eb33013827
• Upwork Job ID: 1669443164980342784
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Nikhil-Vats]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In workspace members page, the remove button is active when admin/logged in user is selected for removal which is not allowed.

What is the root cause of that problem?

The remove button is disabled only when there are no selected members. The condition for checking if admin/logged in user is selected is not added.

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 454 to 461 in b089bde

	<Button
	medium
	danger
	style={[styles.ml2]}
	isDisabled={this.state.selectedEmployees.length === 0}
	text={this.props.translate('common.remove')}
	onPress={this.askForConfirmationToRemove}
	/>

What changes do you think we should make in order to solve the problem?

We need to add a new condition here to disable the button when either the logged in user or admin or both are selected. For that, we can use the following condition -

isDisabled={this.state.selectedEmployees.length === 0 || _.some(this.state.selectedEmployees, member => member === this.props.policy.owner || member === this.props.session.email)}

We can create a new function for this to make it more readable.

What alternative solutions did you explore? (Optional)

NA

[dukenv0307]

Currently, We are facing this bug. My proposal will work well after this issue is resolved

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Remove button is displayed active upon selecting admin to be deleted from workspace

What is the root cause of that problem?

App/src/pages/workspace/WorkspaceMembersPage.js

Line 458 in 23978e4

isDisabled={this.state.selectedEmployees.length === 0}

We are checking that if this.state.selectedEmployees.length === 0 we will disable the remove button

What changes do you think we should make in order to solve the problem?

We also should disable remove button if there is any error like that

   isDisabled={(this.state.selectedEmployees.length === 0) || !_.isEmpty(this.state.errors)}

It is similar to the check we did when clicking the remove button

App/src/pages/workspace/WorkspaceMembersPage.js

Lines 197 to 200 in 862955c

	askForConfirmationToRemove() {
	if (!_.isEmpty(this.state.errors)) {
	return;
	}

Result

Screen.Recording.2023-06-14.at.14.32.15.mov

[NicMendonca]

@kbecciv just to confirm, under the Expected Result you say that the remove should look active, but it should be that it should not display as active?

[kbecciv]

@NicMendonca Corrected, sorry for confusion

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b6a900eb33013827

[melvin-bot]

Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[rn-senior-developer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace/Memeber - Remove button is displayed active upon selecting admin to be deleted from workspace

What is the root cause of that problem?

Remove buttons isDisabled property was active when user selected any users. It was not checked user role

App/src/pages/workspace/WorkspaceMembersPage.js

Line 458 in 23978e4

isDisabled={this.state.selectedEmployees.length === 0}

What changes do you think we should make in order to solve the problem?

We should check if admin is selected.
isDisabled={this.state.selectedEmployees.length === 0 || this.state.isSelectedAdmin}
To do this, I added isSelectedAdmin state.
isSelectedAdmin: false

And I passed the roleparameters in toggleUser event function, and set and reset isSelectedAdmin field when user select users on members list.

<Checkbox isChecked={isChecked} onPress={() => this.toggleUser(item.accountID, item.pendingAction, item.role)} />
....

onSelectRow={() => this.toggleUser(item.accountID, item.pendingAction, item.role)}

`toggleUser(accountID, pendingAction, role) {
if (pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
return;
}

    // Add or remove the user if the checkbox is enabled
    if (_.contains(this.state.selectedEmployees, Number(accountID))) {
        this.removeUser(Number(accountID));
        if (role === 'admin') {
            this.setState({ isSelectedAdmin : false})
        }
    } else {
        this.addUser(Number(accountID));
        if (role ==='admin') {
            this.setState({ isSelectedAdmin : true })
        }
    }
}`

And then, update the remove button's disabled props:

isDisabled={this.state.selectedEmployees.length === 0 || this.state.isSelectedAdmin}

What alternative solutions did you explore? (Optional)

Maybe, I can use session value to check if admin user selected.

Result Video

Screen.Recording.2023-06-15.at.5.36.45.PM.mov

[melvin-bot]

📣 @jaytechfulldev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rn-senior-developer]

Contributor details
Your Expensify account email: samcheng955@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0192fff62d8b797dad

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[sobitneupane]

Thanks for proposal everyone.

Proposal from @dukenv0307 looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[cead22]

@sobitneupane @NicMendonca the proposal from @dukenv0307 looks good, but it doesn't feel like a complete solution, because we'll end up with a checkbox for the admin that doesn't do anything, and that isn't checked when Select All is checked, and that alone feels like a bug.

I think it would be better if we didn't show a checkbox for the admin, or if we showed it disabled. What do you think? cc @shawnborton

[rn-senior-developer]

@cead22 Can you check my proposal? I checked if Admin selected and even if user checked "All".

[shawnborton]

I like the idea of showing it disabled.

[dukenv0307]

@shawnborton @cead22 A little curios, if we always disable the admin checkbox, Users won't know why can't click the checkbox. Currently, when clicking the admin checkbox we are showing an error message to to notify to user

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[NicMendonca]

@Christinadobrzyn I am going OOO until Wednesday. Can you watch this while I am away? I'll unassign you when I am back. Thank you!

[Christinadobrzyn]

Looks like we're reviewing the PR moving this to weekly

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @dukenv0307 got assigned: 2023-06-23 17:53:55 Z
• when the PR got merged: 2023-06-28 18:58:23 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Disable admin checkbox and checkbox all #21375

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#14347

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#14347 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This was a design decision to allow users to select admin back then. So, I don't think this could have been caught earlier.

• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

[sobitneupane]

Regression Test Proposal

1. Go to Settings> Workspaces
2. Select any workspace > Members
3. Try to select admin from the list.
4. Verify that disabled cursor is displayed while hovering over the admin and admin cannot be selected.

Do we agree 👍 or 👎

[sobitneupane]

Payment Requested on Expensify.

[NicMendonca]

@dukenv0307 can you please apply to the job?

[dukenv0307]

@NicMendonca I applied, thank you!

[NicMendonca]

@dukenv0307 you've been paid!

[NicMendonca]

@sobitneupane keep us posted!

[NicMendonca]

as per this SO, I can close! @sobitneupane you'll be paid shortly!