[$1000] Web - Not Allowed sign when hovering through the reaction list

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Action Performed:

1. Go to chat with previous messages.
2. go to any message hover over the reaction list and notice that there is no 'Not Allowed' sign showing up.
3. Now click the message body and hover over the reaction list again. notice there is a 'Not Allowed' sign showing up.

Expected Result:

No 'Not Allowed' sign showing up.

Actual Result:

The 'Not Allowed' sign showing up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.31.2

Reproducible in staging?: yes

Reproducible in production?: no

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Hover.Error-1.1.mp4

Recording.3222.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daveSeife

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687467815718419

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018e36cd61ebc57ae7
• Upwork Job ID: 1672048109219315712
• Last Price Increase: 2023-06-23

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[cubuspl42]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a message in the chat is clicked, its reaction modal starts triggering the "not allowed" cursor when the space between reactions is hovered.

What is the root cause of that problem?

A recent change uncovered a bug in PressableWithFeedback.

onPress is not a required property, but it was treated like it was. If a PressableWithFeedback instance was pressed (clicked) but onPressed was undefined, an exception was thrown. Consequently, the logic to re-enable the component (meant for the case when props.onPressed returns a promise) wasn't fired and it was left in the disabled state.

A disabled pressable has the not-allowed cursor.

ReportActionItem isn't providing onPress to PressableWithSecondaryInteraction (which forwards it to PressableWithFeedback). ReportActionItem's PressableWithSecondaryInteraction is an ancestor to the reaction picker, so the space between the reaction entries inherits the cursor style.

What changes do you think we should make in order to solve the problem?

We should refactor the onPress callback passed to GenericPressable in PressableWithFeedback so it works correctly in all cases:

• when props.onPress is not provided (it's undefined)
• when props.onPress is provided and it's async (it returns a Promise)
• when props.onPress is provided and it's not async (it returns something else, presumably undefined)

A simple implementation that satisfies these requirements could look like this:

onPress={(e) => {
    if (!props.onPress) return;

    const onPressResult = props.onPress(e);
    if (onPressResult instanceof Promise) {
        setDisabled(true);
        InteractionManager.runAfterInteractions(() => {
            onPressResult.finally(() => {
                setDisabled(props.disabled);
            });
        });
    }
}}

[jasperhuangg]

Removing deploy blocker label since I don't think we need to block deploy on such a minor issue. It seems you can still react to comments so it doesn't actual break any existing behavior.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018e36cd61ebc57ae7

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

📣 @cubuspl42 You have been assigned to this job by @jasperhuangg!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[situchan]

I think this was already fixed in #21341

[cubuspl42]

@situchan
Oh, thanks for spotting that

I would argue that the bug I described in my root cause analysis is still there in some form. If props.onPress throws, the component would again lock itself in the disabled state. The implementation is also unnecessarily complex and bug-prone, firing runAfterInteractions for simple cases when onPress is not async.

[jasperhuangg]

Hmmm after retesting I agree that it was fixed in that other PR. This is a pretty minor flow that doesn't affect behavior so I'm gonna close it out. Thanks for your understanding @cubuspl42