-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Web - Not Allowed sign when hovering through the reaction list #21354
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @jasperhuangg ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.When a message in the chat is clicked, its reaction modal starts triggering the "not allowed" cursor when the space between reactions is hovered. What is the root cause of that problem?A recent change uncovered a bug in
A disabled pressable has the
What changes do you think we should make in order to solve the problem?We should refactor the
A simple implementation that satisfies these requirements could look like this: onPress={(e) => {
if (!props.onPress) return;
const onPressResult = props.onPress(e);
if (onPressResult instanceof Promise) {
setDisabled(true);
InteractionManager.runAfterInteractions(() => {
onPressResult.finally(() => {
setDisabled(props.disabled);
});
});
}
}} |
Removing deploy blocker label since I don't think we need to block deploy on such a minor issue. It seems you can still react to comments so it doesn't actual break any existing behavior. |
Job added to Upwork: https://www.upwork.com/jobs/~018e36cd61ebc57ae7 |
Triggered auto assignment to @trjExpensify ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
📣 @cubuspl42 You have been assigned to this job by @jasperhuangg! |
I think this was already fixed in #21341 |
@situchan I would argue that the bug I described in my root cause analysis is still there in some form. If |
Hmmm after retesting I agree that it was fixed in that other PR. This is a pretty minor flow that doesn't affect behavior so I'm gonna close it out. Thanks for your understanding @cubuspl42 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Action Performed:
Expected Result:
No 'Not Allowed' sign showing up.
Actual Result:
The 'Not Allowed' sign showing up.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.31.2
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Hover.Error-1.1.mp4
Recording.3222.mp4
Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687467815718419
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: