Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-06-22 #21330

Closed
39 tasks done
OSBotify opened this issue Jun 22, 2023 · 14 comments
Closed
39 tasks done

Deploy Checklist: New Expensify 2023-06-22 #21330

OSBotify opened this issue Jun 22, 2023 · 14 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 22, 2023

Release Version: 1.3.31-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@luacmartins luacmartins self-assigned this Jun 22, 2023
@luacmartins luacmartins added the Daily KSv2 label Jun 22, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 22, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.31-1 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.31-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.31-2 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

luacmartins commented Jun 23, 2023

Checking off #21351 and #21354 since they've been demoted.

@luacmartins
Copy link
Contributor

We have a fix for #21393, but it needs to be CPed and that's currently broken - see

@luacmartins
Copy link
Contributor

Checked off #20934 since it's an old issue and it was accidentally reopened

@luacmartins
Copy link
Contributor

Checking off #21393 since the latest CP fixes it.

@mvtglobally
Copy link

@luacmartins regression is almost completed

PR #20738 is failing #21428
PR #20772 is blocked on Desktop and Native apps. Ok to check off?
PR #20817 is failing #21414. Repro in prod checking off
PR #20996 is failing #21393 & #18658
#21339
#21310 is failing #21392. Repro in prod

@mvtglobally
Copy link

@luacmartins regresion is completed

@luacmartins
Copy link
Contributor

Checking off #20772 since we only need to test on web.

@luacmartins
Copy link
Contributor

Left a comment on #20996. Gonna check it off since it doesn't impact App functionality.

@luacmartins
Copy link
Contributor

Checking off #20738, since it got reverted.

@luacmartins
Copy link
Contributor

I manually updated the checklist version to 1.3.31-3 since it didn't update after this CP. Checklist is clear. Kicking off the deploy.

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants