[HOLD for payment 2023-10-18] [$1000] Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Pre-step: Go to any room that you have permission to update welcome message => Go to Room welcome message paste => Copy the URL => Paste to any chat report

1. Click on the link that you just paste
2. Verify that it open the Room welcome message page
3. Click save button

Expected Result:

It navigates back to Room setting page

Actual Result:

It navigates back to the chat report page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.35-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Desktop.2023.06.30.-.20.55.42.10.mp4

Screen.Recording.2023-06-30.at.19.02.10.mov

Expensify/Expensify Issue URL:
Issue reported by: @hoangzinh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688126512179099

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e35dd505b57309c2
• Upwork Job ID: 1684161543399026688
• Last Price Increase: 2023-07-26
• Automatic offers:
• situchan | Reviewer | 26196235
• hoangzinh | Contributor | 26196236
• hoangzinh | Reporter | 26196237

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page

What is the root cause of that problem?

In the action to save the Room's welcome message, we just call Navigation.goBack

App/src/libs/actions/Report.js

Line 1142 in 0bbf3fc

Navigation.goBack();

When we visit the page by direct link, the previous history page is empty => It will navigate to the chat report by default.

What changes do you think we should make in order to solve the problem?

We should add fallbackRoute of room setting page for Navigation.goBack here

Navigation.goBack(ROUTES.getReportSettingsRoute(reportID));

So it will navigate to the room setting route when there is no active routes

What alternative solutions did you explore? (Optional)

Instead of call Navigation.goBack, we can call Navigation.navigate directly to the room setting route here

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page

What is the root cause of that problem?

In the action to save the Room's welcome message, we just call Navigation.goBack

App/src/libs/actions/Report.js

Line 1142 in 0bbf3fc

Navigation.goBack();

When we visit the page by direct link, the previous history page is empty => It will navigate to the chat report by default.

What changes do you think we should make in order to solve the problem?

We should add fallbackRoute of room setting page for Navigation.goBack here

Navigation.goBack(ROUTES.getReportSettingsRoute(reportID));

So it will navigate to the room setting route when there is no active routes

What alternative solutions did you explore? (Optional)

Instead of call Navigation.goBack, we can call Navigation.navigate directly to the room setting route here

[dylanexpensify]

hmmm, posting to get a check on if this is intentional

[dylanexpensify]

Not a bug here

[hoangzinh]

@dylanexpensify, but when we visit Room welcome message edit page direct link, after click save button, it closes the RHN. It think it's an unexpected behavior. It should back to the room setting

[hoangzinh]

Bump @dylanexpensify ^

[greg-schroeder]

Seems there are multiple issues being reported around this and so I've closed the dupes and reopened this as this was the original. I checked the convo in Slack but it doesn't seem like we hadn't any engagement from the team. Should we re-bump about this @dylanexpensify?

[melvin-bot]

@dylanexpensify this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[dylanexpensify]

Agree @greg-schroeder, will bump!

[dukenv0307]

Linking my proposal here from one of the dupe issues that was closed, it will fix all these cases as well. I'll post it again here to follow the proper format once we agree we want to fix it.

[s77rt]

In case we ended fixing this, please make the fix global, we have the same issue reported for different pages.

[situchan]

#26710 was deployed to production.
@hoangzinh can you please update PR based on latest codebase?

[hoangzinh]

yes, let me update it.

[dylanexpensify]

Nice! @hoangzinh did we get this sorted? cc @situchan

[hoangzinh]

@dylanexpensify yeah, @situchan and I have started code review again since yesterday #25543 (comment)

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hoangzinh got assigned: 2023-08-18 12:15:33 Z
• when the PR got merged: 2023-10-06 10:26:05 UTC
• days elapsed: 34

On to the next one 🚀

[dylanexpensify]

Great! @situchan @hoangzinh what's our ETA on wrapping this up/

[situchan]

PR hit staging yesterday. Maybe around Oct 19 will be payment date

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix incorrect navigation when update Report welcome message after visit by direct link #25543

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)
• @hoangzinh requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh / @situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh / @situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh / @situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh / @situchan] Determine if we should create a regression test for this bug.
• [@hoangzinh / @situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment upcoming!

[Beamanator]

how we doin here? 🙏

[Beamanator]

We good here @dylanexpensify ?

[hoangzinh]

@Beamanator waiting for BZ checklist and payout here.

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: This is not normal user flow and always existed from the beginning.
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1690915949087489
• Determine if we should create a regression test for this bug. In [HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs #24291, we made fallback route necessary for navigation goBack method. I think this will help preventing similar bugs in the future.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. I have same thought as [HOLD for payment 2023-10-02] [$1000] Add a mandatory route param to Navigation.goBack to prevent bugs #24291 (comment)

[dylanexpensify]

done!