Fix incorrect navigation when update Report welcome message after visit by direct link #25543

hoangzinh · 2023-08-20T13:31:43Z

Details

Fixed Issues

$ #22041
PROPOSAL: #22041 (comment)

Tests

Test case 1: Report welcome message page
Pre-step: Go to any room that you have permission to update welcome message => Go to Room welcome message paste => Copy the URL => Paste to any chat report

Click on the report welcome message link that you just paste
Update the welcome message
Click save button
Verify that it navigations back to the Report setting page

Test case 2: Workspace invite message page
Pre-step: Go to any Workspace, invite any users => On invite message paste => Copy the URL => Paste to any chat report

Click on the WS invite message link that you just paste
Click back arrow in the top bar
Verify that it navigations back to the WS invite member page

Verify that no errors appear in the JS console

Offline tests

Not affected by network

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-20.at.22.53.04.-.web.mp4

Test ReimbursementAccount - Enabled page

Screen.Recording.2023-10-02.at.06.24.10.-.web.mov

Mobile Web - Chrome

Screen.Recording.2023-08-23.at.17.51.05.-.android.chrome.mov

Mobile Web - Safari

Screen.Recording.2023-08-23.at.17.53.37.-.ios.safari.mov

Desktop

Screen.Recording.2023-08-20.at.23.01.21.-.desktop.mp4

iOS

Screen.Recording.2023-08-23.at.17.54.24.-.ios.mov

Android

Screen.Recording.2023-08-23.at.17.52.20.-.android.mov

hoangzinh · 2023-08-21T22:59:54Z

@situchan when I test the "Test case 2". There is a regression bug if we add fallback route, it's loop navigation if we tap on the arrow back on the top bard on native devices

Screen.Recording.2023-08-22.at.05.57.22.mov

I think we can revert the change for this "Test case 2" and leave as it's. What do you think?

situchan · 2023-08-22T20:18:57Z

@situchan when I test the "Test case 2". There is a regression bug if we add fallback route, it's loop navigation if we tap on the arrow back on the top bard on native devices

Screen.Recording.2023-08-22.at.05.57.22.mov
I think we can revert the change for this "Test case 2" and leave as it's. What do you think?

Agree, revert this change as it works as expected already

So you fixed 2 pages so far - workspace invite message, welcome message.
Are you sure that no other occurrences throughout the app?

This reverts commit 10de61c.

melvin-bot · 2023-08-23T10:58:00Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2023-08-23T11:00:58Z

Are you sure that no other occurrences throughout the app?

I tried to search Navigation.goBack() occurrences through the codebase and found 2 places above. Other places seem expectations with empty fallback route like pop current route out of history.

App/src/pages/workspace/WorkspaceInviteMessagePage.js

Lines 124 to 126 in 4f412db

    
           // Pop the invite message page before navigating to the members page. 
        
           Navigation.goBack(); 
        
           Navigation.navigate(ROUTES.getWorkspaceMembersRoute(this.props.route.params.policyID));

situchan · 2023-08-23T11:30:54Z

@hoangzinh we should fix all possible cases even though Navigation.goBack is not defined.
HeaderWithBackButton's onBackButtonPress callback returns Navigation.goBack() as default.
i.e.
#22887 was closed in favor of our issue.

hoangzinh · 2023-08-24T17:11:27Z

@situchan I tried to add more places that I think it's missing fallback route. Regarding the bug that you mentioned #22887. I think we can't fix it by filling the fallback route. In that bug, we're in the user profile, refresh the page, we wouldn't know what is the previous page that we visited. We might need to fix that issue by suggestion here https://expensify.slack.com/archives/C01GTK53T8Q/p1691912177038759, the backTo route

hoangzinh · 2023-08-27T14:15:35Z

@situchan bump for code review. Are we good with PR so far?

situchan · 2023-08-30T12:26:31Z

src/pages/ReportParticipantsPage.js

+                <FullPageNotFoundView
+                    shouldShow={_.isEmpty(props.report) || ReportUtils.isArchivedRoom(props.report)}
+                    onBackButtonPress={() => Navigation.goBack(ROUTES.getReportRoute(props.report.reportID))}
+                >
                    <HeaderWithBackButton
                        title={props.translate(


There are still missing cases.
i.e. Header back button should go to Report Details page

Screen.Recording.2023-08-31.at.19.40.39.mov

If we fallback to navigate to report details page, it will cause regression in group report case.

situchan · 2023-08-30T14:56:48Z

Please request review when all feedback is addressed.

@hoangzinh we should fix all possible cases even though Navigation.goBack is not defined. HeaderWithBackButton's onBackButtonPress callback returns Navigation.goBack() as default.

I clearly stated that we should find & fix all occurrences of HeaderWithBackButton.

Btw, I am not able to review this sooner so gonna ask another C+ for help

hoangzinh · 2023-08-30T15:55:15Z

Please request review when all feedback is addressed.

@hoangzinh we should fix all possible cases even though Navigation.goBack is not defined. HeaderWithBackButton's onBackButtonPress callback returns Navigation.goBack() as default.

I clearly stated that we should find & fix all occurrences of HeaderWithBackButton.

Btw, I am not able to review this sooner so gonna ask another C+ for help

@situchan just wanna clear that, if some cases that I think we should leave Navigation.goBack as it is, I should call with Navigation.goBack(ROUTES.HOME)

situchan · 2023-08-30T16:21:09Z

@situchan just wanna clear that, if some cases that I think we should leave Navigation.goBack as it is, I should call with Navigation.goBack(ROUTES.HOME)

I feel more like we should hold this until #24291 is done.

hoangzinh · 2023-08-31T12:37:45Z

hi @situchan, I listed remaining pages that missing onBackButtonPress props + reason why I didn't update them. Could you review them again if I missed any things else.

EditRequestCreatedPage, EditRequestDescriptionPage, EditRequestMerchantPage, FlagCommentPage, ReportParticipantsPage, TaskDescriptionPage, TaskTitlePage=> let as it is, if we set the report URL as fallback it will cause regression loop navigation above
NewChatPage, SearchPage, SplitBillDetailsPage, InitialSettingsPage, WorkspaceNewRoomPage => Those page are fine, because should navigation back to previous/home page when it's opened.
WalletStatementPage => I'm unsure about that page, I couldn't found a entry point to go to this page.

hoangzinh · 2023-09-01T15:44:47Z

bump @situchan ^

situchan · 2023-09-01T15:47:48Z

Still inclined to hold this for now. And see how #24291 goes.

hoangzinh · 2023-09-30T16:26:00Z

@situchan Updated with latest main. Could you help to review this PR + my comment here #25543 (comment). Thanks

situchan · 2023-10-01T16:17:46Z

@situchan Updated with latest main. Could you help to review this PR + my comment here #25543 (comment). Thanks

I am good with #25543 (comment).
WalletStatementPage: https://staging.new.expensify.com/statements/202308

situchan · 2023-10-01T16:27:46Z

src/pages/ReimbursementAccount/EnableStep.js

@@ -63,6 +69,7 @@ function EnableStep(props) {
                subtitle={props.policyName}
                shouldShowGetAssistanceButton
                guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_BANK_ACCOUNT}
+                onBackButtonPress={() => Navigation.navigate(ROUTES.WORKSPACE_REIMBURSE.getRoute(props.policyID))}


This should be handled in parent component (ReimbursementAccountPage)

Suggested change

onBackButtonPress={() => Navigation.navigate(ROUTES.WORKSPACE_REIMBURSE.getRoute(props.policyID))}

onBackButtonPress={props.onBackButtonPress}

Thanks for the suggestion. Updated 4dbdfe2

situchan · 2023-10-06T07:09:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

Beamanator

LGTM!

OSBotify · 2023-10-06T10:32:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-09T23:02:55Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.80-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T04:43:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-11T05:12:06Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.81-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-13T22:01:11Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:13:14Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T22:29:27Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-13T23:04:52Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:16:32Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:52:52Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

hoangzinh added 3 commits August 20, 2023 17:48

Add fallback goBack route for update welcome message

02ca43b

Add fallback route for goBack on Invite message page

0e38071

Add fallback goBack on edit request description page

10de61c

Revert "Add fallback goBack on edit request description page"

62c2475

This reverts commit 10de61c.

hoangzinh marked this pull request as ready for review August 23, 2023 10:57

hoangzinh requested a review from a team as a code owner August 23, 2023 10:57

melvin-bot bot requested review from situchan and removed request for a team August 23, 2023 10:57

hoangzinh added 3 commits August 24, 2023 23:46

Add fallback route for goBack

e087c85

Merge branch 'main' into df/22041

a237069

Fix linter

e83b882

situchan reviewed Aug 30, 2023

View reviewed changes

hoangzinh added 2 commits August 31, 2023 16:02

Merge branch 'main' into df/22041

507f788

Add fallback goBack for Reimbursement enable step

721b2b2

hoangzinh mentioned this pull request Sep 1, 2023

[HOLD for payment 2023-10-18] [$1000] Visit the Room welcome message edit page by direct link then click save button, it navigates back to the chatReport instead of Room setting page #22041

Closed

6 tasks

hoangzinh added 2 commits September 30, 2023 06:03

Merge branch 'main' into df/22041

442d8a7

Fix linter

00c0089

hoangzinh added 2 commits September 30, 2023 23:22

Update use new route function

ea72f38

Revert changes

6c96f5d

situchan reviewed Oct 1, 2023

View reviewed changes

Lift-up handle onBackButtonPress in ReimbursementAccountPage

4dbdfe2

situchan approved these changes Oct 6, 2023

View reviewed changes

melvin-bot bot requested a review from Beamanator October 6, 2023 07:09

Beamanator approved these changes Oct 6, 2023

View reviewed changes

Beamanator merged commit f7ac376 into Expensify:main Oct 6, 2023
14 of 15 checks passed

OSBotify mentioned this pull request Oct 9, 2023

Deploy Checklist: New Expensify 2023-10-09 #29131

Closed

64 tasks

izarutskaya mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-25] [$500] iOS - WS Invite - Invite message link does not lead to invite message page #29163

Closed

6 tasks

OSBotify mentioned this pull request Oct 11, 2023

Deploy Checklist: New Expensify 2023-10-11 #29252

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect navigation when update Report welcome message after visit by direct link #25543

Fix incorrect navigation when update Report welcome message after visit by direct link #25543

hoangzinh commented Aug 20, 2023 •

edited

Loading

hoangzinh commented Aug 21, 2023

situchan commented Aug 22, 2023

melvin-bot bot commented Aug 23, 2023

hoangzinh commented Aug 23, 2023

situchan commented Aug 23, 2023

hoangzinh commented Aug 24, 2023

hoangzinh commented Aug 27, 2023

situchan Aug 30, 2023

hoangzinh Aug 31, 2023

situchan commented Aug 30, 2023

hoangzinh commented Aug 30, 2023

situchan commented Aug 30, 2023

hoangzinh commented Aug 31, 2023

hoangzinh commented Sep 1, 2023

situchan commented Sep 1, 2023

hoangzinh commented Sep 30, 2023

situchan commented Oct 1, 2023

situchan Oct 1, 2023

hoangzinh Oct 1, 2023

situchan commented Oct 6, 2023

situchan left a comment

Beamanator left a comment

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

	onBackButtonPress={() => Navigation.navigate(ROUTES.WORKSPACE_REIMBURSE.getRoute(props.policyID))}
	onBackButtonPress={props.onBackButtonPress}

Fix incorrect navigation when update Report welcome message after visit by direct link #25543

Fix incorrect navigation when update Report welcome message after visit by direct link #25543

Conversation

hoangzinh commented Aug 20, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

hoangzinh commented Aug 21, 2023

situchan commented Aug 22, 2023

melvin-bot bot commented Aug 23, 2023

hoangzinh commented Aug 23, 2023

situchan commented Aug 23, 2023

hoangzinh commented Aug 24, 2023

hoangzinh commented Aug 27, 2023

situchan Aug 30, 2023

Choose a reason for hiding this comment

hoangzinh Aug 31, 2023

Choose a reason for hiding this comment

situchan commented Aug 30, 2023

hoangzinh commented Aug 30, 2023

situchan commented Aug 30, 2023

hoangzinh commented Aug 31, 2023

hoangzinh commented Sep 1, 2023

situchan commented Sep 1, 2023

hoangzinh commented Sep 30, 2023

situchan commented Oct 1, 2023

situchan Oct 1, 2023

Choose a reason for hiding this comment

hoangzinh Oct 1, 2023

Choose a reason for hiding this comment

situchan commented Oct 6, 2023

Reviewer Checklist

Screenshots/Videos

situchan left a comment

Choose a reason for hiding this comment

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 11, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

hoangzinh commented Aug 20, 2023 •

edited

Loading