-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-07] [$1000] mWeb- Image is displayed larger then normal when we send vertical image with text on android chrome #22363
Comments
Triggered auto assignment to @sakluger ( |
Bug0 Triage Checklist (Main S/O)
|
Good find, we should fix this. |
Job added to Upwork: https://www.upwork.com/jobs/~01d1b35099ea0fe207 |
Current assignee @sakluger is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.mWeb- Image is displayed larger then normal when we send vertical image with text on android chrome. What is the root cause of that problem?We use window height for calculate the height of thumbnail. App/src/components/ThumbnailImage.js Line 65 in 3257e3e
But when keyboard shows, window height is smaller than normal. What changes do you think we should make in order to solve the problem?When we use a device with const upperHeight = DeviceCapabilities.canUseTouchScreen() ? Dimensions.get('screen').height : this.props.windowHeight;
let thumbnailScreenHeight = lodashClamp(imageHeight, 40, upperHeight * 0.4); We can modify |
reviewing today |
@rushatgabhane were you able to review yet? If not, could you please prioritize this one? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@sakluger @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Posted in #contributor-plus to make sure we can prioritize reviewing this issue. |
@sarious your proposal won't work when the window is resized on web |
Could I have a comment about my proposal #22363 (comment)? |
📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
I see. We can improve my proposal, and use
It looks similar to @ginsuma's proposal, but it seems that it's better to use window height. In @ginsuma proposal height of screen was used. But Window Height not equal to Screen Height, so the thumbnail height will be differ from initial (before fix). |
#23392 is ready for review.
On mWeb it's right. I know it that's why I said we could edit |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-07. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
|
Created a manual request - https://staging.new.expensify.com/r/530127434800510 |
Summarizing payouts for this issue: Bug reporter: @dhanashree-sawant $250 (hired and paid on Upwork) Upwork job: https://www.upwork.com/jobs/~01d1b35099ea0fe207 |
Paid everyone through Upwork, @JmillsExpensify and @anmurali passing the issue to you for C+ payment to Rushat via manual request. |
@sakluger you can close this issue because the payment will be tracked on new dot |
I believe that we need to wait until @JmillsExpensify or @anmurali comments that the payment is approved before we can close out the issue. @rushatgabhane let me know if I missed an announcement, but I think that's still the current process. |
Reviewed the details for @rushatgabhane. This is approved for payment on NewDot. |
Thanks! We're all set here. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should display image in normal size if we send the image along with text
Actual Result:
App displays image larger then normal if we send vertical image along with text
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.37-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
larger.then.normal.image.sent.with.text.android.chrome.mp4
Screen_Recording_20230706_143639_Chrome.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688634116891079
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: