-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-17] [$1000] Dev: After creating a task without assignee “0” displayed #22398
Comments
Triggered auto assignment to @MitchExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @MariaHCD ( |
FYI I kicked off the release less than 5 minutes ago and I'm worried the existence of a new deploy blocker will cause issues. I'll re-add it once the new checklist is up! |
ProposalPlease re-state the problem that we are trying to solve in this issue.After creating task without assignee, "0" is displayed What is the root cause of that problem?Issue happens on this line: App/src/components/TaskHeader.js Line 83 in 0ee7dfa
What changes do you think we should make in order to solve the problem?remove this redundant condition: Fixed code will look like this:
|
Able to reproduce on dev: @situchan's proposed solution seems to fix this. I see that logic was added in #20689 that was deployed 2 weeks ago. Not sure why we're just catching this now. |
Confirmed that getTaskAssigneeAccountID does indeed return Let's prioritize fixing this and go with @situchan's solution! |
Job added to Upwork: https://www.upwork.com/jobs/~0128bb3b4ad89ce372 |
Current assignee @MitchExpensify is eligible for the External assigner, not assigning anyone new. |
📣 @ayazhussain79 We're missing your Upwork ID to automatically send you an offer for the Reporter role. |
Summary: we're going with @situchan's fix as outlined here to fix this deploy blocker. Will need @aimane-chnaif's help to review and test! |
@MariaHCD I think the reason why we're just catching this now is from this PR https://github.com/Expensify/App/pull/21781/files#diff-941175f813fc9ba999d5f8221c16657a8f274cc7a803657578d5e4f01ae26da4R650 Before we will return |
Ah, nice catch, @hoangzinh. Thanks for sharing! |
🎯 ⚡️ Woah @aimane-chnaif / @situchan, great job pushing this forwards! ⚡️ The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉
On to the next one 🚀 |
Thanks for the quick fix all, I'm going to check it off the deploy checklist. |
Invites sent to @ayazhussain79 @situchan for eventual payment 👍 |
@MitchExpensify Offer accepted, Thank you |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-17. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Reminder set to pay out on 7/17 👍 Lets square off the BZ steps above in advance of that @aimane-chnaif 🚀 |
Payments issued! Friendly bump on @aimane-chnaif on the BZ steps :) |
friendly bump @aimane-chnaif 👍 |
No need regression test step. It's already in checklist:
|
Awesome, thank you @aimane-chnaif ! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
After creating a task without assignee “0” should not be displayed
Actual Result:
After creating a task without assignee “0” displayed after leaving
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.37-5
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-07.at.2.08.21.AM.mov
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688677922284949
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: