-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-05] Report - The request money is broken for "unknown" accounts without login information #22480
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @aldo-expensify ( |
Money request flow is very broken at the moment. |
I don't think this is related to "Gmail" accounts, but it is related to requesting money to accounts that haven't messaged you back (you don't have the full personal details yet). This worked:
This didn't work: |
The backend is expecting a |
@Beamanator the backend doesn't seem to support to create money requests by the account ID, what should we do?
|
@aldo-expensify our plan so far with these types of situations is along the lines of point 2 - BUT not ALWAYS disable - here's what are trying to accomplish:
|
So I don't believe we need to support creating money requests by account ID at the moment - otherwise we'll need to do that everywhere, and @puneetlath and I don't see a need for that if we follow the above plan |
Doesn't this mean that user y already knows user z's login (email)?
|
Yes, I started a new chat by using the email, but if that user doesn't reply back, then you get the bug. |
yes, I don't see any reason why "Request money" shouldn't show on DM where user already knows email. |
While I agree with what your are saying, I'm not sure if it is safe to use in all cases. I think that when you start a conversation with an email for the first time, we store that email as "displayName", but it still doesn't have a "login"... so to do what you are saying, we would have to do something like:
The problem with that is that the email found in
|
by the way, my understanding is shallow on this area, so @Beamanator or @puneetlath may give a better answer really :P |
Innnnnteresting, so yeah I may not have been completely following before :D Now I see that this "request money" flow is from WITHIN a chat report that you already created :D In this case I do think it's totally valid to be able to request money from the account -> because, as @0xmiroslav said, you already know the email (you may not know if an account exists with that email, but you already typed it out so you should be able to also request money from that chat). So it makes the most sense to me that in this case, you SHOULD be able to request money w/in a chat report. I do think this can be external since you should be able to get the user's email from Onyx somehow 🤔 since you already typed it out... |
Is it possible to get into a 1:1 chat with a user you found in a public room without knowing their email? I think the answer is no, but I wanted to confirm |
Yes it is. You can click on their profile (which opens using their accountID) and then chat them from their profile. |
@aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
The Web-E PR was deployed to staging, I'll make the App PR ready for review |
Made PR ready for review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.74-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-05. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
@aldo-expensify Eep! 4 days overdue now. Issues have feelings too... |
@aldo-expensify Still overdue 6 days?! Let's take care of this! |
@aldo-expensify 10 days overdue. I'm getting more depressed than Marvin. |
@aldo-expensify 12 days overdue now... This issue's end is nigh! |
This issue has not been updated in over 14 days. @aldo-expensify eroding to Weekly issue. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #22188
Action Performed:
Expected Result:
The IOU report page should not be grayed out and the composer should not be hidden for Gmail accounts
Actual Result:
The IOU report page is grayed out and the composer is hidden for Gmail accounts
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.38.3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6120808_The_IOU_report_page_is_grayed_out_and_the_composer_is_hidden_for_Gmail_accounts.mp4
Production IOS
0-02-01-2d9db84538bdb0e2b139cf30f919a44944613834b7c912c171c89be1f0e043e6_6d2a270fe3c7eb23_1.mp4
Staging IOS
0-02-01-0360e39b9766d53efdd534aa14558dd4c471fa07ec0e746693e3ce7cc1651b3c_a01c82a3c1189b8e_1.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: