-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LOW] [Splits] [$500] Request – Unable to Request money twice to the same user you have no conversation with. #33487
Comments
Job added to Upwork: https://www.upwork.com/jobs/~01497816ffe49c0bd0 |
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 ( |
This error is still exist? I can't find this error. It works well. |
📣 @handaniel214! 📣
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Requesting money twice to the same user that we haven't chatted with before will give an error. What is the root cause of that problem?This has the same root cause as #22031 (comment). In summary, when we create a money request with a user that we haven't chatted with before, we don't have their login yet. If we try to search for that same user when selecting the money request participant, we won't be able to find it and it will create a new optimistic account (with a different accountID) because we filter out any user that doesn't have a login. App/src/libs/OptionsListUtils.js Lines 1213 to 1217 in 862b0ea
Because the accountID is different, we created a new chat report and it will throw an error because we already have an existing chat with that user. In #22031, we are holding for #22480, but #22480 actually doesn't fix #22031. In #22480, we only fix an issue where the user is unable to create a money request from within the chat by allowing the request to accept an account ID, so if the login is missing, the request will still succeed. What changes do you think we should make in order to solve the problem?I tested doing money request, split, and send money and all of them can work even though the email/login is missing. We also have this PR to allow the user to do a split bill from within the chat with a user without login. So, I believe it makes sense to show a user even without a login on the money request participant list as the BE can already handle it. We can have a new flag called
(or just remove the login logic for all cases) |
@mallenexpensify, @abdulrahuman5196 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
|
@mallenexpensify, @abdulrahuman5196 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@mallenexpensify, @abdulrahuman5196 Still overdue 6 days?! Let's take care of this! |
@mallenexpensify Can we retest? I don't see this issue now |
I don't either, going to close. Thanks @abdulrahuman5196 |
Issue is still reproducible on the latest build 1.4.28-0 20240119_222315.mp4 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@mallenexpensify @abdulrahuman5196 this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:
Thanks! |
Still on hold |
Off hold, added |
Waiting for retest, adding to #vip-split |
Add |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
1 similar comment
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Waiting for proposals. |
Not able to reproduce this on Android (Chrome)
Screenrecorder-2024-04-19-15-42-44-209.mp4Is this issue mac only? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Gonna close this, wasn't able to repro AND it's 5 months old, nav is totally different now. 2024-04-23_14-43-13.mp4 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.16-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Prerequisite: The new account you're requesting money from must have an updated user name in NewDot, ie. first name = Matt, last = test, as seen in Matt A's vid below.
Action Performed:
Expected Result:
Two requests are in DM with the user you just sent a request to.
Actual Result:
Error appears when create the second request.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6323555_1703223322049.Unable_to_Request_money_twice_to_the_new_user.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: