-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-03] [$1000] Web - Temporary display of welcome message after deleting the last message #22591
Comments
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Job added to Upwork: https://www.upwork.com/jobs/~01ddbab3fa4cdb7228 |
Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts ( |
Added this to the op @ayazhussain79, otherwise the room disappears from LHN.
If you don't pin it, the room disappears from LHN, I'm unsure how someone would find it once it's gone if they don't know the room name. I wonder if can easily fix that as part of this bug or if we should have two bug issues? Or... maybe the one I found is a feature request? I'm uncertain of expected behaviour. What do you think @allroundexperts ? |
ProposalPlease re-state the problem that we are trying to solve in this issue.When deleting the last message, welcome message is displayed temporarily. What is the root cause of that problem?We calculate the App/src/libs/actions/Report.js Line 902 in e2e4057
As you can see, we get the last visible message from the report actions. That's why last visible action's message will be displayed in the LHN regardless it is whisper or not(Remember the welcome message is also a visible action) This is the root cause What changes do you think we should make in order to solve the problem?We need to filter out whisper actions when getting Add the 3rd parameter to the
This works as expected. Result22591.mp4What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.The welcome message is displayed for a while after deleting the last message. What is the root cause of that problem?There're many issues and inconsistencies with how we're checking which lastMessageText to display, in the following 2 locations.
a. For this particular issue, the cause is in here where we're not excluding whisper report action when getting the last report action to show. b. Besides that we're also not excluding the
a. In here, we're not excluding the pending deleted messages (pending deleted messages will pass the What changes do you think we should make in order to solve the problem?
(in
This will make sure all cases for What alternative solutions did you explore? (Optional)If we want to isolate the above |
I think as long as you are the member of the room, it should display in LHN. If its not displaying, then it looks like a different bug to me. |
Thanks @allroundexperts , and.... if 'room not showing in LHN' is a different/separate issue, can you think of any reason we'd want to address that first, before this bug report? I don't think it's necessary but would like bonus 👀 in case I'm missing something |
I think that would result in this issue being more clearly visible and more easily testable as well. It's a good call IMO. |
Proposed the new feature https://expensify.slack.com/archives/C01GTK53T8Q/p1689714154006189 |
Is this the correct link? |
We're not going to address this issue of the room disappearing in LHN because, once some/anyone posts in the room, it'll show in LHN, so it's safe to assume that people will post in room and, if not, then the room isn't really useful. So... we're clear to move forward with this specific issue. @allroundexperts , will you please review the proposals above and provide feedback? Thx |
On it today @mallenexpensify! |
Thanks for your proposal @s-alves10. While you've identified the correct root cause and have proposed a working solution as well, I think @tienifr's proposal is better in the sense that it incorporates all the places where this might be an issue. Let's go with @tienifr's proposal. 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@tienifr proposal looks good to me! |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Checklist
Regression Test Steps
Do we 👍 or 👎 |
@mallenexpensify, @allroundexperts, @stitesExpensify, @tienifr Huh... This is 4 days overdue. Who can take care of this? |
@mallenexpensify, @allroundexperts, @stitesExpensify, @tienifr Still overdue 6 days?! Let's take care of this! |
LGTM @allroundexperts. Can you fill out the checklist and then we can get this paid out? |
@stitesExpensify The checklist is complete. |
Ah i see, I specifically meant can you check the boxes here #22591 (comment) @mallenexpensify can we pay this and close it? |
I don't have access to do that 😄 |
You can't check boxes!? Then why do we tag you on each of them haha Either way, let's get this taken care of if we can @mallenexpensify |
@mallenexpensify, @allroundexperts, @stitesExpensify, @tienifr Still overdue 6 days?! Let's take care of this! |
Issue reporter: @ayazhussain79 paid $250 via Upwork |
@mallenexpensify offer accepted, Thank you |
Requested money in ND! |
Reviewed the details for @allroundexperts. $1,500 approved for payment in NewDot based on the BZ summary above. |
@mallenexpensify, @allroundexperts, @stitesExpensify, @tienifr Eep! 4 days overdue now. Issues have feelings too... |
Is this ready to be closed? |
Yep! |
Payment pending on Upwork |
Updated above, also pasting here Testrail update GH - https://github.com/Expensify/Expensify/issues/312295 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The welcome message should not be displayed for a while after deleting the last message
Actual Result:
The welcome message is displayed for a while after deleting the last message
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.38-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-recording-2023-07-10-at-75435-pm_dyFVnvza.mp4
Recording.3540.mp4
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689001566882329
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: