-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-02] [$1000] Request Money input is not getting focus when navigating back #22610
Comments
Triggered auto assignment to @maddylewis ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Request Money input is not getting focus when navigating back What is the root cause of that problem?
we just have the logic to focus input in componentDidMount, but if we go to the next page and go back, the previous page won't unmount that why the input is not re-focused What changes do you think we should make in order to solve the problem?In OptionsSelector We should add the logic to focus the input when the page is visible again in componentDidUpdate like what we did in WorkspaceInviteMessagePage
Using setTimeout is necessary because we can make sure that it will finish transition and then set focus. If we don't want to use setTimeout, we can use InteractionManager.runAfterInteractions instead ResultScreen.Recording.2023-07-11.at.11.08.37.mov |
Job added to Upwork: https://www.upwork.com/jobs/~01612a76428b498945 |
Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
assigning contributor to review proposal |
ProposalPlease re-state the problem that we are trying to solve in this issue.Request Money input is not getting focus when navigating back What is the root cause of that problem?When App/src/libs/Navigation/Navigation.js Line 122 in 777415e
Then MoneyRequestParticipantsSelector component didn't rerendered and focus lost in input.
What changes do you think we should make in order to solve the problem?In the
We don't need to use setTimeout or change other components. ResultScreen.Recording.2023-07-13.at.11.30.16.PM.movWhat alternative solutions did you explore? (Optional)N/A |
@eVoloshchak - bump on proposal reviews - thx! |
Triggered auto assignment to @cead22, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000) |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Upwork job |
📣 @mahesh! 📣
|
The BZ member will need to manually hire Mahesh for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future! |
This bug has been reported by me @cead22 . |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-02. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
moving to daily since payments are due early next week |
Payment due on Aug 2 |
|
Regression Test Proposal
Do we agree 👍 or 👎 |
Payments
|
@maddylewis Accepted the offer in upwork. Thanks. |
Requested the payment via NewDot |
Reviewed details for @eVoloshchak. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot. |
all payments sent - closing! |
I just noticed that this PR is approved by @eVoloshchak within 2 days, without any changes before final approval from Internal engineer and merging, here is the detail:
I think it's eligible for urgency bonus. We also had the same case here I know this issue was closed so long ago, and I apologize for this inconvenience and appreciate your attention to this matter 🙇. Thank you! cc @maddylewis |
@maddylewis What do you think about this ^? |
@maddylewis friendly bump |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Input should get focused in any case of navigation.
Actual Result:
Not getting in case of navigating back.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
iu.mp4
Recording.1245.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Mahesh-Vagicherla
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689016031128029
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: