-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-08-24] [HOLD for payment 2023-08-21] [$1000] Split bill - 'No results found' appears after selecting the user in split bill member search #22959
Comments
Triggered auto assignment to @mallenexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?The root cause of the issue is that when selecting a participant which does not exist and needs to be invited, after getting selected, we're emptying our What changes do you think we should make in order to solve the problem?Similar to how this is being done in the new chat page, we can change this to:
Then, we'll need to change this to:
We'll finally also need to replace this with:
What alternative solutions did you explore? (Optional)We need to replace this with:
|
Job added to Upwork: https://www.upwork.com/jobs/~0199d5a89c5f1a937a |
Current assignee @mallenexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
@allroundexperts , this happens with existing accounts too, was able to reproduce |
Regardless of new or existing participants, |
I'm not fully sure about this to be honest. If there's any place where we're searching for existing users only, then I think this will not show |
@allroundexperts Since you are an expert contributor so you have more responsibility 😉 Below condition in the
|
I don't think that this statement is entirely correct. A user which does not exist, should be added to Also, since I've proposed a solution here, I would really refrain from testing your solution and giving my opinion since this would be a case of conflict of interest. As such, I'll wait for @fedirjh to weigh in here! |
I think I miss understood the requirements. You are right. We need that list in the case of existing participants. |
Still waiting on proposals |
ProposalPlease re-state the problem that we are trying to solve in this issue.On the split bill page, after search Name or email and select user, there is an error message like "No results found" What is the root cause of that problem?
This function has no considered the selected members in the search result. What changes do you think we should make in order to solve the problem?Should consider selected members that is included in search text. App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSplitSelector.js Lines 129 to 133 in 75e737b
To if (isOptionInList) {
newSelectedOptions = _.reject(participants, (selectedOption) => selectedOption.accountID === option.accountID);
} else {
newSelectedOptions = [...participants, {accountID: option.accountID, login: option.login, selected: true, searchText: option.searchText}];
} From App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSplitSelector.js Lines 148 to 153 in 75e737b
To const headerMessage = OptionsListUtils.getHeaderMessage(
newChatOptions.personalDetails.length + newChatOptions.recentReports.length !== 0,
Boolean(newChatOptions.userToInvite),
searchTerm,
maxParticipantsReached,
participants.filter(participant => participant.searchText.includes(searchTerm)).length > 0
); From App/src/libs/OptionsListUtils.js Lines 1002 to 1026 in 75e737b
To function getHeaderMessage(hasSelectableOptions, hasUserToInvite, searchValue, maxParticipantsReached = false, hasMatchedParticipant=false) {
if (maxParticipantsReached) {
return Localize.translate(preferredLocale, 'common.maxParticipantsReached', {count: CONST.REPORT.MAXIMUM_PARTICIPANTS});
}
const isValidPhone = parsePhoneNumber(LoginUtils.appendCountryCode(searchValue)).possible;
const isValidEmail = Str.isValidEmail(searchValue);
if (searchValue && CONST.REGEX.DIGITS_AND_PLUS.test(searchValue) && !isValidPhone) {
return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
}
// Without a search value, it would be very confusing to see a search validation message.
// Therefore, this skips the validation when there is no search value.
if (searchValue && !hasSelectableOptions && !hasUserToInvite) {
if (/^\d+$/.test(searchValue) && !isValidPhone) {
return Localize.translate(preferredLocale, 'messages.errorMessageInvalidPhone');
}
if (/@/.test(searchValue) && !isValidEmail) {
return Localize.translate(preferredLocale, 'messages.errorMessageInvalidEmail');
}
if (!hasMatchedParticipant)
return Localize.translate(preferredLocale, 'common.noResultsFound');
}
What alternative solutions did you explore? (Optional)errorMessage.mov |
@fedirjh can you review @StanislavLavrenchuk 's proposal above please? |
I think @allroundexperts's proposal make sense to me. We just make it consistent with new group page. @StanislavLavrenchuk |
@fedirjh thanks your review. App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSplitSelector.js Lines 148 to 153 in cd851d0
to const headerMessage = OptionsListUtils.getHeaderMessage(
newChatOptions.personalDetails.length + newChatOptions.recentReports.length + participants.length!== 0, |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-21. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-24. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Hello. |
I think the right payment date is 2023-08-24. |
@madmax330 @mallenexpensify I am waiting to get payment today. |
BugZero Checklist:
Regression Test Proposal
Do we agree 👍 or 👎 |
@madmax330, @mallenexpensify, @fedirjh, @luckyman0305 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
I am waiting payment |
@mallenexpensify can you handle the payment 🙏🏽 |
Sorry for the delay, I was OOO a few days. Issue reporter: Applause @luckyman0305 , I hired you, can you please accept the job and reply here once you have? |
Updated above, posting here too Thanks @luckyman0305 and @fedirjh |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
There is no error message after selecting the member in the search result
Actual Result:
No results found' appears after selecting the member in the search result
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.41.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6127080_20230713_235416.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Interanl Team
Slack conversation:
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: