Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-02] [$1000] Split Bill - After splitting money, clicking on IOU detail takes the user to the Concierge chat. #22964

Closed
2 of 6 tasks
kbecciv opened this issue Jul 16, 2023 · 47 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed

Comments

@kbecciv
Copy link

kbecciv commented Jul 16, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Website
  2. Split bill.
  3. Click on You preview.

Expected Result:

It should navigates user to you detail page.

Actual Result:

After splitting money, clicking on IOU detail takes the user to the Concierge chat.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.41-1
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

WhatsApp.Video.2023-07-15.at.2.40.29.AM.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Ad-eeb
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689369192363999

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fccec540368136b1
  • Upwork Job ID: 1681722206099353600
  • 2023-07-19
  • Automatic offers:
    • | | 0
    • | | 0
@kbecciv kbecciv added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 16, 2023

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@daordonez11
Copy link
Contributor

Was analyzing to give a proposal but this is a regression of #22787, which should be fixed as part of the original PR.

PS real steps, you need to get the issue of: There is a previously existing chat between these users, json code 666 in the command SplitBillAndOpenReport.

Expected behavior: should show the optimistic report or hmmm not here page.

cc @allroundexperts @wildan-m

@allroundexperts
Copy link
Contributor

Thanks for letting us know @daordonez11!

@wildan-m, can you please confirm and possibly raise a fix PR?

@wildan-m
Copy link
Contributor

@daordonez11 @allroundexperts thanks for the report, checking...

@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2023
@muttmuure muttmuure changed the title Split Bill - After splitting money, clicking on IOU detail takes the user to the correct chat. Split Bill - After splitting money, clicking on IOU detail takes the user to the Concierge chat. Jul 19, 2023
@muttmuure muttmuure added the External Added to denote the issue can be worked on by a contributor label Jul 19, 2023
@melvin-bot melvin-bot bot changed the title Split Bill - After splitting money, clicking on IOU detail takes the user to the Concierge chat. [$1000] Split Bill - After splitting money, clicking on IOU detail takes the user to the Concierge chat. Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01fccec540368136b1

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Current assignee @muttmuure is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

@muttmuure
Copy link
Contributor

Reproduced, although I've just spotted that this is a regression so will double check if it should get a bounty

@melvin-bot melvin-bot bot removed the Overdue label Jul 19, 2023
@allroundexperts
Copy link
Contributor

This is a regression @muttmuure. Working on the review of the PR!

@wildan-m
Copy link
Contributor

@allroundexperts any feedback on this fix PR?

@allroundexperts
Copy link
Contributor

@allroundexperts any feedback on this fix PR?

Still testing it. Will test more tomorrow.

@robertKozik
Copy link
Contributor

@muttmuure could you assign this issue to @allroundexperts as he is responsible for checking the PR for this regression?

@allroundexperts
Copy link
Contributor

PS real steps, you need to get the issue of: There is a previously existing chat between these users, json code 666 in the command SplitBillAndOpenReport.

@daordonez11 I think these steps are different from what this issue is. With these steps, currently (without the changes of the PR mentioned), we're showing the user a 404 page which is incorrect as well. After applying the changes, the user is being redirected to concierge. I think both behaviours are incorrect. What should really happen in this case is that the backend should not clear the whole Onyx report. Rather it should just add error fields to the report object. That way, we can show to the user that some error occured.

@melvin-bot melvin-bot bot added the Overdue label Jul 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 24, 2023

@muttmuure, @robertKozik Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2023
@muttmuure
Copy link
Contributor

Looks like we don't think the other issue is a regression but I am going to keep an eye on it

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2023
@muttmuure
Copy link
Contributor

Payment should be on 10-12

@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2023
@muttmuure
Copy link
Contributor

Ah, OK I miscalculated the dates and this can be paid out

@melvin-bot melvin-bot bot removed the Overdue label Oct 6, 2023
@muttmuure
Copy link
Contributor

Is this really linked to a deploy blocker? @luacmartins, @allroundexperts do you know?

@luacmartins
Copy link
Contributor

AFAIK this was a regression of #22787 (within the regression period) and fixed in #24407

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@muttmuure
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Oct 10, 2023
@muttmuure
Copy link
Contributor

Going to close as this was a fix to a regression, which are not compensated

@Ad-eeb
Copy link

Ad-eeb commented Oct 10, 2023

@muttmuure As far as I know, we pay for reporting regressions. I am not sure if something has changed. Can you share the link to the announcement if it has been changed?

@muttmuure muttmuure reopened this Oct 10, 2023
@muttmuure
Copy link
Contributor

You should be compensated

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@luacmartins
Copy link
Contributor

Just pending payment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2023
@luacmartins
Copy link
Contributor

Same as above. Still waiting on payment.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 16, 2023
@muttmuure
Copy link
Contributor

Handling

@melvin-bot melvin-bot bot removed the Overdue label Oct 19, 2023
@muttmuure
Copy link
Contributor

invite sent

@muttmuure
Copy link
Contributor

Offer sent

@muttmuure
Copy link
Contributor

Paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

8 participants