[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] MEDIUM: New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.)

[JmillsExpensify]

We're initially building support for receipt images uploads, but we need to circle back and add the ability to upload PDF or other file types.

Internal context in this Slack thread.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01cfad31fbc4738d9d
• Upwork Job ID: 1702030509135847424
• Last Price Increase: 2023-09-20
• Automatic offers:
• hoangzinh | Contributor | 26877236

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[shawnborton]

Anything needed from me here?

[JmillsExpensify]

Nah, I'll remove you.

[JmillsExpensify]

Still clean-up for wave4

[JmillsExpensify]

Same same

[JmillsExpensify]

For this one, I think we should go in a direction where we prioritize images, but we allow for non-image uploads by choosing a file-type option. Here's how WhatsApp does it and that works pretty well.

[dylanexpensify]

Agree, I think that approach feels the most intuitive

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01cfad31fbc4738d9d

[melvin-bot]

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Support file uploads on mobile (e.g. PDFs, docx, etc.)

What is the root cause of that problem?

New feature, moreover, according to this line, currently we only support upload image in mobile app

App/src/pages/iou/ReceiptSelector/index.native.js

Line 160 in 95c9e47

imagePickerFunc(getImagePickerOptions(CONST.ATTACHMENT_PICKER_TYPE.IMAGE), (response) => {

What changes do you think we should make in order to solve the problem?

According to this comment #23228 (comment), we would like to do something like we done add attachment chat composer in mobile app. So in order to to it, we need to wrap those line of codes inside AttachmentPicker component, same as we did for default platform

App/src/pages/iou/ReceiptSelector/index.js

Lines 112 to 133 in 95c9e47

	<AttachmentPicker>
	{({openPicker}) => (
	<PressableWithFeedback
	accessibilityLabel={translate('receipt.chooseFile')}
	accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON}
	>
	<Button
	medium
	success
	text={translate('receipt.chooseFile')}
	style={[styles.p9]}
	onPress={() => {
	openPicker({
	onPicked: (file) => {
	setReceiptAndNavigate(file, props.iou, props.report);
	},
	});
	}}
	/>
	</PressableWithFeedback>
	)}
	</AttachmentPicker>

Result:

Screen.Recording.2023-09-14.at.22.47.21.mov

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.) #28399

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.) #28399

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.) #28399

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• New Feature: Support file uploads on mobile (e.g. PDFs, docx, etc.) #28399

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Contributor)
• @sobitneupane does not require payment (Eligible for Manual Requests)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@johnmlee101, @hoangzinh, @sobitneupane, @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@johnmlee101, @hoangzinh, @sobitneupane, @dylanexpensify Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@johnmlee101, @hoangzinh, @sobitneupane, @dylanexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[hoangzinh]

cc @dylanexpensify for payment.

[dylanexpensify]

paying today!

[dylanexpensify]

Payment summary:

• Contributor: @hoangzinh $500
• Contributor+: @sobitneupane

Please apply!

[dylanexpensify]

Paid!

[sobitneupane]

#23228 (comment)

Requested payment on newDot.

[JmillsExpensify]

@dylanexpensify can you please update your payment summary. It's missing an amount for @sobitneupane

[dylanexpensify]

Sorry!

Payment Summary:

• Contributor+: @sobitneupane $500

Please apply!

[JmillsExpensify]

$500 payment approved for @sobitneupane based on comment above.