[$1000] Chat - Removed reactions by other user offline still displayed after going online

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

**Issue found when executing PR ** #17996

Action Performed:

Precondition: Login as users A & B on Web ; a chat exists between them

1. Open https://staging.new.expensify.com/
2. As users A & B open the common chat
3. As user A add reactions to a message
4. As user B add reactions to a different message
5. As user A go offline
6. As user A remove added reactions
7. As user B remove added reactions
8. As user A go online
9. As user A reload the page

Expected Result:

After user A goes online and also after they reload the page - user A doesn't see reactions removed by users A & B at steps 6-7

Actual Result:

After user A goes online - they don't see reactions removed by user A BUT still see reactions removed by user B. (Web, mWeb, Desktop app behaviour).
After user A goes online - they still see both removed reactions from users A &B. (iOS app, Android app behaviour).
Issue persists after reloading the page / restarting the app

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Safari
• MacOS / Desktop

Version Number: 1.3.44.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6137083_Recording__795.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d3092dcc6629c8a
• Upwork Job ID: 1683362853973221376
• Last Price Increase: 2023-08-03

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[robertjchen]

Thanks for the report! Looks like we have at least another regression coming off that PR: #23307

I wouldn't say this would be a deploy blocker per-se, just a regression. We can get it addressed without blocking the deploy 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d3092dcc6629c8a

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[pbkompasz]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Removed reactions by other user offline still displayed after going online.
Messages reactions made during offline sessions mismatch across clients.

What is the root cause of that problem?

Reaction modifications during offline sessions are not updated.
Reactions changes during offline sessions are continued to be displayed after resuming connection.
This issue persists after reloading the page, but solved after deleting cookies.

What changes do you think we should make in order to solve the problem?

Merge the response from the most recent API response and display the correct reactions.

What alternative solutions did you explore? (Optional)

-

[StevenKKC]

It seems to be a BE issue. BE does not send reportActionsReactions after goes online and reload the page.

[pbkompasz]

@StevenKKC I don't think it's a BE issue given that if you remove the cache on the client side and reload everything the issue gets resolved.

[railway17]

@StevenKKC I don't think it's a BE issue given that if you remove the cache on the client side and reload everything the issue gets resolved.

Agree with @pbkompasz
Api returns empty reactions list when turning off force offline.
Just do not update the persistent storage.
I also think that it should be resolved in onyx side

[melvin-bot]

📣 @railway17! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[railway17]

Contributor details
Your Expensify account email: hanmingyun1212@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01bc9266760788d96f

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[railway17]

Contributor details
Your Expensify account email: hanmingyun1212@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01bc9266760788d96f

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Santhosh-Sellavel]

@puneetlath or @rushatgabhane Please hold on this issue for #23307. I'll post an update whether it's handled there or not. Because I ran into something similar while reviewing PR. So wait for here, thanks!

[melvin-bot]

@puneetlath, @robertjchen, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

@lanitochka17 Can you confirm whether this still occurs for you?

[puneetlath]

I just tested on staging and the bug seems to still be occurring.

[puneetlath]

So @Santhosh-Sellavel I think I'll remove the hold, yeah?

[Santhosh-Sellavel]

If it's occurring it can come off hold.

[puneetlath]

Ok removing the hold. @rushatgabhane do we have any existing proposals that you like?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[pbkompasz]

@puneetlath I cannot reproduce the issue anymore
I think it got fixed in this PR #23371

[puneetlath]

Hmm, yeah I just tried again and also wasn't able to reproduce. Ok closing! Thanks everyone.