-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details #23579
Comments
Triggered auto assignment to @JmillsExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Proposal by: @BhuvaneshPatil ProposalPlease re-state the problem that we are trying to solve in this issue.Clicking on header of task report opens assignee page instead of members/details page What is the root cause of that problem?When we click on header - App/src/pages/home/HeaderView.js Lines 164 to 170 in b7d17e0
And this function - Lines 1269 to 1281 in b7d17e0
For task which has assignee, there is only one What changes do you think we should make in order to solve the problem?The solution depends on what page do we want to open
What alternative solutions did you explore? (Optional) |
Expanding on - #23579 (comment) ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Clicking on Avatar in Header of Task Detail page takes to wrong user details What is the root cause of that problem?When we click on header - What changes do you think we should make in order to solve the problem?as mentioned by @thienlnam here - https://expensify.slack.com/archives/C049HHMV9SM/p1690311552613889?thread_ts=1689928645.869329&cid=C049HHMV9SM Clicking on task header should take us to profile details of creator. To adjust for this behaviour -
What alternative solutions did you explore? (Optional) |
Able to reproduce this one. Given that the task creator is the avatar that appears in the header, I think that's the one we should be showing. |
Job added to Upwork: https://www.upwork.com/jobs/~01ccc9b0b61fc1bf49 |
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav ( |
dupe of #23296 and #22498. @jasperhuangg will be taking care of this #23296 (comment). |
I think that second one is a closer replica. Thanks for flagging. I'll close though Jasper, please re-open if you disagree. |
Further for clarity, since this is a duplicate report, no payout is issued for reporting. |
@Nodebrute. I have mentioned the root cause for #23296 in slack conversation. So they are not dupes. The PR that was going to fix -#22498, has been merged and it's still reproducible. |
@BhuvaneshPatil the issue related to task header has been reported multiple times and this bug was caught during the PR of that issue. where they decided to hold it #22586 (comment). |
Updated proposal - Dupe of this issue that was reported after this issue, proposal on that issue - #24144 (comment) ProposalPlease re-state the problem that we are trying to solve in this issue.It must show the detail of the user's profile that assigns the task What is the root cause of that problem?As decided here in slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1691426870537099?thread_ts=1691334974.136469&cid=C01GTK53T8Q We should show the task title (the one that appears in header below the avatar, and avatar will be of task creator) What changes do you think we should make in order to solve the problem?We are disabling showing App/src/pages/ReportDetailsPage.js Lines 153 to 160 in 09f6b6b
For that value we use - App/src/pages/ReportDetailsPage.js Lines 63 to 64 in 09f6b6b
We shall change - const shouldUseFullTitle = !shouldDisableSettings || ReportUtils.isTaskReport(props.report); It will allow to show full title in case we are opening a task report. If we want to show the settings option as well - function shouldDisableSettings(report) {
return !isPolicyExpenseChat(report) && !isChatRoom(report) && !isChatThread(report) && !isTaskReport(report);
} What alternative solutions did you explore? (Optional) |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
There are two possibilities:
It should show the details of the task creator
Actual Result:
Wrong user in Header and User Details page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.45.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-21.at.2.00.52.PM.mov
Expensify/Expensify Issue URL:
Issue reported by: @BhuvaneshPatil
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689928645869329
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: