-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD - should be fixed by #23125] Web - Flag as spam page always reloads when switching browser tabs #23853
Comments
Triggered auto assignment to @johncschuster ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Every time we switch tabs to return to report, the RHN with flag comment action shows loading indicator What is the root cause of that problem?Every time we change the tab we make the api App/src/pages/FlagCommentPage.js Lines 160 to 162 in eb02006
shows loading whenever openReport is called.
What changes do you think we should make in order to solve the problem?This here App/src/pages/FlagCommentPage.js Line 168 in eb02006
and remove this isLoadingReportData hereApp/src/pages/FlagCommentPage.js Lines 202 to 203 in eb02006
What alternative solutions did you explore? (Optional) |
ProposalPlease re-state the problem that we are trying to solve in this issue.Switching tab will show a loading indicator on the flag comment page. What is the root cause of that problem?In the flag comment page, we will show the loading indicator if App/src/pages/FlagCommentPage.js Lines 160 to 163 in eb02006
When we switch tabs, App/src/libs/actions/Report.js Lines 382 to 387 in eb02006
The loading indicator is useful when the report and the actions are not loaded yet. If we don't show a loading indicator, it will show a not found page for a brief moment then show the flag page. It's not perfect (it won't cover all cases) but it's what we have now. What changes do you think we should make in order to solve the problem?We should show the loading indicator only if either report or the actions are empty. |
This will be fixed in this issue #23125 |
Thanks for the heads up, @dukenv0307! I'll demote this to |
Looks like we're still waiting on #23125 to be resolved. |
Looks like #23125 fixed this. Not reproducible for me anymore. |
Awesome. Thanks for checking! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Flag as spam RHN should not reload every time the tab is switched
Actual Result:
Flag as spam RHN always reloads when tab is switched
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-28.at.9.05.21.PM.mp4
Recording.3992.mp4
Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690560646136359
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: