[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

lanitochka17 · 2023-07-18T20:01:29Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #22771

Action Performed:

Precondition: user is logged in on two platforms with different accounts

Open the app logged in with Account A
On a different device, send a message from Account B to Account A
Open the chat as Account A
Turn off wifi or mobile data
Tap the message and select "Reply in thread"
Send a message in the thread
Return to the report
Tap the message and select "Flag as offensive"

Expected Result:

The reasons for flagging are displayed

Actual Result:

Infinite loading when selecting "Flag as offensive"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.42.18

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6132837_IMG_0533.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d1f8e9ce942eb648
Upwork Job ID: 1681531600613777408
Last Price Increase: 2023-07-26
Automatic offers:

fedirjh | Reviewer | 25865636
dukenv0307 | Contributor | 25865637

melvin-bot · 2023-07-18T20:01:34Z

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-18T20:01:36Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Nodebrute · 2023-07-18T20:47:00Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Infinite loading after selecting flag option offline

What is the root cause of that problem?

When we open report isLoadingReportAction is true

App/src/libs/actions/Report.js

Line 397 in 21d14c5

isLoadingReportActions: true,

In flag comment this make this condition true hence the instead of page we have a loading indicator

App/src/pages/FlagCommentPage.js

Line 160 in 21d14c5

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions;

What changes do you think we should make in order to solve the problem?

Solution 1:

We can remove props.report.isLoadingReportActions from here

App/src/pages/FlagCommentPage.js

Line 160 in 21d14c5

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions;

Or we can use && instead of ||

What alternative solutions did you explore? (Optional)

s-alves10 · 2023-07-18T21:55:06Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Selecting flag option shows infinite loading in offline mode

What is the root cause of that problem?

We're showing Loader here

App/src/pages/FlagCommentPage.js

Lines 150 to 153 in be7b6a0

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions; 
        
           if (shouldShowLoading) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

We set report.isLoadingReportActions to true when we open report and set isLoadingReportData when we reconnect app.
In offline mode, openReport API isn't called but isLoadingReportActions is set optimistically. That's why we see the infinite loader.

This is from this PR

What changes do you think we should make in order to solve the problem?

We have reportID and reportActionID(from the route). I think we should be able to flag comments as long as we have corresponding report and reportAction.

So I suggest to remove the above code completely(L150-L153)

This works as expected.

What alternative solutions did you explore? (Optional)

dukenv0307 · 2023-07-19T04:09:06Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Infinite loading after selecting flag option offline

What is the root cause of that problem?

Let's see the condition to display FullscreenLoadingIndicator

App/src/pages/FlagCommentPage.js

Lines 160 to 163 in 5419d9b

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions; 
        
           if (shouldShowLoading) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

We are setting isLoadingReportActions: true in optimisticData of openReport API

App/src/libs/actions/Report.js

Line 397 in 5419d9b

isLoadingReportActions: true,

but when offline the API is not sent so both successData and failureData are not updated. So, isLoadingReportActions still be true

What changes do you think we should make in order to solve the problem?

App/src/pages/FlagCommentPage.js

Lines 160 to 163 in 5419d9b

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions; 
        
           if (shouldShowLoading) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

We need to show loadingPage here because in case the user access to FlagCommentPage by link, then there are 2 scenarios

User has permission to flag a comment
User has not permission to flag comments (in case the user wants to flag their own comment)

This is the reason why we need to show loadingPage while we wait for data and decide which scenario happen
We only should show FullscreenLoadingIndicator if report is empty and isLoadingReportData is true or if reportActions is empty and isLoadingReportActions is true. Update like this code

const shouldShowLoading = (props.isLoadingReportData && isEmpty(props.report) || (isEmpty(props.reportActions) && props.report.isLoadingReportActions)

What alternative solutions did you explore? (Optional)

Access to FlagCommentPage by link only happens while the user is online so I suggest we only should show FullscreenLoadingIndicator while online, update like this code

const shouldShowLoading = (props.isLoadingReportData || props.report.isLoadingReportActions) && !props.network.isOffline

melvin-bot · 2023-07-19T05:09:11Z

Job added to Upwork: https://www.upwork.com/jobs/~01d1f8e9ce942eb648

melvin-bot · 2023-07-19T05:09:15Z

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-07-19T05:09:21Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

eh2077 · 2023-07-20T09:13:58Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Infinite loading after selecting flag option offline.

What is the root cause of that problem?

The root cause of this issue is that

We set optimistic isLoadingReportActions to true when open a report
In offline mode, isLoadingReportActions of the report remains true, so following snippet will show the infinite loading

App/src/pages/FlagCommentPage.js

Lines 160 to 163 in 5419d9b

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions; 
        
           if (shouldShowLoading) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

What changes do you think we should make in order to solve the problem?

The expected behaviours should be

In offline mode, the flag options should be shown and is able to flag, which will update to backend after online.
If report is loading, isLoadingReportData is true, we should show loading indicator
If report or action to flag is empty, then we should show FullPageNotFoundView

To achieve it, we can

Remove following snippet

App/src/pages/FlagCommentPage.js

Lines 160 to 163 in cc5526b

    
           const shouldShowLoading = props.isLoadingReportData || props.report.isLoadingReportActions; 
        
           if (shouldShowLoading) { 
        
               return <FullscreenLoadingIndicator />; 
        
           }

Change this line

App/src/pages/FlagCommentPage.js

Line 168 in cc5526b

<FullPageNotFoundView shouldShow={!shouldShowLoading && !ReportUtils.shouldShowFlagComment(getActionToFlag(), props.report)}>

to
```
<FullPageNotFoundView shouldShow={_.isEmpty(props.report) || _.isEmpty(getActionToFlag()) || !ReportUtils.shouldShowFlagComment(getActionToFlag(), props.report)}>
```
Add
```
withReportOrNotFound,
```
below this line

App/src/pages/FlagCommentPage.js

Line 193 in cc5526b

withLocalize,

and remove

App/src/pages/FlagCommentPage.js

Lines 202 to 204 in cc5526b

isLoadingReportData: {

key: ONYXKEYS.IS_LOADING_REPORT_DATA,

},

The usage of withReportOrNotFound and FullPageNotFoundView is similar to SplitBillDetailsPage.js

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-07-21T20:08:59Z

@tjferriss, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

fedirjh · 2023-07-21T20:15:34Z

Reviewing shortly.

rk111 · 2023-07-24T18:05:07Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Infinite loading after selecting flag option offline

What is the root cause of that problem?

FullscreenLoadingIndicator on the FlagCommentPage is not handling the scenario where the user is offline and the API call is not sent. Specifically, when the user is offline, the API call to update the report actions is not made, and as a result, the isLoadingReportActions flag remains true, causing the loading indicator to persist indefinitely.

What changes do you think we should make in order to solve the problem?

Update the condition for shouldShowLoading to consider the scenario where the user is offline and the API call is not made. We should show the loadingPage when either of the following conditions is true:
a. isLoadingReportData is true, and the report data is empty (props.isLoadingReportData && isEmpty(props.report))
b. isLoadingReportActions is true, and the reportActions data is empty (isEmpty(props.reportActions) && props.report.isLoadingReportActions)

To address the scenario where the user accesses the FlagCommentPage by link while online, show the FullscreenLoadingIndicator only when the user is online. Update the condition to include a check for the network status:
(props.isLoadingReportData || props.report.isLoadingReportActions) && !props.network.isOffline

melvin-bot · 2023-07-25T20:11:15Z

@tjferriss, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

tjferriss · 2023-07-25T22:38:53Z

Easy, MelvinBot. @fedirjh is reviewing proposals.

melvin-bot · 2023-07-26T16:00:08Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

fedirjh · 2023-07-27T11:14:44Z

@dukenv0307 It seems to be a regression from your PR, I have raised a question in the PR about the FullscreenLoadingIndicator, Can you please share any inputs on why it was implemented?

dukenv0307 · 2023-07-27T11:19:41Z

@fedirjh I replied in the PR. Can you check again.

dukenv0307 · 2023-07-27T11:50:38Z

@fedirjh The fix that I mentioned in the PR is my proposal of this issue. What do you think about it?

fedirjh · 2023-07-30T18:59:04Z

Thanks for reviewing proposals. Can I have your feedback about my #23125 (comment).

@eh2077 Your proposal doesn’t cover the case when we don't have report action and we deep link, it will display 'not found' view for a brief moment before rendering the flag comment component and that's not expected.

The transition should be expected right?

Nope, it doesn’t make sense to display not found then found, it should be loading then found or not found. The expected transition is that we display a skeleton view until the data is loaded and given that we have not implemented that yet, we should display the loading indicator.

srikarparsi · 2023-07-31T21:19:44Z

Looks good to me as well, thanks @fedirjh and @dukenv0307!

melvin-bot · 2023-07-31T21:19:53Z

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-07-31T21:19:57Z

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

dukenv0307 · 2023-08-01T02:11:01Z

@fedirjh The PR is ready for review.

fedirjh · 2023-08-02T09:52:15Z

Update: We are currently facing a similar issue that also impacts the split bill detail page #23568. In this PR, we plan to introduce a new HOC named withReportAndReportActionOrNotFound. This HOC will contain the same code as the one mentioned in this issue. To prevent redundant code, we will hold the PR until the new HOC is created, and then we will use it within the FlagCommentPage page.

Fix crash app when opening split bill detail page by deep link #23977

melvin-bot · 2023-08-08T05:44:01Z

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

when @dukenv0307 got assigned: 2023-07-31 21:19:57 Z
when the PR got merged: 2023-08-08 05:44:00 UTC
days elapsed: 5

On to the next one 🚀

dukenv0307 · 2023-08-08T07:15:51Z

@fedirjh @srikarparsi This PR is on hold from August 1 to August 4. So I think we are eligible for a bonus timeline

melvin-bot · 2023-08-10T20:00:45Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-08-10T20:00:48Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix infinite loading in Flag page in offline #23775

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter NA Applause
Contributor that fixed the issue @dukenv0307 $1000
Contributor+ that helped on the issue and/or PR @fedirjh $1000

For reference, here are some details about the assignees on this issue:

@fedirjh requires payment offer (Reviewer)
@dukenv0307 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-08-10T20:00:49Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
[@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@fedirjh] Determine if we should create a regression test for this bug.
[@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

tjferriss · 2023-08-15T05:16:31Z

@fedirjh and @dukenv0307 are both hired in Upworks: https://www.upwork.com/ab/applicants/1681531600613777408/hired. We're waiting on the regression period now.

@fedirjh can you get started on the checklist when you have a minute?

fedirjh · 2023-08-17T13:12:25Z

BugZero Checklist:

Link to the PR: Fix user are able to flag their own comment #21771
Link to comment: Fix user are able to flag their own comment #21771 (comment)
Link to discussion: N/A There was a recently added checklist item that could help catch this bug earlier.

If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.

Determine if we should create a regression test for this bug: yes

Regression Test Proposal

From user A, send a new message to user B
From user B, go offline
Open a different report than user A
Go back to the report with user A
Tap the message and select "Flag as offensive"
Verify that the flag page appears instead of loading infinitely

Do we agree 👍 or 👎

tjferriss · 2023-08-17T22:21:26Z

The payments have been sent via Upworks and QA issue created.

dukenv0307 · 2023-11-22T05:03:11Z

@tjferriss Can you please check my comment above #23125 (comment).

tjferriss · 2023-11-22T21:49:53Z

@dukenv0307 yes, that looks right. I've paid the bonus to both of you via Upworks.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 18, 2023

melvin-bot bot assigned tjferriss Jul 18, 2023

tjferriss added the External Added to denote the issue can be worked on by a contributor label Jul 19, 2023

melvin-bot bot changed the title ~~Chat - Infinite loading after selecting flag option offline~~ [$1000] Chat - Infinite loading after selecting flag option offline Jul 19, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 19, 2023

melvin-bot bot assigned fedirjh Jul 19, 2023

melvin-bot bot added the Overdue label Jul 20, 2023

melvin-bot bot added Overdue and removed Overdue labels Jul 21, 2023

melvin-bot bot removed the Overdue label Jul 25, 2023

fedirjh mentioned this issue Jul 27, 2023

Fix user are able to flag their own comment #21771

Merged

57 tasks

dukenv0307 mentioned this issue Jul 29, 2023

[HOLD - should be fixed by #23125] Web - Flag as spam page always reloads when switching browser tabs #23853

Closed

6 tasks

srikarparsi assigned dukenv0307 Jul 31, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 31, 2023

dukenv0307 mentioned this issue Aug 1, 2023

Fix infinite loading in Flag page in offline #23775

Merged

58 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 1, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 10, 2023

melvin-bot bot changed the title ~~[$1000] Chat - Infinite loading after selecting flag option offline~~ [HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline Aug 10, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Aug 10, 2023

melvin-bot bot added the Monthly KSv2 label Aug 10, 2023

tjferriss closed this as completed Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

lanitochka17 commented Jul 18, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 18, 2023

melvin-bot bot commented Jul 18, 2023 •

edited by tjferriss

Loading

Nodebrute commented Jul 18, 2023

s-alves10 commented Jul 18, 2023

dukenv0307 commented Jul 19, 2023 •

edited

Loading

melvin-bot bot commented Jul 19, 2023

melvin-bot bot commented Jul 19, 2023

melvin-bot bot commented Jul 19, 2023

eh2077 commented Jul 20, 2023

melvin-bot bot commented Jul 21, 2023

fedirjh commented Jul 21, 2023

rk111 commented Jul 24, 2023

melvin-bot bot commented Jul 25, 2023

tjferriss commented Jul 25, 2023

melvin-bot bot commented Jul 26, 2023

fedirjh commented Jul 27, 2023

dukenv0307 commented Jul 27, 2023

dukenv0307 commented Jul 27, 2023

fedirjh commented Jul 30, 2023

srikarparsi commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023

dukenv0307 commented Aug 1, 2023

fedirjh commented Aug 2, 2023

melvin-bot bot commented Aug 8, 2023

dukenv0307 commented Aug 8, 2023

melvin-bot bot commented Aug 10, 2023

melvin-bot bot commented Aug 10, 2023 •

edited by tjferriss

Loading

melvin-bot bot commented Aug 10, 2023

tjferriss commented Aug 15, 2023

fedirjh commented Aug 17, 2023

tjferriss commented Aug 17, 2023

dukenv0307 commented Nov 22, 2023

tjferriss commented Nov 22, 2023

[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

[HOLD for payment 2023-08-17] [$1000] Chat - Infinite loading after selecting flag option offline #23125

Comments

lanitochka17 commented Jul 18, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 18, 2023

melvin-bot bot commented Jul 18, 2023 • edited by tjferriss Loading

Bug0 Triage Checklist (Main S/O)

Nodebrute commented Jul 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

s-alves10 commented Jul 18, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented Jul 19, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jul 19, 2023

melvin-bot bot commented Jul 19, 2023

melvin-bot bot commented Jul 19, 2023

eh2077 commented Jul 20, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jul 21, 2023

fedirjh commented Jul 21, 2023

rk111 commented Jul 24, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot bot commented Jul 25, 2023

tjferriss commented Jul 25, 2023

melvin-bot bot commented Jul 26, 2023

fedirjh commented Jul 27, 2023

dukenv0307 commented Jul 27, 2023

dukenv0307 commented Jul 27, 2023

fedirjh commented Jul 30, 2023

srikarparsi commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023

dukenv0307 commented Aug 1, 2023

fedirjh commented Aug 2, 2023

melvin-bot bot commented Aug 8, 2023

dukenv0307 commented Aug 8, 2023

melvin-bot bot commented Aug 10, 2023

melvin-bot bot commented Aug 10, 2023 • edited by tjferriss Loading

melvin-bot bot commented Aug 10, 2023

tjferriss commented Aug 15, 2023

fedirjh commented Aug 17, 2023

BugZero Checklist:

tjferriss commented Aug 17, 2023

dukenv0307 commented Nov 22, 2023

tjferriss commented Nov 22, 2023

lanitochka17 commented Jul 18, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jul 18, 2023 •

edited by tjferriss

Loading

dukenv0307 commented Jul 19, 2023 •

edited

Loading

melvin-bot bot commented Aug 10, 2023 •

edited by tjferriss

Loading