-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for checklist] [$1000] Web - Pointer cursor is displayed on deleted member of workspace when deleted in offline mode #23890
Comments
Triggered auto assignment to @greg-schroeder ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Pointer cursor is displayed on deleted member of workspace when deleted in offline mode. What is the root cause of that problem?Currently, we don't disable the item when it has delete
What changes do you think we should make in order to solve the problem?Change LOC above to: const disabled = props.session.email === item.login || item.role === 'admin' || item.pendingAction === 'delete'; |
Job added to Upwork: https://www.upwork.com/jobs/~014b2a9bab227bac96 |
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @ginsuma 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app! |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-08-16. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue: As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Issue Participants: Issue reported by: @dhanashree-sawant Was this issue merged in time to be eligible for the speed bonus? No (context) Payment summary: Reporter: $250 |
Just awaiting checklist @fedirjh |
BugZero Checklist:
Regression Test Proposal
Do we agree 👍 or 👎 |
@greg-schroeder I think this issue is eligible for the speed bonus. It seems @Gonals was OOO when the PR is ready to be merged. |
Okay sure |
I sent updated offers for that. Once the checklist is complete we can close this. |
Thank you, Accepted.
Checklist : #23890 (comment) |
I accepted. |
Paid those bonuses out. Filing regression test. Closing accordingly. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
App should display 'not-allowed' cursor on deleted item deleted in offline mode
Actual Result:
App displays 'pointer' cursor on deleted member deleted in offline mode on workspace members page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
pointer.cursor.on.deleted.workspace.member.mp4
Recording.4010.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690617307322089
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: