[HOLD for checklist] [$1000] Web - Pointer cursor is displayed on deleted member of workspace when deleted in offline mode

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings
3. Open workspaces
4. Open any workspace
5. Open members
6. If only 1 member then invite few members and switch off the internet
7. On members page, remove any member
8. Hover on removed member and observe that pointer cursor is displayed (We display not-allowed cursor on deleted items throughout the app), in case member is not visible, go back and reopen members

Expected Result:

App should display 'not-allowed' cursor on deleted item deleted in offline mode

Actual Result:

App displays 'pointer' cursor on deleted member deleted in offline mode on workspace members page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.47-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

pointer.cursor.on.deleted.workspace.member.mp4

Recording.4010.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690617307322089

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b2a9bab227bac96
• Upwork Job ID: 1686036911311564800
• Last Price Increase: 2023-07-31
• Automatic offers:
• fedirjh | Reviewer | 25901002
• ginsuma | Contributor | 25901003
• dhanashree-sawant | Reporter | 25901006

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pointer cursor is displayed on deleted member of workspace when deleted in offline mode.

What is the root cause of that problem?

Currently, we don't disable the item when it has delete pendingAction.

App/src/pages/workspace/WorkspaceMembersPage.js

Line 297 in eb02006

const disabled = props.session.email === item.login || item.role === 'admin';

What changes do you think we should make in order to solve the problem?

Change LOC above to:

 const disabled = props.session.email === item.login || item.role === 'admin' || item.pendingAction === 'delete'; 

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b2a9bab227bac96

[melvin-bot]

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

@ginsuma's proposal looks straightforward fix to me. Let's proceed with it.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Gonals, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @ginsuma 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[ginsuma]

Thanks for accepting my proposal. The PR #24065 is ready for review.
cc: @fedirjh @Gonals

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @ginsuma got assigned: 2023-08-02 10:33:10 Z
• when the PR got merged: 2023-08-07 11:28:35 UTC
• days elapsed: 3

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.51-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update cursor for deleted members in offline mode #24065

If no regressions arise, payment will be issued on 2023-08-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ginsuma requires payment offer (Contributor)
• @fedirjh requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

Issue Participants:

Issue reported by: @dhanashree-sawant
Contributor: @ginsuma
C+: @fedirjh

Was this issue merged in time to be eligible for the speed bonus? No (context)
Were their any regressions? No

Payment summary:

Reporter: $250
Contributor: $1000
C+: $1000

[greg-schroeder]

Just awaiting checklist @fedirjh

[fedirjh]

BugZero Checklist:

• Link to the PR: This is not a regression but it could have been handled in Fix: Disable admin checkbox and checkbox all #21375
• Link to comment: Fix: Disable admin checkbox and checkbox all #21375 (comment)
• Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1692268203454829?thread_ts=1692190633.590849&cid=C049HHMV9SM
• Determine if we should create a regression test for this bug: yes

---

Regression Test Proposal

1. Go to Settings> Workspaces
2. Select any workspace > Members
3. Switch off the internet.
4. Delete a member.
5. Verify that the disabled cursor is displayed when hovering over the deleted member.

Do we agree 👍 or 👎

[fedirjh]

Was this issue merged in time to be eligible for the speed bonus? No (context)

@greg-schroeder I think this issue is eligible for the speed bonus. It seems @Gonals was OOO when the PR is ready to be merged.

[greg-schroeder]

Okay sure

[greg-schroeder]

I sent updated offers for that. Once the checklist is complete we can close this.

[fedirjh]

I sent updated offers for that.

Thank you, Accepted.

Once the checklist is complete we can close this.

Checklist : #23890 (comment)

[ginsuma]

I sent updated offers for that. Once the checklist is complete we can close this.

I accepted.

[greg-schroeder]

Paid those bonuses out. Filing regression test. Closing accordingly.