-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-11] [$1000] Task - Time zone message for assignee disappears and does not update when changing assignee #24420
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Time zone message for assignee disappears and does not update when changing assignee. What is the root cause of that problem?If create a task, app does not set the task report's Lines 2205 to 2217 in 39ae317
And Lines 813 to 829 in 39ae317
So after create a task, does not show time zone for assignee. After go to the parent report and navigate back, or refresh the task page, app sends If we change the task assignee, app does not change the report's But if we go to the parent report and navigate back, or refresh the task page, So app does not show time zone for assignee. What changes do you think we should make in order to solve the problem?For the task report, we should show the report const reportRecipient = ReportUtils.isTaskReport(this.props.report) ? this.props.personalDetails[this.props.report.managerID] : this.props.personalDetails[participantsWithoutExpensifyAccountIDs[0]]; And we should modify if (isTaskReport(report) && report.managerID !== 0) {
return true;
} What alternative solutions did you explore? (Optional)None. |
Yeah, I can reproduce this. Given we show the timezone of the task initial assignee, I think we'd want to update this if the assignee changes (perhaps unless you assign to yourself)? I also think we'd want to show the timezone of the assignee, as soon as they are assigned (rather than having to click out and back into the task). 2023-08-11_14-59-26.mp4 |
Job added to Upwork: https://www.upwork.com/jobs/~016b86a5af45ed94fa |
Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.The time zone message for task assignee disappears and never updates to a new one What is the root cause of that problem?We're not actively using the
What changes do you think we should make in order to solve the problem?For task report, we should use the
Other logic must remain, so we can ensure that if the task assignee did not reply to the current user, their personal timezone will not show which protects their privacy
The above method will also help remove the existing duplicated logic of getting the list of recipient account IDs between the What alternative solutions did you explore? (Optional)We can handle the
|
ProposalPlease re-state the problem that we are trying to solve in this issue.The time zone message for the assignee disappears and does not update when changing the assignee. Also does not show the Time zone immediately when the task is created as @joekaufmanexpensify What is the root cause of that problem?When the
Line 817 in 1e3f952
Also, the function Line 816 in 1e3f952
Lines 820 to 828 in 1e3f952
What changes do you think we should make in order to solve the problem?
Line 821 in 1e3f952
Change the line above as below to satisfy the conditions of a report of type task.
|
Proposals pending review |
@sobitneupane mind taking a look at proposals here when you have a chance? |
Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Pending review of proposal |
@youssef-lr could you confirm whether we're good to proceed with this proposal when you have a sec? TY! |
📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($1000) |
📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Proposal looks good to me as well. |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-11. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment due in a week. @sobitneupane mind completing the BZ checklist this week? |
@sobitneupane mind completing BZ checklist so we can issue payment? |
Bumped in Slack. |
Still pending. |
I don't think specific PR is responsible for this issue. We used existing
N/A
Not required.
Yes
|
Regression Test Proposal
Do we agree 👍 or 👎 |
BZ checklist is complete! |
All set to issue payment. |
This one does not qualify for the bonus. So we need to make the following payments:
|
@sobitneupane mind requesting $1,000 via NewDot and confirming here once complete? TY! |
@tienifr $1,000 sent and contract ended! |
Bumped payment request in NewDot. |
@sobitneupane could you please submit your payment request here so we can close this? |
@joekaufmanexpensify I am waiting to receive payment for the older requests. Once it is done, I will request payment for this one. It should not take long. |
Got it, sounds good! Moving to weekly then in the interim. |
@sobitneupane any update on this? |
Requested payment on newDot. |
TY! Closing this for now. Payment summary message is here. |
$1,000 payment approved for @sobitneupane based on BZ summary. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
The time zone message for task assignee above composer will update with the new assignee
Actual Result:
The time zone message for task assignee disappears and never updates to a new one
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.53.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6161026_bandicam_2023-08-11_12-56-28-195.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: