[HOLD for payment 2023-09-11] [$1000] Task - Time zone message for assignee disappears and does not update when changing assignee #24420

lanitochka17 · 2023-08-11T12:35:49Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
Assign a task to User A and select User B as Share somewhere destination
Open the task detail page
Tap on Assignee and change assignee to User C

Expected Result:

The time zone message for task assignee above composer will update with the new assignee

Actual Result:

The time zone message for task assignee disappears and never updates to a new one

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6161026_bandicam_2023-08-11_12-56-28-195.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~016b86a5af45ed94fa
Upwork Job ID: 1690077183610470400
Last Price Increase: 2023-08-11
Automatic offers:

tienifr | Contributor | 26202460

melvin-bot · 2023-08-11T12:35:54Z

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-08-11T12:35:56Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

StevenKKC · 2023-08-11T17:25:35Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Time zone message for assignee disappears and does not update when changing assignee.

What is the root cause of that problem?

If create a task, app does not set the task report's participantAccountIDs field, and CreateTask API does not return participantAccountIDs.

App/src/libs/ReportUtils.js

Lines 2205 to 2217 in 39ae317

    
           function buildOptimisticTaskReport(ownerAccountID, assigneeAccountID = 0, parentReportID, title, description) { 
        
               return { 
        
                   reportID: generateReportID(), 
        
                   reportName: title, 
        
                   description, 
        
                   ownerAccountID, 
        
                   managerID: assigneeAccountID, 
        
                   type: CONST.REPORT.TYPE.TASK, 
        
                   parentReportID, 
        
                   stateNum: CONST.REPORT.STATE_NUM.OPEN, 
        
                   statusNum: CONST.REPORT.STATUS.OPEN, 
        
               }; 
        
           }

And ReportUtils.canShowReportRecipientLocalTime checks the report's participantAccountIDs.

App/src/libs/ReportUtils.js

Lines 813 to 829 in 39ae317

    
           function canShowReportRecipientLocalTime(personalDetails, report, accountID) { 
        
               const reportParticipants = _.without(lodashGet(report, 'participantAccountIDs', []), accountID); 
        
               const participantsWithoutExpensifyAccountIDs = _.difference(reportParticipants, CONST.EXPENSIFY_ACCOUNT_IDS); 
        
               const hasMultipleParticipants = participantsWithoutExpensifyAccountIDs.length > 1; 
        
               const reportRecipient = personalDetails[participantsWithoutExpensifyAccountIDs[0]]; 
        
               const reportRecipientTimezone = lodashGet(reportRecipient, 'timezone', CONST.DEFAULT_TIME_ZONE); 
        
               const isReportParticipantValidated = lodashGet(reportRecipient, 'validated', false); 
        
               return Boolean( 
        
                   !hasMultipleParticipants && 
        
                       !isChatRoom(report) && 
        
                       !isPolicyExpenseChat(report) && 
        
                       reportRecipient && 
        
                       reportRecipientTimezone && 
        
                       reportRecipientTimezone.selected && 
        
                       isReportParticipantValidated, 
        
               ); 
        
           }

So after create a task, does not show time zone for assignee.

After go to the parent report and navigate back, or refresh the task page, app sends OpenReport API to BE, and then BE returns the report that has participantAccountIDs field.
So in this time, app shows time zone for assignee.

If we change the task assignee, app does not change the report's participantAccountIDs field, so app still shows the previous task assignee's time zone.

But if we go to the parent report and navigate back, or refresh the task page, OpenReport API returns the report that has participantAccountIDs with two account ids (the original and current task assignee ids).

So app does not show time zone for assignee.

What changes do you think we should make in order to solve the problem?

For the task report, we should show the report managerID's time zone instead of participantAccountIDs in this line.

const reportRecipient = ReportUtils.isTaskReport(this.props.report) ? this.props.personalDetails[this.props.report.managerID] : this.props.personalDetails[participantsWithoutExpensifyAccountIDs[0]];

And we should modify ReportUtils.canShowReportRecipientLocalTime to return true for the task report.

    if (isTaskReport(report) && report.managerID !== 0) {
        return true;
    }

What alternative solutions did you explore? (Optional)

None.

joekaufmanexpensify · 2023-08-11T19:05:16Z

Yeah, I can reproduce this. Given we show the timezone of the task initial assignee, I think we'd want to update this if the assignee changes (perhaps unless you assign to yourself)?

I also think we'd want to show the timezone of the assignee, as soon as they are assigned (rather than having to click out and back into the task).

2023-08-11_14-59-26.mp4

melvin-bot · 2023-08-11T19:06:17Z

Job added to Upwork: https://www.upwork.com/jobs/~016b86a5af45ed94fa

melvin-bot · 2023-08-11T19:06:20Z

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-11T19:06:26Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

tienifr · 2023-08-12T03:29:27Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The time zone message for task assignee disappears and never updates to a new one

What is the root cause of that problem?

We're not actively using the participantAccountIDs when operating with tasks:

We're not adding/editing it optimistically when creating/editing the task
When the assignee changes, BE is returning the participantAccountIDs with both the old assignee and new assignee

What changes do you think we should make in order to solve the problem?

For task report, we should use the managerID instead to determine the recipient local time.

Create a new getReportRecipientAccountIDs method to get the recipientAccountIDs, which works well for both regular report and task report. For task report, it should exclude current user account id if the task is assigned to current user.

function getReportRecipientAccountIDs(report, currentLoginAccountID) {
    const participantAccountIDs = isTaskReport(report) ? [report.managerID] : lodashGet(report, 'participantAccountIDs');
    const reportParticipants = _.without(participantAccountIDs, currentLoginAccountID);
    const participantsWithoutExpensifyAccountIDs = _.difference(reportParticipants, CONST.EXPENSIFY_ACCOUNT_IDS);
    return participantsWithoutExpensifyAccountIDs;
}

Use the above method in the canShowReportRecipientLocalTime here

const reportRecipientAccountIDs = getReportRecipientAccountIDs(report, accountID)
const hasMultipleParticipants = reportRecipientAccountIDs.length > 1;
const reportRecipient = personalDetails[reportRecipientAccountIDs[0]];

Other logic must remain, so we can ensure that if the task assignee did not reply to the current user, their personal timezone will not show which protects their privacy
3. Use the above method when getting the reportRecipient below this line

const reportRecipientAcountIDs = ReportUtils.getReportRecipientAccountIDs(this.props.report, this.props.currentUserPersonalDetails.accountID);
const reportRecipient = this.props.personalDetails[reportRecipientAcountIDs[0]];

The above method will also help remove the existing duplicated logic of getting the list of recipient account IDs between the canShowReportRecipientLocalTime and ReportActionCompose

What alternative solutions did you explore? (Optional)

We can handle the participantAccountIDs properly when operating with tasks:

Add/Edit it optimistically when creating/editing the task
When the assignee changes, BE should return participantAccountIDs that contains only the new assignee
If current user is assigned to the task, participantAccountIDs should be empty (BE should return empty as well)
Make sure participantAccountIDs is correct in all statuses of the task

Tony-MK · 2023-08-12T04:46:32Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The time zone message for the assignee disappears and does not update when changing the assignee. Also does not show the Time zone immediately when the task is created as @joekaufmanexpensify
stated in #24420 (comment).

What is the root cause of that problem?

When the reportRecipient object is fetched, it uses the first participant id in the participantsWithoutExpensifyAccountIDs array. Therefore, when the assignee of the task changes, the new assignee is pushed to the bottom of the array. Hence, the reportRecipient variable won't change to the current assignee.

App/src/pages/home/report/ReportActionCompose.js

Line 956 in 1e3f952

    
           const reportRecipient = this.props.personalDetails[participantsWithoutExpensifyAccountIDs[0]];

App/src/libs/ReportUtils.js

Line 817 in 1e3f952

    
           const reportRecipient = personalDetails[participantsWithoutExpensifyAccountIDs[0]];

Also, the function canShowReportRecipientLocalTime returns false when the participantsWithoutExpensifyAccountIDs array has more than one participant.

App/src/libs/ReportUtils.js

Line 816 in 1e3f952

    
           const hasMultipleParticipants = participantsWithoutExpensifyAccountIDs.length > 1;

App/src/libs/ReportUtils.js

Lines 820 to 828 in 1e3f952

    
           return Boolean( 
        
               !hasMultipleParticipants && 
        
                   !isChatRoom(report) && 
        
                   !isPolicyExpenseChat(report) && 
        
                   reportRecipient && 
        
                   reportRecipientTimezone && 
        
                   reportRecipientTimezone.selected && 
        
                   isReportParticipantValidated, 
        
           );

What changes do you think we should make in order to solve the problem?

We need to use the report.managerID when fetching the value for reportRecipient because the report.managerID variable is the id of the current assignee. Change the lines from the two first permalinks. To fetch the suitable reportRecipient value when the report is a task.

const reportRecipient = this.props.personalDetails[ReportUtils.isTaskReport(this.props.report) ? this.props.report.managerID : participantsWithoutExpensifyAccountIDs[0]]

const reportRecipient = personalDetails[isTaskReport(report) ? report.managerID : participantsWithoutExpensifyAccountIDs[0]]

The function canShowReportRecipientLocalTime needs to return true if a report of type task is not assigned to the owner. Regardless of the size of participants it has.

App/src/libs/ReportUtils.js

Line 821 in 1e3f952

!hasMultipleParticipants &&

Change the line above as below to satisfy the conditions of a report of type task.

isTaskReport(report) ? report.managerID != report.ownerID : !hasMultipleParticipants

joekaufmanexpensify · 2023-08-14T12:48:53Z

Proposals pending review

joekaufmanexpensify · 2023-08-15T20:31:36Z

@sobitneupane mind taking a look at proposals here when you have a chance?

sobitneupane · 2023-08-16T17:12:55Z

Thanks for proposal everyone.

@tienifr's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-08-16T17:13:03Z

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

joekaufmanexpensify · 2023-08-17T22:02:02Z

Pending review of proposal

joekaufmanexpensify · 2023-08-18T17:59:51Z

@youssef-lr could you confirm whether we're good to proceed with this proposal when you have a sec? TY!

melvin-bot · 2023-08-18T18:05:45Z

📣 @sobitneupane Please request via NewDot manual requests for the Reviewer role ($1000)

melvin-bot · 2023-08-18T18:05:49Z

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

youssef-lr · 2023-08-18T18:05:54Z

Proposal looks good to me as well.

melvin-bot · 2023-09-04T16:10:00Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: 24420 Timezone message for assignee disappears #25534

If no regressions arise, payment will be issued on 2023-09-11. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@sobitneupane does not require payment (Eligible for Manual Requests)
@tienifr requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-09-04T16:10:02Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR: I don't think specific PR is responsible for this issue. We used existing canShowReportRecipientLocalTime function in Task Report as well which behave quite differently.
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/316625

joekaufmanexpensify · 2023-09-04T17:53:41Z

Payment due in a week. @sobitneupane mind completing the BZ checklist this week?

joekaufmanexpensify · 2023-09-11T13:18:22Z

@sobitneupane mind completing BZ checklist so we can issue payment?

joekaufmanexpensify · 2023-09-12T13:53:36Z

Bumped in Slack.

joekaufmanexpensify · 2023-09-13T13:15:22Z

Still pending.

sobitneupane · 2023-09-13T15:47:22Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

I don't think specific PR is responsible for this issue. We used existing canShowReportRecipientLocalTime function in Task Report as well which behave quite differently.

[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not required.

[@sobitneupane] Determine if we should create a regression test for this bug.

Yes

[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#24420 (comment)

sobitneupane · 2023-09-13T15:48:01Z

Regression Test Proposal

Assign a task to User A and select User B as Share somewhere destination
Open the task detail page
Tap on Assignee and change assignee to User C
Verify that the time zone message for task assignee above composer will update with the new assignee

Do we agree 👍 or 👎

joekaufmanexpensify · 2023-09-13T20:43:26Z

BZ checklist is complete!

joekaufmanexpensify · 2023-09-13T20:43:32Z

All set to issue payment.

joekaufmanexpensify · 2023-09-13T20:46:47Z

This one does not qualify for the bonus. So we need to make the following payments:

@tienifr - $1,000 for PR (paid via Upwork).
@sobitneupane $1,000 for C+ (paid via NewDot).

joekaufmanexpensify · 2023-09-13T20:47:03Z

@sobitneupane mind requesting $1,000 via NewDot and confirming here once complete? TY!

joekaufmanexpensify · 2023-09-18T02:47:27Z

@tienifr $1,000 sent and contract ended!

joekaufmanexpensify · 2023-09-19T03:04:53Z

Bumped payment request in NewDot.

joekaufmanexpensify · 2023-09-20T08:01:47Z

@sobitneupane could you please submit your payment request here so we can close this?

sobitneupane · 2023-09-20T09:11:39Z

@joekaufmanexpensify I am waiting to receive payment for the older requests. Once it is done, I will request payment for this one. It should not take long.

joekaufmanexpensify · 2023-09-21T07:53:51Z

Got it, sounds good! Moving to weekly then in the interim.

joekaufmanexpensify · 2023-09-25T03:02:16Z

@sobitneupane any update on this?

sobitneupane · 2023-09-25T05:03:28Z

Requested payment on newDot.

#24420 (comment)

joekaufmanexpensify · 2023-09-25T05:56:03Z

TY! Closing this for now. Payment summary message is here.

JmillsExpensify · 2023-09-28T00:58:24Z

$1,000 payment approved for @sobitneupane based on BZ summary.

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 11, 2023

melvin-bot bot assigned joekaufmanexpensify Aug 11, 2023

joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Aug 11, 2023

melvin-bot bot changed the title ~~Task - Time zone message for assignee disappears and does not update when changing assignee~~ [$1000] Task - Time zone message for assignee disappears and does not update when changing assignee Aug 11, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 11, 2023

melvin-bot bot assigned sobitneupane Aug 11, 2023

melvin-bot bot added the Overdue label Aug 14, 2023

melvin-bot bot removed the Overdue label Aug 14, 2023

melvin-bot bot assigned youssef-lr Aug 16, 2023

youssef-lr assigned tienifr Aug 18, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 18, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Sep 11, 2023

joekaufmanexpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 21, 2023

joekaufmanexpensify closed this as completed Sep 25, 2023

[HOLD for payment 2023-09-11] [$1000] Task - Time zone message for assignee disappears and does not update when changing assignee #24420

[HOLD for payment 2023-09-11] [$1000] Task - Time zone message for assignee disappears and does not update when changing assignee #24420

Comments

lanitochka17 commented Aug 11, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Aug 11, 2023

melvin-bot bot commented Aug 11, 2023 • edited by joekaufmanexpensify Loading

Bug0 Triage Checklist (Main S/O)

StevenKKC commented Aug 11, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

joekaufmanexpensify commented Aug 11, 2023

melvin-bot bot commented Aug 11, 2023

melvin-bot bot commented Aug 11, 2023

melvin-bot bot commented Aug 11, 2023

tienifr commented Aug 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Tony-MK commented Aug 12, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

joekaufmanexpensify commented Aug 14, 2023

joekaufmanexpensify commented Aug 15, 2023

sobitneupane commented Aug 16, 2023

melvin-bot bot commented Aug 16, 2023

joekaufmanexpensify commented Aug 17, 2023

joekaufmanexpensify commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

melvin-bot bot commented Aug 18, 2023

youssef-lr commented Aug 18, 2023

melvin-bot bot commented Sep 4, 2023 • edited by joekaufmanexpensify Loading

melvin-bot bot commented Sep 4, 2023 • edited by joekaufmanexpensify Loading

joekaufmanexpensify commented Sep 4, 2023

joekaufmanexpensify commented Sep 11, 2023 • edited Loading

joekaufmanexpensify commented Sep 12, 2023

joekaufmanexpensify commented Sep 13, 2023

sobitneupane commented Sep 13, 2023 • edited Loading

sobitneupane commented Sep 13, 2023

joekaufmanexpensify commented Sep 13, 2023

joekaufmanexpensify commented Sep 13, 2023

joekaufmanexpensify commented Sep 13, 2023

joekaufmanexpensify commented Sep 13, 2023

joekaufmanexpensify commented Sep 18, 2023

joekaufmanexpensify commented Sep 19, 2023

joekaufmanexpensify commented Sep 20, 2023

sobitneupane commented Sep 20, 2023

joekaufmanexpensify commented Sep 21, 2023

joekaufmanexpensify commented Sep 25, 2023

sobitneupane commented Sep 25, 2023

joekaufmanexpensify commented Sep 25, 2023

JmillsExpensify commented Sep 28, 2023

lanitochka17 commented Aug 11, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Aug 11, 2023 •

edited by joekaufmanexpensify

Loading

StevenKKC commented Aug 11, 2023 •

edited

Loading

Tony-MK commented Aug 12, 2023 •

edited

Loading

melvin-bot bot commented Sep 4, 2023 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Sep 4, 2023 •

edited by joekaufmanexpensify

Loading

joekaufmanexpensify commented Sep 11, 2023 •

edited

Loading

sobitneupane commented Sep 13, 2023 •

edited

Loading