Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'AttachmentModal.js' component to TypeScript #25130

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Not a priority Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/AttachmentModal.js 27
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0109f7bd6406f7d5f0
  • Upwork Job ID: 1750959545163374592
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • c3024 | Reviewer | 28124256
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Overdue label Nov 21, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@kubabutkiewicz
Copy link
Contributor

Hi, I'm Jakub from Callstack - expert contributor group - and I would like to take a look at this issue.

Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@c3024
Copy link
Contributor

c3024 commented Jan 26, 2024

🎀 👀 🎀 C+ Reviewed

for assigning internal engineer to #33929

Copy link
Author

melvin-bot bot commented Jan 26, 2024

Current assignee @blimpich is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@blimpich blimpich added the External Added to denote the issue can be worked on by a contributor label Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'AttachmentModal.js' component to TypeScript [$500] [TS migration] Migrate 'AttachmentModal.js' component to TypeScript Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0109f7bd6406f7d5f0

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

@blimpich blimpich added Help Wanted Apply this label when an issue is open to proposals by contributors Bug Something is broken. Auto assigns a BugZero manager. labels Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@blimpich blimpich removed Bug Something is broken. Auto assigns a BugZero manager. Help Wanted Apply this label when an issue is open to proposals by contributors labels Jan 26, 2024
@blimpich
Copy link
Contributor

Added bug label to get a bug zero team member on this to handle payment later on. Looks like we're close to getting the PR in.

@melvin-bot melvin-bot bot added the NewFeature Something to build that is a new item. label Jan 30, 2024
Copy link
Author

melvin-bot bot commented Jan 30, 2024

Current assignee @michaelhaxhiu is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 30, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 31, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'AttachmentModal.js' component to TypeScript [HOLD for payment 2024-02-07] [$250] [TS migration] Migrate 'AttachmentModal.js' component to TypeScript Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2024
Copy link
Author

melvin-bot bot commented Jan 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Jan 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@c3024] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@kadiealexander kadiealexander added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Feb 1, 2024
Copy link
Author

melvin-bot bot commented Feb 1, 2024

@c3024
Copy link
Contributor

c3024 commented Feb 5, 2024

No regression test is needed because this is a TS migration.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 7, 2024
@anmurali
Copy link

anmurali commented Feb 8, 2024

Payment issued to @c3024

@anmurali anmurali closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Not a priority Task Typescript Migration
Projects
Development

No branches or pull requests

7 participants